Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docgen: remove redundant SQL diagrams #96030

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

taroface
Copy link
Collaborator

Diagrams updated in #95591 were not generating HTML files as intended because of some redundant lines in the code. This removes the redundancies per @nickvigilante.

Epic: none

Release note: none

Release justification: non-production code change

@taroface taroface requested a review from a team as a code owner January 26, 2023 21:17
@blathers-crl
Copy link

blathers-crl bot commented Jan 26, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@taroface
Copy link
Collaborator Author

bors r=nickvigilante

@craig
Copy link
Contributor

craig bot commented Jan 27, 2023

Build succeeded:

@craig craig bot merged commit b23943c into cockroachdb:master Jan 27, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jan 27, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from f7170c5 to blathers/backport-release-22.2-96030: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants