Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrades: share a column family for the new tenant columns #96099

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

knz
Copy link
Contributor

@knz knz commented Jan 27, 2023

Fixes #96093.

The previous change in that area was causing the new columns to be (implicitly) added into separate column families. However, we're expecting (from the bootstrap schema) to use a single column family for them. This patch fixes that.

Release note: None

The previous change in that area was causing the new columns to
be (implicitly) added into separate column families. However, we're
expecting (from the bootstrap schema) to use a single column family
for them. This patch fixes that.

Release note: None
@knz knz requested review from ajwerner and a team January 27, 2023 16:05
@blathers-crl
Copy link

blathers-crl bot commented Jan 27, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knz
Copy link
Contributor Author

knz commented Jan 27, 2023

bors r=ajwerner

@craig
Copy link
Contributor

craig bot commented Jan 27, 2023

Build succeeded:

@craig craig bot merged commit b23943c into cockroachdb:master Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: systemschema/validate-after-version-upgrade failed
3 participants