-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: v22.2.0-rc.3: no tables found in changeNonDescriptorBackedPrivilegesNode #92483
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
O-sentry
Originated from an in-the-wild panic report.
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Comments
cockroach-teamcity
added
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
O-sentry
Originated from an in-the-wild panic report.
labels
Nov 25, 2022
yuzefovich
changed the title
sentry: grant_revoke_system.go:204: no tables found
(1)
Wraps: (2) assertion failure
Wraps: (3) attached stack trace
-- stack trace:
| github.com/cockroachdb/cockroach/pkg/sql.(*changeNonDescriptorBackedP...
sql: v22.2.0-rc.2: no tables found in changeNonDescriptorBackedPrivilegesNode
Dec 3, 2022
yuzefovich
changed the title
sql: v22.2.0-rc.2: no tables found in changeNonDescriptorBackedPrivilegesNode
sql: v22.2.0-rc.3: no tables found in changeNonDescriptorBackedPrivilegesNode
Dec 3, 2022
blathers-crl
bot
added
T-sql-schema-deprecated
Use T-sql-foundations instead
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
labels
Dec 3, 2022
Alright found this one :) create user u;
create schema sc;
grant select on table sc.* to u; |
craig bot
pushed a commit
that referenced
this issue
Dec 7, 2022
91695: docs issue generation: Run script over a specified period of time r=nickvigilante a=nickvigilante The docs issue generation (DIG) script now runs nightly and uses a start and end time to calculate the PRs it needs to scan to determine if a docs issue must be created. This also utilizes GraphQL queries against GitHub's GraphQL API. Release note: None Fixes: #72910 92792: sql: Make USING EXTREMES predicates parsable r=michae2 a=faizaanmadhani Previously the USING EXTREMES predicates were constructed as strings which would make them very difficult to parse. This PR changes the way these predicates are constructed so that they can later be parsed. Release note (sql change): USING EXTREME predicates in the output of SHOW STATISTICS will have additional parenthesis and type assertions. Epic: CRDB-19449 93100: clisqlshell: correctly handle sending zero input for COPY r=rafiss a=otan Resolves #93051 Release note (bug fix): Previously, empty COPY commands would not escape after an EOF character or error if encountering a `\.` with no input. This is now resolved. 93101: sql/schemachanger: reassign owned by and concurrent declarative schema changer drops can conflict r=fqazi a=fqazi Informs: #87572 A number of bugs exist inside DROP OWNED / REASSIGNED OWNED BY inside the declarative schema changer: 1. If a concurrent DROP operation for schema/database with a REASSIGNED OWNED BY could lead to the descriptors being dropped incorrectly by legacy schema changer jobs. This patch adds additional logic to ensure that only descriptors marked for drops are cleaned up. 2. The DROP OWNED BY support inside the declarative schema changer requires no privileges to be defined, unfortunately, this logic did not have proper error handling 3. When cleaning up back-references from schemas to the database, we skipped certain operations if the database was dropped, which is true after any cascaded DROP DATABASE statement phase. Which can lead to other issues depending on the stages executed. 93173: sql: fix bug when using glob which matches nothing r=ajwerner a=ajwerner Logic in the 22.2 cycle for synthetic privileges erroneously assumed that if no physical tables matched, that it must mean that virtual tables matched. It also assumed that if the first entry in a pattern matched, it applied to all entries. Both of these assumptions were wrong. They lead to ugly panics. Fixes: #92483 Release note (bug fix): Fixed a bug whereby glob patterns which matched no tables in `GRANT` or `REVOKE` statements would return an internal error with a confusing message as opposed to the appropriate "no objects matched" error. Co-authored-by: Nick Vigilante <[email protected]> Co-authored-by: Faizaan Madhani <[email protected]> Co-authored-by: Oliver Tan <[email protected]> Co-authored-by: Faizan Qazi <[email protected]> Co-authored-by: Andrew Werner <[email protected]>
exalate-issue-sync
bot
removed
the
T-sql-schema-deprecated
Use T-sql-foundations instead
label
Dec 7, 2022
rafiss
pushed a commit
that referenced
this issue
Mar 24, 2023
Logic in the 22.2 cycle for synthetic privileges erroneously assumed that if no physical tables matched, that it must mean that virtual tables matched. It also assumed that if the first entry in a pattern matched, it applied to all entries. Both of these assumptions were wrong. They lead to ugly panics. Fixes: #92483 Release note (bug fix): Fixed a bug whereby glob patterns which matched no tables in `GRANT` or `REVOKE` statements would return an internal error with a confusing message as opposed to the appropriate "no objects matched" error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
O-sentry
Originated from an in-the-wild panic report.
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
This issue was autofiled by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.
Sentry link: https://sentry.io/organizations/cockroach-labs/issues/3767079531/?referrer=webhooks_plugin
Panic message:
Stacktrace (expand for inline code snippets):
cockroach/pkg/sql/grant_revoke_system.go
Lines 203 to 205 in 77667a1
cockroach/pkg/sql/grant_revoke_system.go
Lines 50 to 52 in 77667a1
cockroach/pkg/sql/plan.go
Lines 517 to 519 in 77667a1
cockroach/pkg/sql/walk.go
Lines 111 to 113 in 77667a1
cockroach/pkg/sql/walk.go
Lines 296 to 298 in 77667a1
cockroach/pkg/sql/walk.go
Lines 78 to 80 in 77667a1
cockroach/pkg/sql/walk.go
Lines 42 to 44 in 77667a1
cockroach/pkg/sql/plan.go
Lines 520 to 522 in 77667a1
cockroach/pkg/sql/plan_node_to_row_source.go
Lines 146 to 148 in 77667a1
cockroach/pkg/sql/colexec/columnarizer.go
Lines 177 to 179 in 77667a1
cockroach/pkg/sql/colflow/stats.go
Lines 89 to 91 in 77667a1
cockroach/pkg/sql/colflow/flow_coordinator.go
Lines 246 to 248 in 77667a1
cockroach/pkg/sql/colexecerror/error.go
Lines 91 to 93 in 77667a1
cockroach/pkg/sql/colflow/flow_coordinator.go
Lines 245 to 247 in 77667a1
cockroach/pkg/sql/colflow/flow_coordinator.go
Lines 290 to 292 in 77667a1
cockroach/pkg/sql/colflow/vectorized_flow.go
Lines 319 to 321 in 77667a1
cockroach/pkg/sql/distsql_running.go
Lines 694 to 696 in 77667a1
cockroach/pkg/sql/distsql_running.go
Lines 1610 to 1612 in 77667a1
cockroach/pkg/sql/distsql_running.go
Lines 1333 to 1335 in 77667a1
cockroach/pkg/sql/conn_executor_exec.go
Lines 1540 to 1542 in 77667a1
cockroach/pkg/sql/conn_executor_exec.go
Lines 1176 to 1178 in 77667a1
cockroach/pkg/sql/conn_executor_exec.go
Lines 686 to 688 in 77667a1
cockroach/pkg/sql/conn_executor_exec.go
Lines 128 to 130 in 77667a1
cockroach/pkg/sql/conn_executor_exec.go
Lines 2381 to 2383 in 77667a1
cockroach/pkg/sql/conn_executor_exec.go
Lines 127 to 129 in 77667a1
cockroach/pkg/sql/conn_executor.go
Lines 1919 to 1921 in 77667a1
cockroach/pkg/sql/conn_executor.go
Lines 1923 to 1925 in 77667a1
cockroach/pkg/sql/conn_executor.go
Lines 1845 to 1847 in 77667a1
cockroach/pkg/sql/conn_executor.go
Lines 827 to 829 in 77667a1
cockroach/pkg/sql/pgwire/conn.go
Lines 727 to 729 in 77667a1
src/runtime/asm_arm64.s#L1171-L1173 in runtime.goexit
v22.2.0-rc.3
Jira issue: CRDB-21800
The text was updated successfully, but these errors were encountered: