Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clisqlshell: correctly handle sending zero input for COPY #93100

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

otan
Copy link
Contributor

@otan otan commented Dec 6, 2022

Resolves #93051
Epic: CRDB-22182

Release note (bug fix): Previously, empty COPY commands would not escape after an EOF character or error if encountering a \. with no input. This is now resolved.

Release note (bug fix): Previously, empty COPY commands would not escape
after an EOF character or error if encountering a `\.` with no input.
This is now resolved.
@otan otan requested review from rafiss and a team December 6, 2022 02:53
@otan otan requested a review from a team as a code owner December 6, 2022 02:53
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan
Copy link
Contributor Author

otan commented Dec 7, 2022

blathers backport 22.1

@otan
Copy link
Contributor Author

otan commented Dec 7, 2022

(above was just a test of blathers)

@cockroachdb cockroachdb deleted a comment from blathers-crl bot Dec 7, 2022
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@otan
Copy link
Contributor Author

otan commented Dec 7, 2022

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Dec 7, 2022

Build succeeded:

@craig craig bot merged commit a9fcbd1 into cockroachdb:master Dec 7, 2022
@otan otan deleted the copy_empty branch December 8, 2022 15:04
@otan
Copy link
Contributor Author

otan commented Dec 8, 2022

blathers backport 22.1 22.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli/sql: COPY FROM STDIN does not handle an empty input
3 participants