sql: Make USING EXTREMES predicates parsable #92792
Conversation
|
This change is |
pkg/sql/distsql_plan_stats.go
Outdated
| lbExpr := tree.ComparisonExpr{ | ||
| Operator: treecmp.MakeComparisonOperator(treecmp.LT), | ||
| Left: &tree.ColumnItem{ColumnName: tree.Name(columnName)}, | ||
| Right: extremesSpans.Get(0).EndKey().Value(0), |
There was a problem hiding this comment.
nit: Both if/else cases look identical except for the span values. You could simplify things by just setting the two span values to variable in if/else and moving the expression tree construction outside the if/else.
nit: Some decomposition of constructUsingExtremesSpans might simplify things further so you don't have to reach into spans here. You could have a function that returns the histogram upper and lower bound, and pass those to both constructUsingExtremesSpans and constructUsingExtremesPredicate.
faizaanmadhani
force-pushed
the
faizaan/modify-predicate-serializing
branch
2 times, most recently
from
8e62759 to
1b50af0
Compare
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @faizaanmadhani and @mgartner)
-- commits line 12 at r2:
nit: We haven't released any version with USING EXTREMES yet, so I don't think you need a release note for this.
pkg/sql/distsql_plan_stats.go line 561 at r2 (raw file):
Left: &ubExpr, Right: &nullExpr, },
nit: This is total bikeshedding, but could we put the nullExpr to the left of the lbExpr? That better reflects what is happening (a [/ - /foo] span reads from the nulls first)
faizaanmadhani
force-pushed
the
faizaan/modify-predicate-serializing
branch
2 times, most recently
from
3317fcf to
2503273
Compare
|
TFTRs! 🎉 bors r=michae2 |
|
Build failed: |
|
bors r- |
Previously the USING EXTREMES predicates were constructed as strings which would make them very difficult to parse. This PR changes the way these predicates are constructed so that they can later be parsed. Release note: None Epic: CRDB-19449
faizaanmadhani
force-pushed
the
faizaan/modify-predicate-serializing
branch
from
2503273 to
495b4cb
Compare
|
bors r=michae2 |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Previously the USING EXTREMES predicates
were constructed as strings which would
make them very difficult to parse. This PR
changes the way these predicates are
constructed so that they can later be parsed.
Release note (sql change): USING EXTREME predicates in the output of
SHOW STATISTICS will have additional
parenthesis and type assertions.
Epic: CRDB-19449