-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccl/multiregionccl: TestMultiRegionDataDriven failed #92235
Comments
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ 2a71a5cca1f66313fd39956f1a3db070f67ade15:
Parameters: |
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ fd133ba3af3954c93584a501cf68dfa3131e586c:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ d978988afcfc78c02c23a3836ba90e4a4faeeb25:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ fc04d8e1eabf6b58d32e9792fd11f97c493480ad:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ 773649a2b08605ba2031dce9b3c8858b15803ca2:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ ea0e966fe05a788fd123a08cec8ef5e935fa5496:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ ea0e966fe05a788fd123a08cec8ef5e935fa5496:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ afab335620e28c5d8c849ba09e50ec12c2836b3f:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ 07a53a36601e9ca5fcffcff55f69b43c6dfbf1c1:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ 00ed5143845ec05797d16e6ab61d179cf51775f2:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ cce52c9eab1210c6cd508f6b99b2bad0ba3e1e56:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ 95b59e058c3dc01888204f46b6ff5a10962481e5:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ 81a114c2bc2ef8ef76fe3809d0469319c7e82635:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ f15ad13ff5b197f881f333085a2fda170857b50b:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ ab9f14774b18845d0fd0867aa8e35a60b2acc91c:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ b4d99da9798bb81dd338dea801056006296ec393:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ 888d521c163d8e8324dfe00a11ef9c2729d5f002:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ 799d8dbba62fa9c942a780584c71f8ceab784381:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ 799d8dbba62fa9c942a780584c71f8ceab784381:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ 848bd2439016f00a0e6de71dad838fb59bc9de4b:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ 84bb3f75313b900eba8493628f8e2807249f9129:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ 6ab0496d81d303bae3854ee810fe2233ce18791f:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ 9bbf9e626b4d159e0c19e1e78ef1923f79929920:
Parameters: Same failure on other branches
|
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ 31eb3ce6ceb18123fd2e7eac464b25e203d7de0f:
Parameters: Same failure on other branches
|
@e-mbrown can you skip this test during the |
96235: sem/tree: add support for producing vectorized data from strings r=cucaroach a=cucaroach tree.ValueHandler exposes raw machine type hooks that are used by vec_handler to build coldata.Vec's. Epic: CRDB-18892 Informs: #91831 Release note: None 96460: upgrades,systemschema: add covering index to system.privileges on `path` r=andyyang890 a=e-mbrown Resolves #93525 Queries to the `system.privileges` table are usually filtered by path. With a primary key using `(user,path)` all those queries were full scans. This commit changes the primary key to be `(path,user)`. Release note: None 97272: *: update to use full package name for `option go_package` in protos r=rail,stevendanna,RaduBerinde a=rickystewart Everywhere in the entire tree we use `option go_package` statements like the following: ``` option go_package = "build"; ``` We do this *instead of* using the entire fully-qualified package name, like: ``` option go_package = "github.com/cockroachdb/cockroach/pkg/build"; ``` This is apparently just an error. All the documentation I have seen (https://github.com/cockroachdb/gogoproto/blob/master/README) suggests that the fully-qualified package name should be used here. Further, this caused the `make` build to break after a refactor as the code generator doesn't know how to import a package like `"roachpb"` (since it should instead be importing `"github.com/cockroachdb/cockroach/pkg/roachpb"`). Correct this problem *everywhere* and update the `Makefile` to set `paths=source_relative` to tell `protoc` that output files should be placed next to input files. Epic: none Release note: None 97443: kv: configure transaction uncertainty interval for reverse scan r=arulajmani a=nvanbenschoten This commit configures the transaction uncertainty intervals for reverse scans. This was initially missed in 261fc35, which broke the use of observed timestamps for reverse scans. In 0ee3bbd, we started using this new plumbing path for the entire uncertainty interval, so the pessimization became a correctness bug that could lead to a loss of real-time ordering between a write and a reverse scan in cases with moderate but bounded clock skew between nodes. The commit adds testing for this case and the ScanRequest case. I should have exercised these cases back in 8445150 when I noticed there was a complete absence of end-to-end testing for uncertainty interval errors. Unfortunately, that commit only added testing for the GetRequest case, allowing the bug to slip in for ReverseScanRequest. Release note (bug fix): Transaction uncertainty intervals are correctly configured for reverse scans again, ensuring that reverse scans cannot serve stale reads when clocks in a cluster are skewed. Epic: None 97473: ccl/multiregionccl: Skip stress testing flaky secondary region test r=rafiss a=e-mbrown Informs: #92235 Release note: None 97484: release: fetch all tags for pick sha r=celiala a=rail Previously, the pick sha step relies on querying existing tags, but when a release is created on cherry-pick branch (staging-*), we don't have those tags in the local git checkout. This PR explicitly fetches all tags to have the cherry-pick release tags available locally. Fixes: RE-386 Epic: none Release note: None Co-authored-by: Tommy Reilly <[email protected]> Co-authored-by: e-mbrown <[email protected]> Co-authored-by: Ricky Stewart <[email protected]> Co-authored-by: Nathan VanBenschoten <[email protected]> Co-authored-by: Rail Aliiev <[email protected]>
98207: sql: add REPLICATION and MANAGETENANT system privileges r=msbutler a=stevendanna This adds two new system privileges: - `REPLICATION`: Allows the user to call the internal functions that produce a cross-cluster replication stream. - `MANAGETENANT`: Allows the user to create and manage tenants. A user with the MANAGETENANT privileges is now able to execute the following statements: - SHOW TENANT - SHOW TENANTS - CREATE TENANT - CREATE TENANT FROM REPLICATION STREAM - DROP TENANT (if it is part of an active stream) - ALTER TENANT A user with the REPLICATION privileges is able to call the following functions: - crdb_internal.start_replication_stream - crdb_internal.replication_stream_progress - crdb_internal.stream_partition - crdb_internal.replication_stream_spec - crdb_internal.complete_replication_stream Fixes #95425 Release note: None 98785: roachtest: de-flake multitenant-fairness/read-heavy/skewed r=irfansharif a=irfansharif Fixes #97448 (possibly). Fixes #78691. These tests run under severe CPU overload, and we see the workload getting observing the following errors: ERROR: liveness session expired 571.043163ms before transaction The SQL liveness lease extension work ends up getting severely starved, despite extending leases by 40s every 5s. It turns out for tenant SQL liveness work, we were using admissionpb.NormalPri, so such starvation was possible. This wasn't true for the system tenant where we bypassed AC altogether. Release note: None 98821: sql: TestRandomSyntaxGeneration fixes r=cucaroach a=cucaroach ### sql: fix some TestRandomSyntaxGeneration bugs The RSG works by calling format on the AST's it generates so its good at finding Format bugs. Fix a missing separator in ShowBackupOptions. Example: ``` SHOW BACKUP 'family' IN ('string', 'placeholder', 'placeholder', 'placeholder', 'string', 'placeholder', 'string', 'placeholder') WITH incremental_location = 'nullif', privilegesdebug_dump_metadata_sst ``` Fix bad construction in ShowTenant. Example: ``` SHOW TENANT [B'10010'] WITH REPLICATION STATUS WITH CAPABILITIES ``` Epic: none Release note: None ### copy: fix copy grammar to match PG Previously COPY would allow a wide range of syntax in the COPY TO substatement. Now like PG we limit it to a few things. PG grammar is: ``` PreparableStmt: SelectStmt | InsertStmt | UpdateStmt | DeleteStmt | MergeStmt ``` And now we do something similar. This prevents the wheels from coming off when RSG generates EXPLAIN's in the substatement for instance. Release note: none Epic: none 99109: kvserver: fortify TestReplicaClosedTimestamp r=erikgrinaker a=tbg This test was flaky until ~Feb 2nd. This has since resolved, likely as a result of some other change, however there's an easy way to make the test a bit more resilient by widening a critical section. Closes #93864 Epic: none Release note: None 99122: ccl/multiregionccl: skip flaky secondary_region test r=matthewtodd a=matthewtodd Part of #92235. Part of #98020. It [flaked][1] this morning, after last night's [other skip][2] landed. [1]: #98020 (comment) [2]: #99031 Release note: None Co-authored-by: Steven Danna <[email protected]> Co-authored-by: irfan sharif <[email protected]> Co-authored-by: Tommy Reilly <[email protected]> Co-authored-by: Tobias Grieger <[email protected]> Co-authored-by: Matthew Todd <[email protected]>
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ a875d58204554ea945300d183e5176bff6d4e703:
Parameters: Same failure on other branches
|
closing in favor of #98020 |
ccl/multiregionccl.TestMultiRegionDataDriven failed with artifacts on release-22.2 @ bf7c1cf83275be4645fc77581be2cb9d5e8502c4:
Parameters:
TAGS=bazel,gss
Help
See also: How To Investigate a Go Test Failure (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-21666
The text was updated successfully, but these errors were encountered: