ccl/multiregionccl: skip flaky regional_by_table test #99031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Part of #98020. Release note: None
matthewtodd
requested review from
a team and
rafiss
and removed request for
a team
rafiss
approved these changes
Mar 20, 2023
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
98207: sql: add REPLICATION and MANAGETENANT system privileges r=msbutler a=stevendanna This adds two new system privileges: - `REPLICATION`: Allows the user to call the internal functions that produce a cross-cluster replication stream. - `MANAGETENANT`: Allows the user to create and manage tenants. A user with the MANAGETENANT privileges is now able to execute the following statements: - SHOW TENANT - SHOW TENANTS - CREATE TENANT - CREATE TENANT FROM REPLICATION STREAM - DROP TENANT (if it is part of an active stream) - ALTER TENANT A user with the REPLICATION privileges is able to call the following functions: - crdb_internal.start_replication_stream - crdb_internal.replication_stream_progress - crdb_internal.stream_partition - crdb_internal.replication_stream_spec - crdb_internal.complete_replication_stream Fixes #95425 Release note: None 98785: roachtest: de-flake multitenant-fairness/read-heavy/skewed r=irfansharif a=irfansharif Fixes #97448 (possibly). Fixes #78691. These tests run under severe CPU overload, and we see the workload getting observing the following errors: ERROR: liveness session expired 571.043163ms before transaction The SQL liveness lease extension work ends up getting severely starved, despite extending leases by 40s every 5s. It turns out for tenant SQL liveness work, we were using admissionpb.NormalPri, so such starvation was possible. This wasn't true for the system tenant where we bypassed AC altogether. Release note: None 98821: sql: TestRandomSyntaxGeneration fixes r=cucaroach a=cucaroach ### sql: fix some TestRandomSyntaxGeneration bugs The RSG works by calling format on the AST's it generates so its good at finding Format bugs. Fix a missing separator in ShowBackupOptions. Example: ``` SHOW BACKUP 'family' IN ('string', 'placeholder', 'placeholder', 'placeholder', 'string', 'placeholder', 'string', 'placeholder') WITH incremental_location = 'nullif', privilegesdebug_dump_metadata_sst ``` Fix bad construction in ShowTenant. Example: ``` SHOW TENANT [B'10010'] WITH REPLICATION STATUS WITH CAPABILITIES ``` Epic: none Release note: None ### copy: fix copy grammar to match PG Previously COPY would allow a wide range of syntax in the COPY TO substatement. Now like PG we limit it to a few things. PG grammar is: ``` PreparableStmt: SelectStmt | InsertStmt | UpdateStmt | DeleteStmt | MergeStmt ``` And now we do something similar. This prevents the wheels from coming off when RSG generates EXPLAIN's in the substatement for instance. Release note: none Epic: none 99109: kvserver: fortify TestReplicaClosedTimestamp r=erikgrinaker a=tbg This test was flaky until ~Feb 2nd. This has since resolved, likely as a result of some other change, however there's an easy way to make the test a bit more resilient by widening a critical section. Closes #93864 Epic: none Release note: None 99122: ccl/multiregionccl: skip flaky secondary_region test r=matthewtodd a=matthewtodd Part of #92235. Part of #98020. It [flaked][1] this morning, after last night's [other skip][2] landed. [1]: #98020 (comment) [2]: #99031 Release note: None Co-authored-by: Steven Danna <[email protected]> Co-authored-by: irfan sharif <[email protected]> Co-authored-by: Tommy Reilly <[email protected]> Co-authored-by: Tobias Grieger <[email protected]> Co-authored-by: Matthew Todd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #98020.
Release note: None