Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl/multiregionccl: Skip stress testing flaky secondary region test #97473

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

e-mbrown
Copy link
Contributor

Informs: #92235
Release note: None

@e-mbrown e-mbrown requested a review from rafiss February 22, 2023 15:43
@e-mbrown e-mbrown requested a review from a team as a code owner February 22, 2023 15:43
@cockroach-teamcity
Copy link
Member

This change is Reviewable

ctx := context.Background()
datadriven.Walk(t, datapathutils.TestDataPath(t), func(t *testing.T, path string) {

if strings.Contains(path, "secondary_region") {
skip.UnderStress(t, "flaky test")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a link to #92235 here, so people know if the skip is removed, the issue should be closed?

@e-mbrown
Copy link
Contributor Author

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Feb 22, 2023

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Feb 22, 2023

Build succeeded:

@craig craig bot merged commit 3a532ac into cockroachdb:master Feb 22, 2023
@blathers-crl
Copy link

blathers-crl bot commented Feb 22, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 4ea7bc8 to blathers/backport-release-22.2-97473: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants