Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testutils/lint: TestLint failed #86838

Closed
cockroach-teamcity opened this issue Aug 25, 2022 · 1 comment · Fixed by #86865
Closed

testutils/lint: TestLint failed #86838

cockroach-teamcity opened this issue Aug 25, 2022 · 1 comment · Fixed by #86865
Assignees
@ecwall
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
22.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Aug 25, 2022 •
edited by cockroach-jira-scripts
Loading

testutils/lint.TestLint failed with artifacts on master @ ec73c69d203f9018d308e7798b382f289d470092:

=== RUN   TestLint
--- FAIL: TestLint (1073.75s)
=== RUN   TestLint/TestStaticCheck
    lint_test.go:1773: 
        pkg/sql/ttl/ttljob/ttljob_test.go:423:10: const expiredRowsPerRange is unused (U1000)
    --- FAIL: TestLint/TestStaticCheck (863.73s)

Parameters: GOFLAGS=-json

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/test-eng

This test on roachdash | Improve this report!

Jira issue: CRDB-18961
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Aug 25, 2022
@cockroach-teamcity cockroach-teamcity added this to the 22.2 milestone Aug 25, 2022
@ecwall ecwall mentioned this issue Aug 25, 2022
Merged
@cockroach-teamcity
Copy link
Member Author

testutils/lint.TestLint failed with artifacts on master @ 9a7ec4bc51bf5e3f1b469de318c0878470d681fb:

=== RUN   TestLint
--- FAIL: TestLint (1093.07s)
=== RUN   TestLint/TestStaticCheck
    lint_test.go:1773: 
        pkg/sql/ttl/ttljob/ttljob_test.go:423:10: const expiredRowsPerRange is unused (U1000)
    --- FAIL: TestLint/TestStaticCheck (876.76s)

Parameters: GOFLAGS=-json

Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@knz knz mentioned this issue Aug 25, 2022
Merged
@ecwall ecwall mentioned this issue Aug 25, 2022
Merged
@mgartner mgartner mentioned this issue Aug 25, 2022
Merged
craig bot pushed a commit that referenced this issue Aug 25, 2022
@matthewtodd @erikgrinaker
@knz @ecwall
Merge #86815 #86846 #86862 #86865
6b3cd4b 
86815: insights: report high contention time r=matthewtodd a=matthewtodd

This change aims to align with the logic for selecting transactions with
"high contention time"[^1] in the transaction insights UI, but in practice,
it's a best effort:

Because of the sampling nature of tracing and because a transaction with
"high" contention may be composed of many statements, each with only a
little contention, there's not a guarantee that a highly contented
transaction will be composed of highly contended statements.

But, on balance, the best effort is still valuable, and we will call out
actionable statements with high contention.

[^1]: Note that the protobuf enum name change is safe here as we haven't
  yet deployed this code.

Release justification: Category 2: Bug fixes and low-risk updates to new
functionality.

Release note: None

86846: storage: additional `TestMVCCHistories` cases for scan/get r=jbowens a=erikgrinaker

Touches #86655.

Release justification: non-production code changes

Release note: None

86862: acceptance: fix spurious docker test failure `unexpected extra event &{0 die} (after [])` r=rickystewart,renatolabs a=knz

Needed for #86049.

The root cause of the issue is that the docker container for the DB nodes were crashing, because the test framework **was incorrectly deleting the data/log directory before shutting down the nodes**.

However, this root cause was mostly hidden because of another mistake: the assertion that checks the health of the nodes was not doing its job properly in most cases. So it believed the nodes were healthy when in fact they were not.

This PR fixes both problems.

Informs #58955.
Informs #58951.
Informs #58218.

Release justification: non-production code changes

86865: ttl: remove unused const expiredRowsPerRange r=knz a=ecwall

fixes #86838

Release justification: Linter fix.
Release note: None

Co-authored-by: Matthew Todd <[email protected]>
Co-authored-by: Erik Grinaker <[email protected]>
Co-authored-by: Raphael 'kena' Poss <[email protected]>
Co-authored-by: Evan Wall <[email protected]>
@craig craig bot closed this as completed in dd89551 Aug 25, 2022
@yuzefovich yuzefovich mentioned this issue Aug 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecwall ecwall

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
22.2
Development

Successfully merging a pull request may close this issue.

ttl: remove unused const expiredRowsPerRange
2 participants
@ecwall @cockroach-teamcity