Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: additional TestMVCCHistories cases for scan/get #86846

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Aug 25, 2022

Touches #86655.

Release justification: non-production code changes

Release note: None

Release justification: non-production code changes

Release note: None
@erikgrinaker erikgrinaker requested review from tbg and a team August 25, 2022 09:07
@erikgrinaker erikgrinaker requested a review from a team as a code owner August 25, 2022 09:07
@erikgrinaker erikgrinaker self-assigned this Aug 25, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @tbg)

@erikgrinaker
Copy link
Contributor Author

bors r=jbowens

@craig
Copy link
Contributor

craig bot commented Aug 25, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 25, 2022

Build succeeded:

@craig craig bot merged commit 6b3cd4b into cockroachdb:master Aug 25, 2022
@erikgrinaker erikgrinaker deleted the mvcc-histories-scan-get branch August 26, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants