Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acceptance: TestDockerCSharp failed #58218

Closed
cockroach-teamcity opened this issue Dec 22, 2020 · 10 comments
Closed

acceptance: TestDockerCSharp failed #58218

cockroach-teamcity opened this issue Dec 22, 2020 · 10 comments
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. skipped-test

Comments

@cockroach-teamcity
Copy link
Member

(acceptance).TestDockerCSharp failed on master@2708ab530553ea1096c79af63ed823199b7a5c8e:

=== RUN   TestDockerCSharp
    test_log_scope.go:72: test logs captured to: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/acceptance/logTestDockerCSharp503040348
    test_log_scope.go:73: use -show-logs to present logs inline
=== CONT  TestDockerCSharp
    adapter_test.go:48: -- test log scope end --
test logs left over in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/acceptance/logTestDockerCSharp503040348
--- FAIL: TestDockerCSharp (16.80s)
=== RUN   TestDockerCSharp/runMode=docker
Flag --logtostderr has been deprecated, use --log instead to specify sinks.stderr.filter.
Cluster successfully initialized

Welcome to .NET Core!
---------------------
Learn more about .NET Core: https://aka.ms/dotnet-docs
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli-docs

Telemetry
---------
The .NET Core tools collect usage data in order to help us improve your experience. The data is anonymous and doesn't include command-line arguments. The data is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.

Read more about .NET Core CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry

ASP.NET Core
------------
Successfully installed the ASP.NET Core HTTPS Development Certificate.
To trust the certificate run 'dotnet dev-certs https --trust' (Windows and macOS only). For establishing trust on other platforms refer to the platform specific documentation.
For more information on configuring HTTPS see https://go.microsoft.com/fwlink/?linkid=848054.
Initial balances:
	account 1: 1000
	account 2: 250
Final balances:
	account 1: 900
	account 2: 350
    dockercluster.go:683: unexpected extra event &{0 die} (after [])
    --- FAIL: TestDockerCSharp/runMode=docker (11.36s)

More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestDockerCSharp PKG=./pkg/acceptance TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Dec 22, 2020
@cockroach-teamcity
Copy link
Member Author

(acceptance).TestDockerCSharp failed on master@7f3d64138b2efe23e62161543ce2872c14173b85:

=== RUN   TestDockerCSharp
    test_log_scope.go:72: test logs captured to: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/acceptance/logTestDockerCSharp537646588
    test_log_scope.go:73: use -show-logs to present logs inline
=== CONT  TestDockerCSharp
    adapter_test.go:48: -- test log scope end --
test logs left over in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/acceptance/logTestDockerCSharp537646588
--- FAIL: TestDockerCSharp (16.94s)
=== RUN   TestDockerCSharp/runMode=docker
Flag --logtostderr has been deprecated, use --log instead to specify sinks.stderr.filter.
Cluster successfully initialized

Welcome to .NET Core!
---------------------
Learn more about .NET Core: https://aka.ms/dotnet-docs
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli-docs

Telemetry
---------
The .NET Core tools collect usage data in order to help us improve your experience. The data is anonymous and doesn't include command-line arguments. The data is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.

Read more about .NET Core CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry

ASP.NET Core
------------
Successfully installed the ASP.NET Core HTTPS Development Certificate.
To trust the certificate run 'dotnet dev-certs https --trust' (Windows and macOS only). For establishing trust on other platforms refer to the platform specific documentation.
For more information on configuring HTTPS see https://go.microsoft.com/fwlink/?linkid=848054.
Initial balances:
	account 1: 1000
	account 2: 250
Final balances:
	account 1: 900
	account 2: 350
    dockercluster.go:683: unexpected extra event &{0 die} (after [])
    --- FAIL: TestDockerCSharp/runMode=docker (11.45s)

More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestDockerCSharp PKG=./pkg/acceptance TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(acceptance).TestDockerCSharp failed on master@08c89a597a06520c30faf01965f9c74fe9b9854f:

=== RUN   TestDockerCSharp
    test_log_scope.go:72: test logs captured to: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/acceptance/logTestDockerCSharp164644788
    test_log_scope.go:73: use -show-logs to present logs inline
=== CONT  TestDockerCSharp
    adapter_test.go:48: -- test log scope end --
test logs left over in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/acceptance/logTestDockerCSharp164644788
--- FAIL: TestDockerCSharp (17.18s)
=== RUN   TestDockerCSharp/runMode=docker
Flag --logtostderr has been deprecated, use --log instead to specify sinks.stderr.filter.
Cluster successfully initialized

Welcome to .NET Core!
---------------------
Learn more about .NET Core: https://aka.ms/dotnet-docs
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli-docs

Telemetry
---------
The .NET Core tools collect usage data in order to help us improve your experience. The data is anonymous and doesn't include command-line arguments. The data is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.

Read more about .NET Core CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry

ASP.NET Core
------------
Successfully installed the ASP.NET Core HTTPS Development Certificate.
To trust the certificate run 'dotnet dev-certs https --trust' (Windows and macOS only). For establishing trust on other platforms refer to the platform specific documentation.
For more information on configuring HTTPS see https://go.microsoft.com/fwlink/?linkid=848054.
Initial balances:
	account 1: 1000
	account 2: 250
Final balances:
	account 1: 900
	account 2: 350
    dockercluster.go:683: unexpected extra event &{0 die} (after [])
    --- FAIL: TestDockerCSharp/runMode=docker (11.72s)

More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestDockerCSharp PKG=./pkg/acceptance TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(acceptance).TestDockerCSharp failed on master@b2ac447d23c97332b705e288c055d63119fb8d28:

=== RUN   TestDockerCSharp
    test_log_scope.go:72: test logs captured to: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/acceptance/logTestDockerCSharp188574393
    test_log_scope.go:73: use -show-logs to present logs inline
=== CONT  TestDockerCSharp
    adapter_test.go:48: -- test log scope end --
test logs left over in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/acceptance/logTestDockerCSharp188574393
--- FAIL: TestDockerCSharp (17.17s)
=== RUN   TestDockerCSharp/runMode=docker
Flag --logtostderr has been deprecated, use --log instead to specify sinks.stderr.filter.
Cluster successfully initialized

Welcome to .NET Core!
---------------------
Learn more about .NET Core: https://aka.ms/dotnet-docs
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli-docs

Telemetry
---------
The .NET Core tools collect usage data in order to help us improve your experience. The data is anonymous and doesn't include command-line arguments. The data is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.

Read more about .NET Core CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry

ASP.NET Core
------------
Successfully installed the ASP.NET Core HTTPS Development Certificate.
To trust the certificate run 'dotnet dev-certs https --trust' (Windows and macOS only). For establishing trust on other platforms refer to the platform specific documentation.
For more information on configuring HTTPS see https://go.microsoft.com/fwlink/?linkid=848054.
Initial balances:
	account 1: 1000
	account 2: 250
Final balances:
	account 1: 900
	account 2: 350
    dockercluster.go:683: unexpected extra event &{0 die} (after [])
    --- FAIL: TestDockerCSharp/runMode=docker (11.58s)

More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestDockerCSharp PKG=./pkg/acceptance TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(acceptance).TestDockerCSharp failed on master@15765c0fa9118885dda0bd2ad1384b8801c412c3:

=== RUN   TestDockerCSharp
    test_log_scope.go:72: test logs captured to: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/acceptance/logTestDockerCSharp032482835
    test_log_scope.go:73: use -show-logs to present logs inline
=== CONT  TestDockerCSharp
    adapter_test.go:48: -- test log scope end --
test logs left over in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/acceptance/logTestDockerCSharp032482835
--- FAIL: TestDockerCSharp (16.71s)
=== RUN   TestDockerCSharp/runMode=docker
Flag --logtostderr has been deprecated, use --log instead to specify sinks.stderr.filter.
Cluster successfully initialized

Welcome to .NET Core!
---------------------
Learn more about .NET Core: https://aka.ms/dotnet-docs
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli-docs

Telemetry
---------
The .NET Core tools collect usage data in order to help us improve your experience. The data is anonymous and doesn't include command-line arguments. The data is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.

Read more about .NET Core CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry

ASP.NET Core
------------
Successfully installed the ASP.NET Core HTTPS Development Certificate.
To trust the certificate run 'dotnet dev-certs https --trust' (Windows and macOS only). For establishing trust on other platforms refer to the platform specific documentation.
For more information on configuring HTTPS see https://go.microsoft.com/fwlink/?linkid=848054.
Initial balances:
	account 1: 1000
	account 2: 250
Final balances:
	account 1: 900
	account 2: 350
    dockercluster.go:683: unexpected extra event &{0 die} (after [])
    --- FAIL: TestDockerCSharp/runMode=docker (10.84s)

More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestDockerCSharp PKG=./pkg/acceptance TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(acceptance).TestDockerCSharp failed on master@3b9c6d2cc5de8603d0474b49bed5594fbf34d093:

=== RUN   TestDockerCSharp
    test_log_scope.go:72: test logs captured to: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/acceptance/logTestDockerCSharp037754649
    test_log_scope.go:73: use -show-logs to present logs inline
=== CONT  TestDockerCSharp
    adapter_test.go:48: -- test log scope end --
test logs left over in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/acceptance/logTestDockerCSharp037754649
--- FAIL: TestDockerCSharp (17.09s)
=== RUN   TestDockerCSharp/runMode=docker
Flag --logtostderr has been deprecated, use --log instead to specify sinks.stderr.filter.
Cluster successfully initialized

Welcome to .NET Core!
---------------------
Learn more about .NET Core: https://aka.ms/dotnet-docs
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli-docs

Telemetry
---------
The .NET Core tools collect usage data in order to help us improve your experience. The data is anonymous and doesn't include command-line arguments. The data is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.

Read more about .NET Core CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry

ASP.NET Core
------------
Successfully installed the ASP.NET Core HTTPS Development Certificate.
To trust the certificate run 'dotnet dev-certs https --trust' (Windows and macOS only). For establishing trust on other platforms refer to the platform specific documentation.
For more information on configuring HTTPS see https://go.microsoft.com/fwlink/?linkid=848054.
Initial balances:
	account 1: 1000
	account 2: 250
Final balances:
	account 1: 900
	account 2: 350
    dockercluster.go:683: unexpected extra event &{0 die} (after [])
    --- FAIL: TestDockerCSharp/runMode=docker (11.44s)

More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestDockerCSharp PKG=./pkg/acceptance TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

nkodali added a commit to nkodali/cockroach that referenced this issue Jan 11, 2021
Refs: cockroachdb#58218

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None
@cockroach-teamcity
Copy link
Member Author

(acceptance).TestDockerCSharp failed on master@23c9843a4cc900be9ad9c931f86dbf06c620d28a:

=== RUN   TestDockerCSharp
    test_log_scope.go:72: test logs captured to: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/acceptance/logTestDockerCSharp273916565
    test_log_scope.go:73: use -show-logs to present logs inline
=== CONT  TestDockerCSharp
    adapter_test.go:48: -- test log scope end --
test logs left over in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/acceptance/logTestDockerCSharp273916565
--- FAIL: TestDockerCSharp (16.30s)
=== RUN   TestDockerCSharp/runMode=docker
Flag --logtostderr has been deprecated, use --log instead to specify sinks.stderr.filter.
Cluster successfully initialized

Welcome to .NET Core!
---------------------
Learn more about .NET Core: https://aka.ms/dotnet-docs
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli-docs

Telemetry
---------
The .NET Core tools collect usage data in order to help us improve your experience. The data is anonymous and doesn't include command-line arguments. The data is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.

Read more about .NET Core CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry

ASP.NET Core
------------
Successfully installed the ASP.NET Core HTTPS Development Certificate.
To trust the certificate run 'dotnet dev-certs https --trust' (Windows and macOS only). For establishing trust on other platforms refer to the platform specific documentation.
For more information on configuring HTTPS see https://go.microsoft.com/fwlink/?linkid=848054.
Initial balances:
	account 1: 1000
	account 2: 250
Final balances:
	account 1: 900
	account 2: 350
    dockercluster.go:683: unexpected extra event &{0 die} (after [])
    --- FAIL: TestDockerCSharp/runMode=docker (10.83s)

More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestDockerCSharp PKG=./pkg/acceptance TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues

craig bot pushed a commit that referenced this issue Jan 11, 2021
58706: acceptance: skip TestDockerCSharp r=adityamaru a=nkodali

Refs: #58218

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None

Co-authored-by: Namrata Kodali <[email protected]>
@jlinder
Copy link
Collaborator

jlinder commented Feb 16, 2021

@spaskob What prompted you adding this issue to the dev-inf board?

@spaskob
Copy link
Contributor

spaskob commented Feb 17, 2021 via email

@rickystewart
Copy link
Collaborator

Looks like a dupe of #58955.

@nvanbenschoten nvanbenschoten removed their assignment Feb 23, 2021
@rickystewart
Copy link
Collaborator

#58955 (comment)

craig bot pushed a commit that referenced this issue Aug 25, 2022
86815: insights: report high contention time r=matthewtodd a=matthewtodd

This change aims to align with the logic for selecting transactions with
"high contention time"[^1] in the transaction insights UI, but in practice,
it's a best effort:

Because of the sampling nature of tracing and because a transaction with
"high" contention may be composed of many statements, each with only a
little contention, there's not a guarantee that a highly contented
transaction will be composed of highly contended statements.

But, on balance, the best effort is still valuable, and we will call out
actionable statements with high contention.

[^1]: Note that the protobuf enum name change is safe here as we haven't
  yet deployed this code.

Release justification: Category 2: Bug fixes and low-risk updates to new
functionality.

Release note: None

86846: storage: additional `TestMVCCHistories` cases for scan/get r=jbowens a=erikgrinaker

Touches #86655.

Release justification: non-production code changes

Release note: None

86862: acceptance: fix spurious docker test failure `unexpected extra event &{0 die} (after [])` r=rickystewart,renatolabs a=knz

Needed for #86049.

The root cause of the issue is that the docker container for the DB nodes were crashing, because the test framework **was incorrectly deleting the data/log directory before shutting down the nodes**.

However, this root cause was mostly hidden because of another mistake: the assertion that checks the health of the nodes was not doing its job properly in most cases. So it believed the nodes were healthy when in fact they were not.

This PR fixes both problems.

Informs #58955.
Informs #58951.
Informs #58218.

Release justification: non-production code changes

86865: ttl: remove unused const expiredRowsPerRange r=knz a=ecwall

fixes #86838

Release justification: Linter fix.
Release note: None

Co-authored-by: Matthew Todd <[email protected]>
Co-authored-by: Erik Grinaker <[email protected]>
Co-authored-by: Raphael 'kena' Poss <[email protected]>
Co-authored-by: Evan Wall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. skipped-test
Projects
None yet
Development

No branches or pull requests

6 participants