Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBConsole: sort items in the DropDown menues #78081

Closed
fabiog1901 opened this issue Mar 18, 2022 · 0 comments · Fixed by #78095
Closed

DBConsole: sort items in the DropDown menues #78081

fabiog1901 opened this issue Mar 18, 2022 · 0 comments · Fixed by #78095
Assignees
@gtr
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@fabiog1901
Copy link
Contributor

fabiog1901 commented Mar 18, 2022 •
edited by cockroach-jira-scripts
Loading

The dropdown menu used in the DBConsole (for example, the select App in the SQLActivity > Transaction/Statement pages) do not currently list the items alphabetically sorted. It would be nice to see the sorted list instead.

Example screenshot: Slack thread

Jira issue: CRDB-13958
@fabiog1901 fabiog1901 added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Mar 18, 2022
gtr pushed a commit to gtr/cockroach that referenced this issue Mar 18, 2022
ui: sort items in the sql activity dropdown menu
0905923 
Fixes cockroachdb#78081.

Previously, app names in the dropdown menu for the stmts, txns, and
sessions pages were unsorted. This change sorts these app names.

Release note (ui): app names in the dropdown menu are sorted.
@gtr gtr mentioned this issue Mar 18, 2022
Merged
gtr pushed a commit to gtr/cockroach that referenced this issue Mar 21, 2022
ui: sort items in the sql activity dropdown menu
6465328 
Fixes cockroachdb#78081.

Previously, app names in the dropdown menu for the stmts, txns, and
sessions pages were unsorted. This change sorts these app names.

Release note (ui change): app names and database names in the dropdown
menu are sorted.
gtr pushed a commit to gtr/cockroach that referenced this issue Mar 21, 2022
ui: sort items in the sql activity dropdown menu
b7e4efc 
Fixes cockroachdb#78081.

Previously, app names in the dropdown menu for the stmts, txns, and
sessions pages were unsorted. This change sorts these app names.

Release note (ui change): app names and database names in the dropdown
menu are sorted.
gtr pushed a commit to gtr/cockroach that referenced this issue Mar 21, 2022
ui: sort items in the sql activity dropdown menu
e7b6789 
Fixes cockroachdb#78081.

Previously, app names in the dropdown menu for the stmts, txns, and
sessions pages were unsorted. This change sorts these app names.

Release note (ui change): app names and database names in the dropdown
menu are sorted.
gtr pushed a commit to gtr/cockroach that referenced this issue Mar 21, 2022
ui: sort items in the sql activity dropdown menu
a6ea113 
Fixes cockroachdb#78081.

Previously, app names in the dropdown menu for the stmts, txns, and
sessions pages were unsorted. This change sorts these app names.

Release note (ui change): app names and database names in the dropdown
menu are sorted.
craig bot pushed a commit that referenced this issue Mar 23, 2022
@otan @aliher1911
@rafiss @arulajmani
Merge #77741 #77808 #78095 #78158 #78223 #78300
4eca06c 
77741: ttl: implement TTL scheduled job validation & fixup r=otan a=otan

See individual commits for review.

Resolves #75428

Release justification: high pri addition to new functionality

77808: clisqlshell: add ndjson as --format option r=rafiss a=otan

Resolves #73022

Release justification: low-risk new update

Release note: None

78095: ui: sort items in the sql activity dropdown menu r=gtr a=gtr

Fixes #78081.

Previously, app names in the dropdown menu for the stmts, txns, and
sessions pages were unsorted. This change sorts these app names.

Statements page:
<img width="584" alt="statements-page" src="https://user-images.githubusercontent.com/35943354/159062772-c3a39f9f-50b2-43b8-a635-77506b715456.png">

Transactions page:
<img width="584" alt="transactions-page" src="https://user-images.githubusercontent.com/35943354/159062801-ae172a16-9eee-4b5a-bc9b-b37b2ff6b1e5.png">

Sessions page:
<img width="444" alt="sessions-page" src="https://user-images.githubusercontent.com/35943354/159062817-83d4eb53-9c91-44ae-9788-a3bacf4e469d.png">

Release note (ui change): app names in the dropdown menu are sorted.

78158: cli: debug decode-key to support base64 r=tbg,erikgrinaker a=aliher1911

Previously decode-key supported hex encoded keys. When using json serialization of descriptors and recovery plans you need to decode keys that are base64 encoded.
This patch adds flag to select key encoding format.
The default mode stays the same so any existing tooling willwork as expected.

Release note: None

78223: descmetadata: fix condition for bumping table version r=ajwerner,RichardJCai a=rafiss

This condition was inverted incorrectly. If the cache is on, it's
important to bump the table version so the cache can be invalidated.

Release justification: high priority bugfix to new functionality.

Release note: None

78300: kvserver: don't GC if protected timestamp information isn't available r=arulajmani a=arulajmani

We only want to run GC on a replica that some PTS information (even if
it's stale). We don't want to run GC on a replica if no PTS information
is available however. This can happen if a Replica is being considered
for GC before the initial scan of the KVSubscriber has completed.

This wasn't an issue before this patch for implicit reasons -- this
patch just makes the check explicit and adds a test. Previously, we
wouldn't run GC if no PTS information was available because our lease
was guaranteed to be newer than the empty timestamp.

Release note: None

Co-authored-by: Oliver Tan <[email protected]>
Co-authored-by: Gerardo Torres <[email protected]>
Co-authored-by: Oleg Afanasyev <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>
Co-authored-by: arulajmani <[email protected]>
@craig craig bot closed this as completed in d510c9d Mar 23, 2022
maryliag pushed a commit to maryliag/cockroach that referenced this issue Jun 24, 2022
@maryliag
ui: sort items in the sql activity dropdown menu
107fb89 
Fixes cockroachdb#78081.

Previously, app names in the dropdown menu for the stmts, txns, and
sessions pages were unsorted. This change sorts these app names.

Release note (ui change): app names and database names in the dropdown
menu are sorted.
@maryliag maryliag mentioned this issue Jun 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gtr gtr

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: sort items in the sql activity dropdown menu gtr/cockroach
3 participants
@maryliag @fabiog1901 @gtr