cli: debug decode-key to support base64 #78158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
approved these changes
Mar 21, 2022
aliher1911
force-pushed
the
debug_keys_decode_base65
branch
from
b713489 to
7e85fbc
Compare
|
You are correct about mvcc having 0 timestamp for non mvcc keys. I was getting an error before, but it looks like it was because of some corrupted key itself. I just retested that and it indeed just adds ,0 suffix when I give it range keys. |
tbg
reviewed
Mar 21, 2022
tbg
approved these changes
Mar 21, 2022
erikgrinaker
approved these changes
Mar 21, 2022
aliher1911
force-pushed
the
debug_keys_decode_base65
branch
2 times, most recently
from
b01986a to
51d5c94
Compare
Previously decode-key supported hex encoded keys. When using json serialization of descriptors and recovery plans you need to decode keys that are base64 encoded. This patch adds flag to select key encoding format. The default mode stays the same so any existing tooling will work as expected. Release note: None
aliher1911
force-pushed
the
debug_keys_decode_base65
branch
from
51d5c94 to
87610fe
Compare
|
bors r=tbg,erikgrinaker |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously decode-key supported hex encoded keys. When using json serialization of descriptors and recovery plans you need to decode keys that are base64 encoded.
This patch adds flag to select key encoding format.
The default mode stays the same so any existing tooling willwork as expected.
Release note: None