-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: sort items in the sql activity dropdown menu #78095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @gtr)
-- commits, line 7 at r1:
can you also check the order for databases? this both we have both things properly sorted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @gtr)
Previously, maryliag (Marylia Gutierrez) wrote…
can you also check the order for databases? this both we have both things properly sorted
*this way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @maryliag)
Previously, maryliag (Marylia Gutierrez) wrote…
*this way
Done!
8fbde71
to
e7b6789
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
a6ea113
to
2ce72b3
Compare
Fixes cockroachdb#78081. Previously, app names in the dropdown menu for the stmts, txns, and sessions pages were unsorted. This change sorts these app names. Release note (ui change): app names and database names in the dropdown menu are sorted.
bors r+ |
Build succeeded: |
Fixes #78081.
Previously, app names in the dropdown menu for the stmts, txns, and
sessions pages were unsorted. This change sorts these app names.
Statements page:
Transactions page:
Sessions page:
Release note (ui change): app names in the dropdown menu are sorted.