Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: sort items in the sql activity dropdown menu #78095

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

gtr
Copy link
Contributor

@gtr gtr commented Mar 18, 2022

Fixes #78081.

Previously, app names in the dropdown menu for the stmts, txns, and
sessions pages were unsorted. This change sorts these app names.

Statements page:
statements-page

Transactions page:
transactions-page

Sessions page:
sessions-page

Release note (ui change): app names in the dropdown menu are sorted.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@gtr gtr requested a review from a team March 18, 2022 18:26
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @gtr)


-- commits, line 7 at r1:
can you also check the order for databases? this both we have both things properly sorted

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @gtr)


-- commits, line 7 at r1:

Previously, maryliag (Marylia Gutierrez) wrote…

can you also check the order for databases? this both we have both things properly sorted

*this way

@gtr gtr force-pushed the gtr-sort-dropdown branch from 0905923 to 6465328 Compare March 21, 2022 15:43
Copy link
Contributor Author

@gtr gtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @maryliag)


-- commits, line 7 at r1:

Previously, maryliag (Marylia Gutierrez) wrote…

*this way

Done!

@gtr gtr force-pushed the gtr-sort-dropdown branch 4 times, most recently from 8fbde71 to e7b6789 Compare March 21, 2022 17:41
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: once you have tests passing

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)

@gtr gtr force-pushed the gtr-sort-dropdown branch 2 times, most recently from a6ea113 to 2ce72b3 Compare March 22, 2022 21:16
Fixes cockroachdb#78081.

Previously, app names in the dropdown menu for the stmts, txns, and
sessions pages were unsorted. This change sorts these app names.

Release note (ui change): app names and database names in the dropdown
menu are sorted.
@gtr gtr force-pushed the gtr-sort-dropdown branch from 2ce72b3 to d510c9d Compare March 23, 2022 17:17
@gtr
Copy link
Contributor Author

gtr commented Mar 23, 2022

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 23, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DBConsole: sort items in the DropDown menues
3 participants