Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update table visuals of job page #70149

Closed
maryliag opened this issue Sep 13, 2021 · 10 comments · Fixed by #70374
Closed

update table visuals of job page #70149

maryliag opened this issue Sep 13, 2021 · 10 comments · Fixed by #70374
Assignees
@maryliag
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker

Comments

@maryliag
Copy link
Contributor

update the table on Jobs page so it uses the same style of all other pages on the console
@maryliag maryliag added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. branch-release-21.2 labels Sep 13, 2021
@maryliag maryliag self-assigned this Sep 13, 2021
@maryliag
Copy link
Contributor Author

maryliag commented Sep 17, 2021 •
edited
Loading

We're missing the tooltip texts for the Jobs table columns, I'm creating them (very basic and straightforward).
@Annebirzin , @ianjevans can you confirm if those are good like this or if there is any documentation links that I can add to any of those?

Description: Description of the job
Job ID: ID of the job
Users: User executing the job (currently this column says Users, should we change the column name to User?)
Creation Time: Creation time of the job
Status: Status of the job

Screen Shot 2021-09-17 at 3 20 46 PM

@maryliag maryliag mentioned this issue Sep 17, 2021
Merged
@Annebirzin
Copy link

Annebirzin commented Sep 17, 2021 •
edited
Loading

If @ianjevans agrees, I think it could make sense to use the descriptions and links provided in docs here

Also agree it would probably make sense to update to User

Screen Shot 2021-09-17 at 5 03 24 PM

cc @kevin-v-ngo

@ianjevans
Copy link
Contributor

I agree, though I guess we should alter Status to say: "Current job status or completion progress, and the total time the job took to complete."

@kevin-v-ngo
Copy link

Sounds good to me too.

+1 making 'Users' singular

@maryliag
Copy link
Contributor Author

maryliag commented Sep 17, 2021 •
edited
Loading

for the description, I don't think is "SQL statement that created the job", because we don't show the statement there, is indeed just a description of the job. Or maybe is a mix? If the job has a description, it shows that otherwise we should the statement?

maryliag added a commit to maryliag/cockroach that referenced this issue Sep 17, 2021
@maryliag
ui: updates the jobs table styling
3947d75 
This commit updates the style of the table on the Jobs page
and adds tooltips to its columns.

Resolves cockroachdb#70149

Release note (ui change): Updating job table style to
match all other tables on the console and also  update column name
from `Users` to `User`.
@ianjevans
Copy link
Contributor

+1 to adding the fingerprint If the job doesn't have a description, as otherwise how would the user know what that job does?
"The description of the job, if set, or the SQL statement if there is no job description."

@Annebirzin
Copy link

I think it is currently a mix of the job description or SQL statement - attached screenshot example of BACKUP statement.

Screen Shot 2021-09-20 at 10 50 37 AM

@maryliag
Copy link
Contributor Author

I used the tooltip suggested by Ian, which include both options: "The description of the job, if set, or the SQL statement if there is no job description."

@blathers-crl
Copy link

blathers-crl bot commented Sep 20, 2021

Hi @celiala, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@celiala
Copy link
Collaborator

celiala commented Sep 20, 2021

(apologies for the noise for this and other SQL Observability issues - updating blocker from release to GA, as noted in triage meeting, thanks!)

@celiala celiala removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Sep 20, 2021
craig bot pushed a commit that referenced this issue Sep 20, 2021
@rimadeodhar @otan
@maryliag @irfansharif
Merge #70325 #70347 #70374 #70432 #70436
bfdcfa0 
70325: vendor: Add dependency on prometheus r=dhartunian a=rimadeodhar

This PR adds an external dependency on prometheus. We need
the promql library in order to enforce validity of promql
expressions which will be contained in upcoming alerting
and aggregation rules. These rule implementations are
upcoming as a part of the new metrics upgrade.

Resolves #69796

Release note: None

70347: pgcode: use XC instead of CDB r=knz a=otan

Release note (sql change): Change the pgerror code XC instead of CD
for CockroachDB specific errors. This is because the "C" class is
reserved for the SQL standard. The pgcode `CDB00` used for
unsatisfiable bounded staleness is now `XCUBS`.

70374: ui: updates the jobs table styling r=maryliag a=maryliag

This commit updates the style of the table on the Jobs page
and adds tooltips to its columns.

Resolves #70149

Before
<img width="924" alt="Screen Shot 2021-09-17 at 3 35 04 PM" src="https://user-images.githubusercontent.com/1017486/133844066-3168bec7-db52-4194-9f97-c7b10628d98e.png">

After
<img width="880" alt="Screen Shot 2021-09-17 at 3 35 52 PM" src="https://user-images.githubusercontent.com/1017486/133844146-86e94611-ca99-4764-a97e-c8ca4e09f269.png">


Release note (ui change): Updating job table style to
match all other tables on the console.

70432: Revert "kv,migration: rm code handling legacy raft truncated state" r=irfansharif a=irfansharif

This reverts commit 6464de2. That PR
broke few of our roachtests since we haven't release the 21.2 beta yet.
For our roachtests that exercised the upgrade path, we were effectively
upgrading from 21.1 to 22.1 code (as of that PR) that asserted on the
completion of the long running migration removing the legacy raft
truncated state -- something that would only happen when going through
21.2. Given that, we temporarily revert #69887 while our beta gets
prepared. #69887 (or rather, the revert of _this_ commit) will be
re-introduced to master once #69826 lands.

Fixes #70244.
Fixes #70252.
Fixes #70253.
Fixes #70283.
Fixes #70350.
Fixes #70390.

Release note: None

70436: spanconfig: fix an erroneous usage of timeutil.Timer r=irfansharif a=irfansharif

The contract for timeutil.Timer indicates that we should only be
setting .Read when reading from the timer channel, not unconditionally
before a call to .Reset().

Release note: None

Co-authored-by: rimadeodhar <[email protected]>
Co-authored-by: Oliver Tan <[email protected]>
Co-authored-by: Marylia Gutierrez <[email protected]>
Co-authored-by: irfan sharif <[email protected]>
@craig craig bot closed this as completed in 13d5fbe Sep 20, 2021
blathers-crl bot pushed a commit that referenced this issue Sep 20, 2021
@maryliag
ui: updates the jobs table styling
da60172 
This commit updates the style of the table on the Jobs page
and adds tooltips to its columns.

Resolves #70149

Release note (ui change): Updating job table style to
match all other tables on the console and also  update column name
from `Users` to `User`.
@blathers-crl blathers-crl bot mentioned this issue Sep 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryliag maryliag

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: updates the jobs table styling maryliag/cockroach
5 participants
@maryliag @celiala @ianjevans @Annebirzin @kevin-v-ngo