Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: ui: updates the jobs table styling #70449

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 20, 2021

Backport 1/1 commits from #70374 on behalf of @maryliag.

/cc @cockroachdb/release


This commit updates the style of the table on the Jobs page
and adds tooltips to its columns.

Resolves #70149

Before
Screen Shot 2021-09-17 at 3 35 04 PM

After
Screen Shot 2021-09-17 at 3 35 52 PM

Release note (ui change): Updating job table style to
match all other tables on the console.


Release justification:

This commit updates the style of the table on the Jobs page
and adds tooltips to its columns.

Resolves #70149

Release note (ui change): Updating job table style to
match all other tables on the console and also  update column name
from `Users` to `User`.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-21.2-70374 branch from f1fd487 to da60172 Compare September 20, 2021 22:09
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 20, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@Azhng Azhng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag and @matthewtodd)

@maryliag maryliag merged commit 5202c97 into release-21.2 Sep 20, 2021
@jlinder jlinder deleted the blathers/backport-release-21.2-70374 branch October 5, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants