-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: version/mixed/nodes=5 failed [should stop after beta1] #70252
Comments
@irfansharif a v21.1.8 node crashed. I think (but you should check) that this is happening while rolling back from master to 21.1.8 (without having bumped the cluster version). I think we can safely assume this is fallout from #69887, please take a look as soon as you can. We're not backporting this but since it's entirely unexpected, it's still weird and we better find out what's causing it, it might have an effect on the release yet.
|
Labeling as GA-blocker, but this is just being conservative. It looks very likely that the fact that the mixed version tests are marrying incompatible versions at the moment is at fault here. This will rectify once the first beta is out. |
I'll take a look today if I get time during L2, thanks for catching it. |
roachtest.version/mixed/nodes=5 failed with artifacts on master @ 78c6771c7e9f7ba6431f44b067f27e0857341374:
|
roachtest.version/mixed/nodes=5 failed with artifacts on master @ d49fadb6f1c67d99ce91b719bac44b5640fa8e01:
|
roachtest.version/mixed/nodes=5 failed with artifacts on master @ d9278939d4be4d1109e9ed0a84c6e9cd2a8705bb:
|
This reverts commit 6464de2. That PR broke few of our roachtests since we haven't release the 21.2 beta yet. For our roachtests that exercised the upgrade path, we were effectively upgrading from 21.1 to 22.1 code (as of that PR) that asserted on the completion of the long running migration removing the legacy raft truncated state -- something that would only happen when going through 21.2. Given that, we temporarily revert cockroachdb#69887 while our beta gets prepared. cockroachdb#69887 (or rather, the revert of this commit) will be re-introduced to master once cockroachdb#69826 lands. Fixes cockroachdb#70244. Fixes cockroachdb#70252. Fixes cockroachdb#70253. Fixes cockroachdb#70283. Fixes cockroachdb#70350. Fixes cockroachdb#70390. Release note: None
70325: vendor: Add dependency on prometheus r=dhartunian a=rimadeodhar This PR adds an external dependency on prometheus. We need the promql library in order to enforce validity of promql expressions which will be contained in upcoming alerting and aggregation rules. These rule implementations are upcoming as a part of the new metrics upgrade. Resolves #69796 Release note: None 70347: pgcode: use XC instead of CDB r=knz a=otan Release note (sql change): Change the pgerror code XC instead of CD for CockroachDB specific errors. This is because the "C" class is reserved for the SQL standard. The pgcode `CDB00` used for unsatisfiable bounded staleness is now `XCUBS`. 70374: ui: updates the jobs table styling r=maryliag a=maryliag This commit updates the style of the table on the Jobs page and adds tooltips to its columns. Resolves #70149 Before <img width="924" alt="Screen Shot 2021-09-17 at 3 35 04 PM" src="https://user-images.githubusercontent.com/1017486/133844066-3168bec7-db52-4194-9f97-c7b10628d98e.png"> After <img width="880" alt="Screen Shot 2021-09-17 at 3 35 52 PM" src="https://user-images.githubusercontent.com/1017486/133844146-86e94611-ca99-4764-a97e-c8ca4e09f269.png"> Release note (ui change): Updating job table style to match all other tables on the console. 70432: Revert "kv,migration: rm code handling legacy raft truncated state" r=irfansharif a=irfansharif This reverts commit 6464de2. That PR broke few of our roachtests since we haven't release the 21.2 beta yet. For our roachtests that exercised the upgrade path, we were effectively upgrading from 21.1 to 22.1 code (as of that PR) that asserted on the completion of the long running migration removing the legacy raft truncated state -- something that would only happen when going through 21.2. Given that, we temporarily revert #69887 while our beta gets prepared. #69887 (or rather, the revert of _this_ commit) will be re-introduced to master once #69826 lands. Fixes #70244. Fixes #70252. Fixes #70253. Fixes #70283. Fixes #70350. Fixes #70390. Release note: None 70436: spanconfig: fix an erroneous usage of timeutil.Timer r=irfansharif a=irfansharif The contract for timeutil.Timer indicates that we should only be setting .Read when reading from the timer channel, not unconditionally before a call to .Reset(). Release note: None Co-authored-by: rimadeodhar <[email protected]> Co-authored-by: Oliver Tan <[email protected]> Co-authored-by: Marylia Gutierrez <[email protected]> Co-authored-by: irfan sharif <[email protected]>
roachtest.version/mixed/nodes=5 failed with artifacts on master @ 2baefd353239ddc4e7f4299b8930001675b99aa9:
Reproduce
See: roachtest README
This test on roachdash | Improve this report!
The text was updated successfully, but these errors were encountered: