sql: remove usage of catalogkv outside of catalog
#64134
Assignees
Labels
A-schema-descriptors
Relating to SQL table/db descriptor handling.
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Comments
ajwerner
added
C-enhancement
craig bot
pushed a commit
that referenced
this issue
Apr 23, 2021
63458: kvserverpb: remove some "proposer-evaluated KV" comments r=andreimatei a=andreimatei Old stuff. Release note: None 63730: jobs: remove very old logic around detecting orphaned schemachange jobs r=ajwerner a=ajwerner This code was to deal with the very old world when there was no job for schema changes. This is all part of an effort to hide the catalogkv interface. Release note: None 64054: sql: make descs.Collection usage more consistent r=ajwerner a=ajwerner This commit removes some undesirable uses of catalogkv in schema change logic. Relates to #64134. Release note: None 64055: sql: remove an unnecessary use of catalogkv r=ajwerner a=ajwerner Touches #64055. Release note: None 64112: ui: fix time delta in range report r=andreimatei a=andreimatei The function computing the delta from a timestamp to present time was mistakingly not using the passed-in now, but was reading the clock. This led to the same timestamp being computed as different deltas across replicas, which makes the report highlight the row. Release note: None Co-authored-by: Andrei Matei <[email protected]> Co-authored-by: Andrew Werner <[email protected]>
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this issue
Apr 24, 2021
…tors Also probably fixes a bug due to bad transaction retry handling in import. Touches cockroachdb#64134. Release note: None
craig bot
pushed a commit
that referenced
this issue
Apr 26, 2021
64178: sql,importccl: remove a use of catalogkv when creating schema descrip… r=ajwerner a=ajwerner …tors Also probably fixes a bug due to bad transaction retry handling in import. Touches #64134. Release note: None 64209: build: save roachtest stats for all release branches r=erikgrinaker a=tbg Previously, we were only storing the `stats.json` files for the `master` branch, meaning we'd fly blind for `release-*`. This change makes it so that we also upload the files for the release branches. We need to use a different artifacts dir so that roachperf does not mistakenly pick up `release-*` results as part of its data processing for the `master` branch[1]. At time of writing, roachperf is hard-wired to the `master` branch, so the newly collected information for `release-21.1` will not be picked up yet. cc @cockroachdb/test-eng [1]: https://github.com/cockroachdb/roachperf/blob/719f1e432762f8800886f36f0c5dcfd282e86aeb/main.go#L94-L97 Release note: None Co-authored-by: Andrew Werner <[email protected]> Co-authored-by: Tobias Grieger <[email protected]>
|
This has been done. |
exalate-issue-sync
bot
added
T-sql-foundations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
These lower-level APIs are error prone. They may miss modifications. They incur extra round-trips. They don't do the same type hydration. They will be incompatible with transactional schema changes.
Additional context
Relates to #64089.
Epic: CRDB-2454
Jira issue: CRDB-6913
The text was updated successfully, but these errors were encountered: