sql: make descs.Collection usage more consistent #64054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
force-pushed
the
ajwerner/descs-collection-schema-changer
branch
from
d4867a4 to
1a0c8de
Compare
postamar
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
LGTM, this is nice.
Can we have an issue for this please? I did a regex search for catalogkv.(Must)?Get\w+Desc\w+\( on master and got 68 hits, the vast majority in the sql package. It looks like a good chunk of these are easily replaceable with Collection methods.
This commit removes undesirable uses of catalogkv. Release note: None
ajwerner
force-pushed
the
ajwerner/descs-collection-schema-changer
branch
from
1a0c8de to
db38bdd
Compare
|
|
TFTR bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes some undesirable uses of catalogkv in schema change logic.
Relates to #64134.
Release note: None