ui: fix time delta in range report #64112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function computing the delta from a timestamp to present time was mistakingly not using the passed-in now, but was reading the clock. This led to the same timestamp being computed as different deltas across replicas, which makes the report highlight the row. Release note: None
I don't know why I wrote that nonsense. Release note: None
|
This change is |
dhartunian
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @andreimatei)
andreimatei
commented
Apr 23, 2021
There was a problem hiding this comment.
bors r+
Reviewable status:
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function computing the delta from a timestamp to present time was
mistakingly not using the passed-in now, but was reading the clock. This
led to the same timestamp being computed as different deltas across
replicas, which makes the report highlight the row.
Release note: None