-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEOS: panic for single MULTIPOLYGON within a GEOMETRYCOLLECTION #53254
Comments
(sql/distsql).TestAggregatorAgainstProcessor failed on master@79ffcf6f736523b704aa671195c732ece55e1c3e:
MoreParameters:
See this test on roachdash |
(sql/distsql).TestAggregatorAgainstProcessor failed on master@79ffcf6f736523b704aa671195c732ece55e1c3e:
MoreParameters:
See this test on roachdash |
the following query seg faults within GEOS territory:
|
53159: bulkio: Surface errors encountered during schedule planning or execution. r=dt a=miretskiy Fixes #52916 Fixes #53235 If an error is enountered during schedule planning, appropriate error messages are logged to the log file(s). However, the user might not have access to the logs on the machine. We now record the last "interesting" schedule event in a new column `schedule_state` in the `system.scheduled_jobs`, and display this event with `SHOW SCHEDULES` command. Whenever schedule completes with an error (either due to planning or execution), we set the `schedule_state` appropriately. When schedule completes without errors, we clear out `schedule_state`. Since we need to alter `system.scheduled_jobs` schema, this PR also updates the schema to: * Add a `NOT NULL` constraint to an `owner` field. * Drop `schedule_changes` column since the more complex, protocol buffer based column is no longer used. Release Notes: None 53240: builtins: implement ST_IsClosed, ST_IsSimple, and ST_IsRing r=otan a=erikgrinaker Release note (sql change): Implement the geometry builtins `ST_IsClosed`, `ST_IsSimple`, and `ST_IsRing`. Closes #48953. Closes #48958. Closes #48959. 53262: distsql: ignore ST_Union for test as it seg faults r=yuzefovich a=otan ST_Union seems to segfault in the GEOS world, not much I can do here. Ignore testing for now. Refs: #53254 Release note: None Co-authored-by: Yevgeniy Miretskiy <[email protected]> Co-authored-by: Erik Grinaker <[email protected]> Co-authored-by: Oliver Tan <[email protected]>
The bt output from a debug build:
The
It gets a dimension of 2 and assumes it is a |
The following seems to fix this
@otan are we directly making fixes in https://github.com/cockroachdb/geos/ |
ooh nice! yeah you can put an extra commit on top of you can submit a PR against the GEOS library too. |
…on to Polygon References https://trac.osgeo.org/geos/ticket/1047 References cockroachdb/cockroach#53254
…on to Polygon References https://trac.osgeo.org/geos/ticket/1047 References cockroachdb/cockroach#53254
The fix for us is at https://github.com/cockroachdb/geos/tree/mpcast And opened a PR for GEOS libgeos/geos#334 |
I will set up the PR. |
…on to Polygon References https://trac.osgeo.org/geos/ticket/1047 References cockroachdb/cockroach#53254
…on to Polygon References https://trac.osgeo.org/geos/ticket/1047 References cockroachdb/cockroach#53254
…on to Polygon References https://trac.osgeo.org/geos/ticket/1047 References cockroachdb/cockroach#53254
Resolves cockroachdb#53254. Release justification: bug fix to new functionality Release note: None
…on to Polygon References https://trac.osgeo.org/geos/ticket/1047 References cockroachdb/cockroach#53254
53800: server: defer gossip start to when absolutely needed r=irfansharif a=irfansharif This was pulled out of #52526 to keep the diff there focussed on the introduction of the RPC (and to see if that alone shaked out any failures). That change lets us make this one, were we can defer gossip start until right before we start up Node. Release justification: low risk, high benefit change to existing functionality Release note: None 53846: sql: fix inflated "overhead" in statement timings r=solongordon a=solongordon Fixes #40675 Fixes #50108 Release justification: Low-risk, high-reward fix to existing functionality. Release note (admin ui change): In some cases, the Execution Stats page would show a confusingly high Overhead latency for a statement. This could happen due to multiple statements being parsed together or due to statement execution being retried. To avoid this, we stop considering the time between when parsing ends and execution begins when determining service latency. 53906: roachtest: Unskip disk-full roachtest r=tbg a=itsbilal The disk-full roachtest no longer fails now that Pebble is the default storage engine. Remove the skipped marker. Fixes #35328. Release justification: Roachtest-only change. Release note: None. 53907: geos: bump to include seg fault fix r=sumeerbhola a=otan Resolves #53254. Release justification: bug fix to new functionality Release note: None Co-authored-by: irfan sharif <[email protected]> Co-authored-by: Solon Gordon <[email protected]> Co-authored-by: Bilal Akhtar <[email protected]> Co-authored-by: Oliver Tan <[email protected]>
…on to Polygon Closes #1047 References cockroachdb/cockroach#53254 Signed-off-by: Sandro Santilli <[email protected]>
Backport of patch by Oliver Tan Closes #1047 in 3.8 branch (3.8.2dev) References cockroachdb/cockroach#53254
Issue filed: https://trac.osgeo.org/geos/ticket/1047
GEOS crash:
(sql/distsql).TestAggregatorAgainstProcessor failed on master@7ac3e989c9dbb5c9ff51b4b33e2cee63328a6496:
More
Parameters:
See this test on roachdash
powered by pkg/cmd/internal/issues
The text was updated successfully, but these errors were encountered: