roachtest: Unskip disk-full roachtest #53906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
approved these changes
Sep 3, 2020
petermattis
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
Would storage also be able to own this test? We're trying to move away from having an 8x lead over the runner up team.
Yes, I think storage should own this test. Bilal can you s/OwnerKV/OwnerStorage/g?
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @darinpp)
The disk-full roachtest no longer fails now that Pebble is the default storage engine. Remove the skipped marker. Fixes cockroachdb#35328. Release justification: Roachtest-only change. Release note: None.
itsbilal
force-pushed
the
disk-full-unskip
branch
from
9523a65 to
d51519e
Compare
itsbilal
commented
Sep 3, 2020
There was a problem hiding this comment.
Made the owner change. TFTRs!
Reviewable status:
|
bors r=tbg |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The disk-full roachtest no longer fails now that Pebble is the
default storage engine. Remove the skipped marker.
Fixes #35328.
Release justification: Roachtest-only change.
Release note: None.