opt: v20.1.0-alpha20191216: assertion failed: top-level relational expression cannot have outer columns

[cockroach-teamcity]

This issue was autofiled by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.

Sentry link: https://sentry.io/organizations/cockroach-labs/issues/1495879583/?referrer=webhooks_plugin

Panic message:

*errors.errorString
*safedetails.withSafeDetails: top-level relational expression cannot have outer columns: %s (1)
optimizer.go:218: *withstack.withStack (2)
*assert.withAssertionFailure
(check the extra data payloads)

Stacktrace (expand for inline code snippets):

cockroach/pkg/sql/opt/xform/optimizer.go

Lines 217 to 219 in e9e2a80

	if !root.Relational().OuterCols.Empty() {
	return nil, errors.AssertionFailedf(
	"top-level relational expression cannot have outer columns: %s",

in pkg/sql/opt/xform.(*Optimizer).Optimize

cockroach/pkg/sql/plan_opt.go

Lines 423 to 425 in e9e2a80

	if _, isCanned := opc.p.stmt.AST.(*tree.CannedOptPlan); !isCanned {
	if _, err := opc.optimizer.Optimize(); err != nil {
	return nil, err

in pkg/sql.(*optPlanningCtx).buildExecMemo

cockroach/pkg/sql/plan_opt.go

Lines 161 to 163 in e9e2a80

	execMemo, err := opc.buildExecMemo(ctx)
	if err != nil {

in pkg/sql.(*planner).makeOptimizerPlan

cockroach/pkg/sql/conn_executor_exec.go

Lines 742 to 744 in e9e2a80

	log.VEvent(ctx, 2, "generating optimizer plan")
	if err := planner.makeOptimizerPlan(ctx); err != nil {
	log.VEventf(ctx, 1, "optimizer plan failed: %v", err)

in pkg/sql.(*connExecutor).makeExecPlan

cockroach/pkg/sql/conn_executor_exec.go

Lines 625 to 627 in e9e2a80

	// between here and there needs to happen even if there's an error.
	err := ex.makeExecPlan(ctx, planner)
	// We'll be closing the plan manually below after execution; this

in pkg/sql.(*connExecutor).dispatchToExecutionEngine

cockroach/pkg/sql/conn_executor_exec.go

Lines 416 to 418 in e9e2a80

	p.autoCommit = os.ImplicitTxn.Get() && !ex.server.cfg.TestingKnobs.DisableAutoCommit
	if err := ex.dispatchToExecutionEngine(ctx, p, res); err != nil {
	return nil, nil, err

in pkg/sql.(*connExecutor).execStmtInOpenState

cockroach/pkg/sql/conn_executor_exec.go

Lines 97 to 99 in e9e2a80

	} else {
	ev, payload, err = ex.execStmtInOpenState(ctx, stmt, res, pinfo)
	}

in pkg/sql.(*connExecutor).execStmt

cockroach/pkg/sql/conn_executor.go

Lines 1249 to 1251 in e9e2a80

	stmtCtx := withStatement(ctx, ex.curStmt)
	ev, payload, err = ex.execStmt(stmtCtx, curStmt, stmtRes, nil /* pinfo */)
	if err != nil {

in pkg/sql.(*connExecutor).execCmd

cockroach/pkg/sql/conn_executor.go

Lines 1178 to 1180 in e9e2a80

	var err error
	if err = ex.execCmd(ex.Ctx()); err != nil {
	if err == io.EOF || err == errDrainingComplete {

in pkg/sql.(*connExecutor).run

cockroach/pkg/sql/conn_executor.go

Lines 449 to 451 in e9e2a80

	}()
	return h.ex.run(ctx, s.pool, reserved, cancel)
	}

in pkg/sql.(*Server).ServeConn

cockroach/pkg/sql/pgwire/conn.go

Lines 583 to 585 in e9e2a80

	reservedOwned = false // We're about to pass ownership away.
	retErr = sqlServer.ServeConn(ctx, connHandler, reserved, cancelConn)
	}()

in pkg/sql/pgwire.(*conn).processCommandsAsync.func1
/usr/local/go/src/runtime/asm_amd64.s#L1336-L1338 in runtime.goexit

pkg/sql/opt/xform/optimizer.go in pkg/sql/opt/xform.(*Optimizer).Optimize at line 218
pkg/sql/plan_opt.go in pkg/sql.(*optPlanningCtx).buildExecMemo at line 424
pkg/sql/plan_opt.go in pkg/sql.(*planner).makeOptimizerPlan at line 162
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).makeExecPlan at line 743
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).dispatchToExecutionEngine at line 626
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).execStmtInOpenState at line 417
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).execStmt at line 98
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).execCmd at line 1250
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).run at line 1179
pkg/sql/conn_executor.go in pkg/sql.(*Server).ServeConn at line 450
pkg/sql/pgwire/conn.go in pkg/sql/pgwire.(*conn).processCommandsAsync.func1 at line 584
/usr/local/go/src/runtime/asm_amd64.s in runtime.goexit at line 1337

Tag	Value
Cockroach Release	v20.1.0-alpha20191216
Cockroach SHA:	e9e2a80
Platform	darwin amd64
Distribution	CCL
Environment	v20.1.0-alpha20191216
Command	demo
Go Version	go1.12.12
# of CPUs	8
# of Goroutines	176

[yuzefovich]

The anonymized query is SELECT _, _, _, _, _ FROM (SELECT _ AS _, _, _ - (_ * _) AS _ FROM _) AS _ JOIN LATERAL (SELECT _, sum(_._) AS _ FROM _ WHERE ((_ = _) AND (_._ = _._)) AND (_._ > _)) AS _ ON _.

cc @RaduBerinde @rytaft

[rytaft]

I can reproduce this. With the Movr schema, the following query triggers this error:

SELECT *
  FROM (SELECT 1 AS one, id FROM users) AS u
  JOIN LATERAL (
        SELECT rider_id, sum(one) AS rev FROM rides
       ) AS r ON u.id = rider_id;