ui: Redesign Events section on Metrics page #45668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
koorosh
force-pushed
the
ui-redesign-events-section-on-metrics-page
branch
from
9fb0f58 to
ec3aa8a
Compare
Current change is required to fit date and event message after date format was changed. Before, Events section had two columns and it could not fit full date string in the second column without wrapping to several rows what made it not readable. Now, instead of showing two separate columns, date of event is displayed under event message and both event name and date can occupy entire width of events table. Number of events to show on Metrics page is decreased from 10 to 5. Release note: None Release justification: bug fixes and low-risk updates to new functionality
koorosh
force-pushed
the
ui-redesign-events-section-on-metrics-page
branch
from
ec3aa8a to
aed6fa3
Compare
dhartunian
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @koorosh)
pkg/ui/src/views/cluster/containers/events/events.spec.tsx, line 96 at r1 (raw file):
const provider = makeEvent(e); assert.isTrue(provider.find("div.events__message > span").text().includes("created database")); assert.isTrue(provider.find(ToolTipWrapper).exists());
Tests looks much nicer without all the childAt! 👏
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #45402
Current change is required to fit date and
event message after date format was changed.
Before, Events section had two columns and it
could not fit full date string in the second
column without wrapping to several rows what
made it not readable.
Now, instead of showing two separate columns,
date of event is displayed under event message
and both event name and date can occupy entire
width of events table.
Number of events to show on Metrics page is
decreased from 10 to 5.
Release justification: bug fixes and low-risk updates to new functionality