core: endless "cannot reuse client connection" warnings in log #22951
Assignees
Labels
S-3-ux-surprise
Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.
Milestone
Comments
|
I can consistently reproduce this by starting a node and then turning off my Wi-Fi connection for a few seconds (presumably because my hostname doesn't resolve anymore). The warnings keep coming after I turn Wi-Fi back on. |
knz
added
the
S-3-ux-surprise
bdarnell
added a commit
to bdarnell/cockroach
that referenced
this issue
Mar 1, 2018
Local connections can fail if the machine's network configuration changes (for example, if you turn wifi off on a laptop). We disabled heartbeating of local connections in cockroachdb#16526 to work around a UI issue (in which the UI would fail to recover after a local connection failed). This relied on GRPC's internal reconnections, which were disabled in cockroachdb#22658. This commit re-enables local heartbeats so that our reconnection logic works as usual (In the meantime, the UI has gotten better about error recovery, so cockroachdb#16526 is no longer necessary). Fixes cockroachdb#22951 Release note (bug fix): The admin UI no longer hangs after a node's network configuration has changed.
|
This isn't just log spam - parts of the UI would be broken by this too (at least debug pages - the main UI seems OK). Fix in #23298. |
bdarnell
added a commit
to bdarnell/cockroach
that referenced
this issue
Mar 5, 2018
Local connections can fail if the machine's network configuration changes (for example, if you turn wifi off on a laptop). We disabled heartbeating of local connections in cockroachdb#16526 to work around a UI issue (in which the UI would fail to recover after a local connection failed). This relied on GRPC's internal reconnections, which were disabled in cockroachdb#22658. This commit re-enables local heartbeats so that our reconnection logic works as usual (In the meantime, the UI has gotten better about error recovery, so cockroachdb#16526 is no longer necessary). Fixes cockroachdb#22951 Release note (bug fix): The admin UI no longer hangs after a node's network configuration has changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was running a local single-node cluster and at a certain point it started spitting out this warning once per second and never stopped:
As far as I can tell this didn't affect the functionality of the server. I could still run queries against it with no issues. I'll update with reproduction steps if I can figure out how to make this happen consistently.
Seems related to #22658 (cc @bdarnell).
The text was updated successfully, but these errors were encountered: