rpc: Heartbeat local connections too #23298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local connections can fail if the machine's network configuration changes (for example, if you turn wifi off on a laptop). We disabled heartbeating of local connections in cockroachdb#16526 to work around a UI issue (in which the UI would fail to recover after a local connection failed). This relied on GRPC's internal reconnections, which were disabled in cockroachdb#22658. This commit re-enables local heartbeats so that our reconnection logic works as usual (In the meantime, the UI has gotten better about error recovery, so cockroachdb#16526 is no longer necessary). Fixes cockroachdb#22951 Release note (bug fix): The admin UI no longer hangs after a node's network configuration has changed.
|
This change is |
a-robinson
approved these changes
Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local connections can fail if the machine's network configuration
changes (for example, if you turn wifi off on a laptop). We disabled
heartbeating of local connections in #16526 to work around a UI issue
(in which the UI would fail to recover after a local connection
failed). This relied on GRPC's internal reconnections, which were
disabled in #22658. This commit re-enables local heartbeats so that
our reconnection logic works as usual (In the meantime, the UI has
gotten better about error recovery, so #16526 is no longer necessary).
Fixes #22951
Release note (bug fix): The admin UI no longer hangs after a node's
network configuration has changed.