Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
rpc: Heartbeat local connections too
Local connections can fail if the machine's network configuration changes (for example, if you turn wifi off on a laptop). We disabled heartbeating of local connections in cockroachdb#16526 to work around a UI issue (in which the UI would fail to recover after a local connection failed). This relied on GRPC's internal reconnections, which were disabled in cockroachdb#22658. This commit re-enables local heartbeats so that our reconnection logic works as usual (In the meantime, the UI has gotten better about error recovery, so cockroachdb#16526 is no longer necessary). Fixes cockroachdb#22951 Release note (bug fix): The admin UI no longer hangs after a node's network configuration has changed.
- Loading branch information