kv/kvserver/reports: TestConstraintConformanceReportIntegration failed #108430
Assignees
Labels
A-testing
Testing tools and infrastructure
branch-release-23.1
Used to mark GA and release blockers, technical advisories, and bugs for 23.1
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
T-kv
KV Team
Milestone
Comments
cockroach-teamcity
added
branch-release-23.1
|
This test has a history of flakiness and timing out under stress: #101626. Here, we're running under deadlock, which we'd expect to slow the test down in a similar manner. |
nvanbenschoten
added
C-bug
craig bot
pushed a commit
that referenced
this issue
Aug 10, 2023
107302: storage: add method to ingest external files, rename IngestExternalFiles r=RaduBerinde a=itsbilal Requires cockroachdb/pebble#2753 This change renames the existing IngestExternalFiles method on storage.Engine to IngestLocalFiles, and adds a new IngestExternalFiles that ingests pebble.ExternalFile, for use with online restore. Depends on cockroachdb/pebble#2753. Epic: none Release note: None 108402: serverutils: remove ad-hoc code from StartNewTestCluster r=yuzefovich a=knz This function is a convenience alias for NewTestCluster+Start. This should not contain custom logic specific to certain tests. Any custom logic should be conditional on testing knobs and put inside `(*testcluster.TestCluster).Start()` instead. (The code removed here was mistakenly added in the wrong place in 70f85cd). Release note: None Needed for #107986. Epic: CRDB-18499 108446: kv: skip TestConstraintConformanceReportIntegration under deadlock r=erikgrinaker a=nvanbenschoten Fixes #108430. This commit avoids flakiness in `TestConstraintConformanceReportIntegration` by skipping the test under deadlock builds. It has been observed to run slowly and flake under stress, and we see the same kinds of behavior under deadlock builds. Release notes: None 108451: schemachanger: Refactor tests for concurrent schema changer behaviors r=Xiang-Gu a=Xiang-Gu 1. It cleans up some redundant tests about concurrent schema changer behavior and refactor in a new simpler, cleaner test 2. It adds an integration style test for testing concurrent schema change behaviors where we run many schema changes for an extended period of time and assert that all of they eventually succeed and the descriptors end up in the expected state. Fix #108140 Fix #107223 Epic: None Release note: None 108492: kv: remove errSavepointInvalidAfterTxnRestart r=knz a=nvanbenschoten This commit simplifies logic in `checkSavepointLocked`. Epic: None Release note: None 108497: sql: don't start default test tenant in MT admin function tests r=yuzefovich a=yuzefovich These tests themselves start multiple tenants, so there is no need to create a default test tenant (doing that also makes it a bit more confusing because the default tenant as well as the first test tenant share the same TenantID effectively making it two SQL pod config, which is confusing). Starting the default test tenant was enabled recently in c899661 when we enabled the CCL license, and we have seen at least one confusing failure that is possibly related to this. Starting the default test tenant was originally added in cfa4375, but I don't see a good reason for it. This PR is opportunistic fix of #108081. Fixes: #108081. Release note: None 108502: kvstreamer: add more assertions to RequestsProvider.enqueue r=yuzefovich a=michae2 If we ever enqueue zero-length requests, it could cause a deadlock where the `workerCoordinator` is waiting for more requests and the enqueuer is waiting for results. Add assertions that we never do this. Informs: #101823 Release note: None 108517: roachtest: pin liveness lease to live node in lease prefs test r=erikgrinaker a=kvoli The lease preferences roachtest could occasionally fail, if the liveness leaseholder were on a stopped node. We should address this issue, for now, pin the liveness lease to a live node to prevent flakes. Informs: #108512 Resolves: #108425 Release note: None Co-authored-by: Bilal Akhtar <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]> Co-authored-by: Nathan VanBenschoten <[email protected]> Co-authored-by: Xiang Gu <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Michael Erickson <[email protected]> Co-authored-by: Austen McClernon <[email protected]>
blathers-crl bot
pushed a commit
that referenced
this issue
Aug 10, 2023
Fixes #108430. This commit avoids flakiness in `TestConstraintConformanceReportIntegration` by skipping the test under deadlock builds. It has been observed to run slowly and flake under stress, and we see the same kinds of behavior under deadlock builds. Release notes: None
blathers-crl bot
pushed a commit
that referenced
this issue
Aug 10, 2023
Fixes #108430. This commit avoids flakiness in `TestConstraintConformanceReportIntegration` by skipping the test under deadlock builds. It has been observed to run slowly and flake under stress, and we see the same kinds of behavior under deadlock builds. Release notes: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kv/kvserver/reports.TestConstraintConformanceReportIntegration failed with artifacts on release-23.1 @ daeaec2e81733e9f26205d7bab04f819778d895b:
Parameters:
TAGS=bazel,gss,deadlockHelp
See also: How To Investigate a Go Test Failure (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-30467
The text was updated successfully, but these errors were encountered: