Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: pin liveness lease to live node in lease prefs test #108517

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

kvoli
Copy link
Collaborator

@kvoli kvoli commented Aug 10, 2023

The lease preferences roachtest could occasionally fail, if the liveness leaseholder were on a stopped node. We should address this issue, for now, pin the liveness lease to a live node to prevent flakes.

Informs: #108512
Resolves: #108425
Release note: None

The lease preferences roachtest could occasionally fail, if the liveness
leaseholder were on a stopped node. We should address this issue,
for now, pin the liveness lease to a live node to prevent flakes.

Informs: cockroachdb#108512
Resolves: cockroachdb#108425
Release note: None
@kvoli kvoli requested a review from a team as a code owner August 10, 2023 14:58
@kvoli kvoli requested review from rachitgsrivastava and DarrylWong and removed request for a team August 10, 2023 14:58
@kvoli kvoli self-assigned this Aug 10, 2023
@kvoli kvoli added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Aug 10, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kvoli kvoli requested review from erikgrinaker and a team August 10, 2023 14:58
@kvoli
Copy link
Collaborator Author

kvoli commented Aug 10, 2023

Tyftr!

Bors r=erikgrinaker

@kvoli
Copy link
Collaborator Author

kvoli commented Aug 10, 2023

bors r-

@kvoli
Copy link
Collaborator Author

kvoli commented Aug 10, 2023

bors r=erikgrinaker

@craig
Copy link
Contributor

craig bot commented Aug 10, 2023

Canceled.

@craig
Copy link
Contributor

craig bot commented Aug 10, 2023

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Aug 10, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-23.1-108517 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/108544/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@kvoli
Copy link
Collaborator Author

kvoli commented Aug 21, 2023

blathers backport release-23.1.9-rc

@blathers-crl
Copy link

blathers-crl bot commented Aug 21, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-23.1.9-rc-108517 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/109129/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch release-23.1.9-rc failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: lease-preferences/full-first-preference-down failed
3 participants