Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1.9-rc: roachtest: pin liveness lease to live node in lease prefs test #109129

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Aug 21, 2023

Backport 1/1 commits from #108517 on behalf of @kvoli.

/cc @cockroachdb/release


The lease preferences roachtest could occasionally fail, if the liveness leaseholder were on a stopped node. We should address this issue, for now, pin the liveness lease to a live node to prevent flakes.

Informs: #108512
Resolves: #108425
Release note: None


Resolves: #109071
Release justification: Test only changes.

The lease preferences roachtest could occasionally fail, if the liveness
leaseholder were on a stopped node. We should address this issue,
for now, pin the liveness lease to a live node to prevent flakes.

Informs: #108512
Resolves: #108425
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner August 21, 2023 13:54
@blathers-crl blathers-crl bot removed the request for review from a team August 21, 2023 13:54
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1.9-rc-108517 branch from a0eff47 to 0a12007 Compare August 21, 2023 13:54
@blathers-crl blathers-crl bot requested review from smg260 and renatolabs August 21, 2023 13:54
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Aug 21, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1.9-rc-108517 branch from 54b94fa to dd72c4a Compare August 21, 2023 13:54
@blathers-crl
Copy link
Author

blathers-crl bot commented Aug 21, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kvoli
Copy link
Collaborator

kvoli commented Aug 21, 2023

See #109071 (comment).

@kvoli kvoli merged commit 343fef8 into release-23.1.9-rc Aug 21, 2023
@kvoli kvoli deleted the blathers/backport-release-23.1.9-rc-108517 branch August 21, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants