Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: remove errSavepointInvalidAfterTxnRestart #108492

Merged

Conversation

nvanbenschoten
Copy link
Member

This commit simplifies logic in checkSavepointLocked.

Epic: None
Release note: None

This commit simplifies logic in `checkSavepointLocked`.

Epic: None
Release note: None
@blathers-crl
Copy link

blathers-crl bot commented Aug 9, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten nvanbenschoten requested a review from knz August 10, 2023 02:10
@nvanbenschoten nvanbenschoten marked this pull request as ready for review August 10, 2023 02:10
@nvanbenschoten nvanbenschoten requested a review from a team as a code owner August 10, 2023 02:10
@nvanbenschoten
Copy link
Member Author

TFTR!

bors r=knz

@craig
Copy link
Contributor

craig bot commented Aug 10, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Aug 10, 2023

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Aug 10, 2023

Build succeeded:

@craig craig bot merged commit f194f92 into cockroachdb:master Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants