-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
storage: fix possible raft log panic after fsync error
Detected with #36989 applied by running `./bin/roachtest run --local '^system-crash/sync-errors=true$'`. With some slight modification to that test's constants it could repro errors like this within a minute: ``` panic: tocommit(375) is out of range [lastIndex(374)]. Was the raft log corrupted, truncated, or lost? ``` Debugging showed `DBSyncWAL` can be called even after a sync failure. I guess if it returns success any time after it fails it will ack writes that aren't recoverable in WAL. They aren't recoverable because RocksDB stops recovery upon hitting the offset corresponding to the lost write (typically there should be a corruption there). Meanwhile, there are still successfully synced writes at later offsets in the file. The fix is simple. If `DBSyncWAL` returns an error once, keep track of that error and return it for all future writes. Release note: None
- v25.1.0-alpha.3
- v25.1.0-alpha.2
- v25.1.0-alpha.1
- v24.3.3
- v24.3.2
- v24.3.1
- v24.3.0
- v24.3.0-rc.1
- v24.3.0-beta.3
- v24.3.0-beta.2
- v24.3.0-beta.1
- v24.3.0-alpha.2
- v24.3.0-alpha.1
- v24.2.8
- v24.2.7
- v24.2.6
- v24.2.5
- v24.2.4
- v24.2.3
- v24.2.2
- v24.2.1
- v24.2.0
- v24.2.0-rc.1
- v24.2.0-beta.3
- v24.2.0-beta.2
- v24.2.0-beta.1
- v24.2.0-alpha.2
- v24.2.0-alpha.1
- v24.1.10
- v24.1.9
- v24.1.8
- v24.1.7
- v24.1.6
- v24.1.5
- v24.1.4
- v24.1.3
- v24.1.2
- v24.1.1
- v24.1.0
- v24.1.0-rc.2
- v24.1.0-rc.1
- v24.1.0-beta.3
- v24.1.0-beta.2
- v24.1.0-beta.1
- v24.1.0-alpha.5
- v24.1.0-alpha.4
- v24.1.0-alpha.3
- v24.1.0-alpha.2
- v24.1.0-alpha.1
- v23.2.19
- v23.2.18
- v23.2.17
- v23.2.16
- v23.2.15
- v23.2.14
- v23.2.13
- v23.2.12
- v23.2.11
- v23.2.10
- v23.2.9
- v23.2.8
- v23.2.7
- v23.2.6
- v23.2.5
- v23.2.4
- v23.2.3
- v23.2.2
- v23.2.1
- v23.2.0
- v23.2.0-rc.2
- v23.2.0-rc.1
- v23.2.0-beta.3
- v23.2.0-beta.2
- v23.2.0-beta.1
- v23.2.0-alpha.7
- v23.2.0-alpha.6
- v23.2.0-alpha.5
- v23.2.0-alpha.4
- v23.2.0-alpha.3
- v23.2.0-alpha.2
- v23.2.0-alpha.1
- v23.2.0-alpha.00000000
- v23.1.30
- v23.1.29
- v23.1.28
- v23.1.27
- v23.1.26
- v23.1.25
- v23.1.24
- v23.1.23
- v23.1.22
- v23.1.21
- v23.1.20
- v23.1.19
- v23.1.18
- v23.1.17
- v23.1.16
- v23.1.15
- v23.1.14
- v23.1.13
- v23.1.12
- v23.1.11
- v23.1.10
- v23.1.9
- v23.1.8
- v23.1.7
- v23.1.6
- v23.1.5
- v23.1.4
- v23.1.3
- v23.1.2
- v23.1.1
- v23.1.0
- v23.1.0-rc.2
- v23.1.0-rc.1
- v23.1.0-beta.3
- v23.1.0-beta.2
- v23.1.0-beta.1
- v23.1.0-alpha.9
- v23.1.0-alpha.8
- v23.1.0-alpha.7
- v23.1.0-alpha.6
- v23.1.0-alpha.5
- v23.1.0-alpha.4
- v23.1.0-alpha.3
- v23.1.0-alpha.2
- v23.1.0-alpha.1
- v23.1.0-alpha.00000000
- v22.2.19
- v22.2.18
- v22.2.17
- v22.2.16
- v22.2.15
- v22.2.14
- v22.2.13
- v22.2.12
- v22.2.11
- v22.2.10
- v22.2.9
- v22.2.8
- v22.2.7
- v22.2.6
- v22.2.5
- v22.2.4
- v22.2.3
- v22.2.2
- v22.2.1
- v22.2.0
- v22.2.0-rc.3
- v22.2.0-rc.2
- v22.2.0-rc.1
- v22.2.0-beta.5
- v22.2.0-beta.4
- v22.2.0-beta.3
- v22.2.0-beta.2
- v22.2.0-beta.1
- v22.2.0-alpha.4
- v22.2.0-alpha.3
- v22.2.0-alpha.2
- v22.2.0-alpha.1
- v22.2.0-alpha.00000000
- v22.1.22
- v22.1.21
- v22.1.20
- v22.1.19
- v22.1.18
- v22.1.17
- v22.1.16
- v22.1.15
- v22.1.14
- v22.1.13
- v22.1.12
- v22.1.11
- v22.1.10
- v22.1.9
- v22.1.8
- v22.1.7
- v22.1.6
- v22.1.5
- v22.1.4
- v22.1.3
- v22.1.2
- v22.1.1
- v22.1.0
- v22.1.0-rc.1
- v22.1.0-beta.5
- v22.1.0-beta.4
- v22.1.0-beta.3
- v22.1.0-beta.2
- v22.1.0-beta.1
- v22.1.0-alpha.5
- v22.1.0-alpha.4
- v22.1.0-alpha.3
- v22.1.0-alpha.2
- v22.1.0-alpha.1
- v22.1.0-alpha.00000000
- v21.2.17
- v21.2.16
- v21.2.15
- v21.2.14
- v21.2.13
- v21.2.12
- v21.2.11
- v21.2.10
- v21.2.9
- v21.2.8
- v21.2.7
- v21.2.6
- v21.2.5
- v21.2.4
- v21.2.3
- v21.2.2
- v21.2.1
- v21.2.0
- v21.2.0-rc.3
- v21.2.0-rc.2
- v21.2.0-rc.1
- v21.2.0-beta.4
- v21.2.0-beta.3
- v21.2.0-beta.2
- v21.2.0-beta.1
- v21.2.0-alpha.00000000
- v21.1.21
- v21.1.20
- v21.1.19
- v21.1.18
- v21.1.17
- v21.1.16
- v21.1.15
- v21.1.14
- v21.1.13
- v21.1.12
- v21.1.11
- v21.1.10
- v21.1.9
- v21.1.8
- v21.1.7
- v21.1.6
- v21.1.5
- v21.1.4
- v21.1.3
- v21.1.2
- v21.1.1
- v21.1.0
- v21.1.0-rc.3
- v21.1.0-rc.2
- v21.1.0-rc.1
- v21.1.0-beta.5
- v21.1.0-beta.4
- v21.1.0-beta.3
- v21.1.0-beta.2
- v21.1.0-beta.1
- v21.1.0-alpha.3
- v21.1.0-alpha.2
- v21.1.0-alpha.1
- v21.1.0-alpha.00000000
- v20.2.19
- v20.2.18
- v20.2.17
- v20.2.16
- v20.2.15
- v20.2.14
- v20.2.13
- v20.2.12
- v20.2.11
- v20.2.10
- v20.2.9
- v20.2.8
- v20.2.7
- v20.2.6
- v20.2.5
- v20.2.4
- v20.2.3
- v20.2.2
- v20.2.1
- v20.2.0
- v20.2.0-rc.4
- v20.2.0-rc.3
- v20.2.0-rc.2
- v20.2.0-rc.1
- v20.2.0-beta.4
- v20.2.0-beta.3
- v20.2.0-beta.2
- v20.2.0-beta.1
- v20.2.0-alpha.3
- v20.2.0-alpha.2
- v20.2.0-alpha.1
- v20.2.0-alpha.00000000
- v20.1.17
- v20.1.16
- v20.1.15
- v20.1.14
- v20.1.13
- v20.1.12
- v20.1.11
- v20.1.10
- v20.1.9
- v20.1.8
- v20.1.7
- v20.1.6
- v20.1.5
- v20.1.4
- v20.1.4-sjdebug
- v20.1.3
- v20.1.3-fix-52147
- v20.1.2
- v20.1.1
- v20.1.0
- v20.1.0-rc.2
- v20.1.0-rc.1
- v20.1.0-beta.4
- v20.1.0-beta.3
- v20.1.0-beta.2
- v20.1.0-beta.1
- v20.1.0-alpha.20200123
- v20.1.0-alpha20191216
- v20.1.0-alpha.20191118
- v20.1.0-alpha.00000000
- v19.2.12
- v19.2.11
- v19.2.10
- v19.2.9
- v19.2.8
- v19.2.7
- v19.2.6
- v19.2.5
- v19.2.5-alpha-one-off
- v19.2.4
- v19.2.4-gctwooff
- v19.2.4-gconeoff
- v19.2.3
- v19.2.2
- v19.2.1
- v19.2.1-rc.1
- v19.2.0
- v19.2.0-rc.4
- v19.2.0-rc.3
- v19.2.0-rc.2
- v19.2.0-rc.1
- v19.2.0-beta.20191014
- v19.2.0-beta.20190930
- v19.2.0-alpha.20190805
- v19.2.0-alpha.20190701
- v19.2.0-alpha.20190606
- staging-202011251758-v20.2.3
- staging-202011251240-v20.2.1.2
- staging-202011191818-v20.2.1.1
- provisional_202008241633_v20.1.5
- provisional_202008191705_v19.2.10
- provisional_202008172236_v20.1.4-sjdebug
- provisional_202008151325_v19.2.10
- provisional_202003161814_v19.2.5
- provisional_202003112118_v20.1.0-beta.3
- provisional_202002271730_v19.2.4-gctwooff
- provisional_202002261607_v19.2.4-gconeoff
- provisional_202002240854_v20.1.0-beta.2
- provisional_202002062122_v19.2.4
- provisional_202002031955_v20.1.0-alpha.20200210
- jordan-test-tag
- custombuild-v24.1.0-alpha.5-1783-g6cde73f5565
- custombuild-v23.2.0-beta.1-141-g70534bf5bd9
- custombuild-v23.2.0-alpha.00000000-4376-g7450647f213
- custombuild-v23.1.11-2-g0a86e8d93a3
- custombuild-v23.1.10-1-g9f0930f7150
- custombuild-v23.1.8-2-gc2fa404f725
- custombuild-v23.1.7-1-ge4d6e3f1adc
- custombuild-v23.1.6-1-gb8bf8ce8e04
- custombuild-v23.1.5-6-g043a4eb9664
- custombuild-v23.1.5-5-ge84875fa68d
- custombuild-v23.1.5-5-gb36479935f3
- custombuild-v23.1.4-5-ga869ea066bb
- custombuild-v23.1.4-2-gf961c7b36b6
- custombuild-v23.1.2-1-gef8d5da59d2
- custombuild-v23.1.0-alpha.7-4119-gbe818271364
- custombuild-v23.1.0-alpha.7-4119-ga14279bebcb
- custombuild-v23.1.0-alpha.7-4069-g060c223479f
- custombuild-v23.1.0-alpha.7-4057-g415b8d77332
- custombuild-v23.1.0-alpha.7-4055-g99d5a5cbe2c
- custombuild-v23.1.0-alpha.7-4055-g9afa166e8a4
- custombuild-v23.1.0-alpha.7-2220-gadb04746e6a
- custombuild-v23.1.0-alpha.7-1375-g8ce5786d0d8
- custombuild-v23.1.0-alpha.7-448-g7e5dadfb93d
- custombuild-v23.1.0-alpha.7-329-g0a280af5c55
- custombuild-v23.1.0-alpha.7-326-g8a9b0614758
- custombuild-v23.1.0-alpha.7-301-gf174c033701
- custombuild-v23.1.0-alpha.7-301-gabbb5259982
- custombuild-v23.1.0-alpha.7-301-g5f505893f21
- custombuild-v23.1.0-alpha.7-301-g0d357a94542
- custombuild-v23.1.0-alpha.7-290-g502faaf8d67
- custombuild-v23.1.0-alpha.5-175-gbc00587da20
- custombuild-v23.1.0-alpha.2-383-gdce6e2ed1d
- custombuild-v23.1.0-alpha.2-383-g28ef8d3b59
- custombuild-v23.1.0-alpha.2-250-g75835dc150
- custombuild-v23.1.0-alpha.2-244-gc5def5e25b
- custombuild-v23.1.0-alpha.2-244-g381b002303
- custombuild-v23.1.0-alpha.2-244-g86ab24b666
- custombuild-v23.1.0-alpha.1-1644-g6eee17c6be
- custombuild-v23.1.0-alpha.1-1641-g19d1e87cc3
- custombuild-v23.1.0-alpha.1-1420-g384443c763
- custombuild-v23.1.0-alpha.1-1420-g8255d8e45d
- custombuild-v23.1.0-alpha.1-1420-g30c969e7d9
- custombuild-v23.1.0-alpha.1-1342-ga1b3831ac6
- custombuild-v23.1.0-alpha.1-1304-gf1c37b4132
- custombuild-v23.1.0-alpha.1-1304-g70b3137f93
- custombuild-v23.1.0-alpha.1-1304-g9a987010d0
- custombuild-v23.1.0-alpha.1-960-gd14e0d926c
- custombuild-v23.1.0-alpha.1-581-gfc0e12323c
- custombuild-v23.1.0-alpha.1-581-gba36a32899
- custombuild-v23.1.0-alpha.1-573-gc69140db75
- custombuild-v23.1.0-alpha.1-327-gd3e27f0636d
- custombuild-v23.1.0-alpha.1-327-g29c1a165d2e
- custombuild-v22.2.12-1-gfb443de61b5
- custombuild-v22.2.11-246-gd1d35d7335d
- custombuild-v22.2.10-183-gfb71787d22d
- custombuild-v22.2.5-1-ge2315888bbb
- custombuild-v22.2.5-1-g0e92cb1e2f4
- custombuild-v22.2.0-beta.5-59-g3a8bf9fd51f
- custombuild-v22.2.0-alpha.3-1315-ge956611336
- custombuild-v22.2.0-alpha.3-1315-gc941dfa066
- custombuild-v22.2.0-alpha.3-1315-g96a1c6a3ef
- custombuild-v22.2.0-alpha.3-1315-g94fe24a5b0
- custombuild-v22.2.0-alpha.3-1315-g24e8baa987
- custombuild-v22.2.0-alpha.3-1315-g2eb734daf2
- custombuild-v22.2.0-alpha.3-1074-g3d64ee63e5
- custombuild-v22.2.0-alpha.3-1000-gbdbe1707eb0
- custombuild-v22.2.0-alpha.3-1000-g4f525537322
- custombuild-v22.1.21-9-g05f6d1e8d7e
- custombuild-v22.1.18-1-gfc8b1418e9f
- custombuild-v22.1.15-33-gfe6434d01c6
- custombuild-v22.1.15-1-g27753ce1c3a
- custombuild-v22.1.15-1-g4b6691c2c7f
- custombuild-v22.1.11-1-gb8e2441b23e
- custombuild-v22.1.11-1-g2053874982c
- custombuild-v22.1.10
- custombuild-v22.1.9-77-gbfe7b14fa0
- custombuild-v22.1.8-130-g5dccc5b4db
- custombuild-v22.1.6-19-g31b959b8f8
- custombuild-v22.1.6-1-g261f5ea08b
- custombuild-v22.1.5-185-gb5d145ed60
- custombuild-v21.2.17
- custombuild-v21.2.8-2-gf8c1f60489
- custombuild-v21.1.21
- custombuild-v20.2.5-17-g306506e6d1
- custombuild-v20.2.1-9-gb9288616fe
- custombuild-v20.1.8-5-ge74a6ef4f8
- custombuild-v20.1.8-4-g278af794c1
- custombuild-v20.1.8-2-g8b08e9aaa1
- custombuild-v20.1.6-2-gf11a64ee5e
- custombuild-v20.1.6-1-g63f61aa24e
- custombuild-v20.1.6-1-g4c76a0a628
- custombuild-v20.1.5-2-gea13c91546
- custombuild-v20.1.5-1-gbb44e2883c
- custombuild-v20.1.3-2-gf91e37ff54
- custombuild-v20.1.3-2-g4282e5304d
- custombuild-v20.1.3-1-g56c1f2e5d3
- @cockroacklabs/cluster-ui@22.2.0-prerelease-3
- @cockroacklabs/cluster-ui@22.2.0-prerelease-2
- @cockroacklabs/cluster-ui@22.2.0-prelease-1
- @cockroacklabs/cluster-ui@22.1.4
- @cockroacklabs/cluster-ui@22.1.3
- @cockroacklabs/cluster-ui@22.1.2
- @cockroacklabs/cluster-ui@22.1.1
- @cockroacklabs/cluster-ui@22.1.0
- @cockroacklabs/cluster-ui@22.1.0-prerelease-5
- @cockroacklabs/cluster-ui@22.1.0-prerelease-4
- @cockroacklabs/cluster-ui@21.2.7
- @cockroacklabs/cluster-ui@21.2.6
- @cockroacklabs/cluster-ui@21.2.5
- @cockroacklabs/cluster-ui@21.2.4
- @cockroacklabs/cluster-ui@21.2.3
- @cockroacklabs/cluster-ui@21.2.2
- @cockroachlabs/clusterui@20.2.1
- @cockroachlabs/cluster-ui@24.3.5
- @cockroachlabs/cluster-ui@24.3.4
- @cockroachlabs/cluster-ui@24.3.3
- @cockroachlabs/cluster-ui@24.3.2
- @cockroachlabs/cluster-ui@24.3.1
- @cockroachlabs/cluster-ui@24.3.0-prerelease.4
- @cockroachlabs/cluster-ui@24.3.0-prerelease.3
- @cockroachlabs/cluster-ui@24.3.0-prerelease.2
- @cockroachlabs/cluster-ui@24.3.0-prerelease.1
- @cockroachlabs/cluster-ui@24.3.0-prerelease.0
- @cockroachlabs/cluster-ui@24.2.2
- @cockroachlabs/cluster-ui@24.2.1
- @cockroachlabs/cluster-ui@24.2.0
- @cockroachlabs/cluster-ui@24.1.4
- @cockroachlabs/cluster-ui@24.1.3
- @cockroachlabs/cluster-ui@24.1.2
- @cockroachlabs/cluster-ui@24.1.1
- @cockroachlabs/cluster-ui@24.1.0-prerelease.0
- @cockroachlabs/cluster-ui@23.2.10
- @cockroachlabs/cluster-ui@23.2.9
- @cockroachlabs/cluster-ui@23.2.8
- @cockroachlabs/cluster-ui@23.2.7
- @cockroachlabs/cluster-ui@23.2.6
- @cockroachlabs/cluster-ui@23.2.5
- @cockroachlabs/cluster-ui@23.2.4
- @cockroachlabs/cluster-ui@23.2.3
- @cockroachlabs/cluster-ui@23.2.2
- @cockroachlabs/cluster-ui@23.2.1
- @cockroachlabs/cluster-ui@23.2.0-prerelease.1
- @cockroachlabs/cluster-ui@23.1.16
- @cockroachlabs/cluster-ui@23.1.15
- @cockroachlabs/cluster-ui@23.1.14
- @cockroachlabs/cluster-ui@23.1.13
- @cockroachlabs/cluster-ui@23.1.12
- @cockroachlabs/cluster-ui@23.1.11
- @cockroachlabs/cluster-ui@23.1.10
- @cockroachlabs/cluster-ui@23.1.9
- @cockroachlabs/cluster-ui@23.1.8
- @cockroachlabs/cluster-ui@23.1.7
- @cockroachlabs/cluster-ui@23.1.6
- @cockroachlabs/cluster-ui@23.1.5
- @cockroachlabs/cluster-ui@23.1.4
- @cockroachlabs/cluster-ui@23.1.3
- @cockroachlabs/cluster-ui@23.1.2
- @cockroachlabs/cluster-ui@23.1.1
- @cockroachlabs/cluster-ui@23.1.0-publishtest.0
- @cockroachlabs/cluster-ui@23.1.0-prerelease.6
- @cockroachlabs/cluster-ui@23.1.0-prerelease.5
- @cockroachlabs/cluster-ui@23.1.0-prerelease.3
- @cockroachlabs/cluster-ui@23.1.0-prerelease.2
- @cockroachlabs/cluster-ui@23.1.0-prerelease.1
- @cockroachlabs/cluster-ui@23.1.0-prerelease.0
- @cockroachlabs/cluster-ui@22.2.13
- @cockroachlabs/cluster-ui@22.2.12
- @cockroachlabs/cluster-ui@22.2.11
- @cockroachlabs/cluster-ui@22.2.10
- @cockroachlabs/cluster-ui@22.2.9
- @cockroachlabs/cluster-ui@22.2.8
- @cockroachlabs/cluster-ui@22.2.7
- @cockroachlabs/cluster-ui@22.2.6
- @cockroachlabs/cluster-ui@22.2.5
- @cockroachlabs/cluster-ui@22.2.4
- @cockroachlabs/cluster-ui@22.2.3
- @cockroachlabs/cluster-ui@22.2.2
- @cockroachlabs/cluster-ui@22.2.1-publishtest.0
- @cockroachlabs/cluster-ui@22.2.0
- @cockroachlabs/cluster-ui@22.2.0-prerelease-8
- @cockroachlabs/cluster-ui@22.2.0-prerelease-7
- @cockroachlabs/cluster-ui@22.2.0-prerelease-6
- @cockroachlabs/cluster-ui@22.2.0-prerelease-5
- @cockroachlabs/cluster-ui@22.1.14
- @cockroachlabs/cluster-ui@22.1.13
- @cockroachlabs/cluster-ui@22.1.12
- @cockroachlabs/cluster-ui@22.1.12-publishtest.2
- @cockroachlabs/cluster-ui@22.1.11
- @cockroachlabs/cluster-ui@22.1.10
- @cockroachlabs/cluster-ui@22.1.9
- @cockroachlabs/cluster-ui@22.1.8
- @cockroachlabs/cluster-ui@22.1.7
- @cockroachlabs/cluster-ui@22.1.6
- @cockroachlabs/cluster-ui@22.1.0-prerelease-3
- @cockroachlabs/cluster-ui@22.1.0-prerelease-2
- @cockroachlabs/cluster-ui@21.2.8
- @cockroachlabs/cluster-ui@21.2.3
- @cockroachlabs/cluster-ui@21.2.2
- @cockroachlabs/cluster-ui@21.2.1
- @cockroachlabs/cluster-ui@21.2.0-prerelease-1
- @cockroachlabs/cluster-ui@21.1.2
- @cockroachlabs/cluster-ui@21.1.1
- @cockroachlabs/cluster-ui@21.1.0
- @cockroachlabs/cluster-ui@20.2.2
- @cockroachlabs/cluster-ui@20.2.0
- @cockroachlabs/cluster@23.1.3
- @cockroachlabs/cluster@22.2.0-prerelease-4
- @cockroachlabs/cluster@21.2.0-prerelease-3
- @cockroachlabs/cluster@21.2.0-prerelease-2
Showing
1 changed file
with
9 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters