feat: add @koishijs and koishi, schemastery #328
Conversation
WalkthroughThe pull request updates the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
package.json(2 hunks)
🧰 Additional context used
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 20)
package.json
[failure] 267-267:
Expected array values to be in ascending order. '@koishijs' should be before '@zxcvbn-ts'
[failure] 18747-18747:
Expected object keys to be in ascending order. 'koishi' should be before 'zy-count-up'
[failure] 18753-18753:
Expected object keys to be in ascending order. 'cosmokit' should be before 'schemastery'
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
package.json(4 hunks)
🧰 Additional context used
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 20)
package.json
[failure] 15123-15123:
Expected object keys to be in ascending order. 'schemastery' should be before 'scorpio-menu'
🔇 Additional comments (1)
package.json (1)
131-131: 🛠️ Refactor suggestion
Fix scope array sorting order.
The newly added scope @koishijs should be alphabetically sorted in the allowScopes array.
Apply this diff to fix the sorting:
"@jx3box",
"@kne",
"@kne-components",
+ "@koishijs",
"@latticexyz",
"@lerna",
"@lincy",
- "@koishijs"Likely invalid or redundant comment.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
package.json(4 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
package.json
[error] 15128-15129: The key scp2 was already declared.
This where a duplicated key was declared again.
If a key is defined multiple times, only the last definition takes effect. Previous definitions are ignored.
(lint/suspicious/noDuplicateObjectKeys)
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 20)
package.json
[failure] 15123-15123:
Duplicate key 'scorpio-menu'
[failure] 15129-15129:
Expected object keys to be in ascending order. 'schemastery' should be before 'scp2'
🔇 Additional comments (1)
package.json (1)
131-131: LGTM!
The new scope @koishijs is properly placed in alphabetical order.
| "koishi": { | ||
| "version": "*" | ||
| }, |
There was a problem hiding this comment.
Fix duplicate entries and sorting order.
There are a few issues in the package.json file:
-
Duplicate entries found:
scorpio-menuappears twicescp2appears twice
-
The keys are not in alphabetical order. The packages should be sorted as:
"scorpio-menu" "schemastery" "scp2"
Apply this diff to fix the issues:
"scorpio-menu": {
"version": "*"
},
- "schemastery": {
- "version": "*"
- },
- "scp2": {
- "version": "*"
- },
+ "schemastery": {
+ "version": "*"
+ },
+ "scp2": {
+ "version": "*"
+ },Also applies to: 15123-15131
CyanChanges
changed the title
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
package.json(4 hunks)
🧰 Additional context used
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 20)
package.json
[failure] 15126-15126:
Expected object keys to be in ascending order. 'schemastery' should be before 'scp2'
[failure] 15129-15129:
Duplicate key 'scp2'
🔇 Additional comments (2)
package.json (2)
131-131: LGTM! New scope added.
The addition of @koishijs scope to the allowScopes array looks good.
8973-8975: LGTM! New package added.
The addition of koishi package with wildcard version looks good.
| "cosmokit": { | ||
| "version": "*" | ||
| }, |
There was a problem hiding this comment.
Fix duplicate entries and sorting order.
There are a few issues in the allowPackages object:
- Duplicate entry for 'scp2'
- Incorrect sorting order - 'schemastery' should be before 'scp2'
Apply this diff to fix the issues:
"cosmokit": {
"version": "*"
},
- "schemastery": {
- "version": "*"
- },
- "scp2": {
- "version": "*"
- },
+ "schemastery": {
+ "version": "*"
+ },
+ "scp2": {
+ "version": "*"
+ },Also applies to: 15126-15131
|
CI fail, need to fix it before merge |
Summary by CodeRabbit
@koishijsscope, allowing for the inclusion of related packages.koishi,schemastery, andscp2.