Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @koishijs and koishi, schemastery #328

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: add @koishijs and koishi, schemastery #328

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26fed8c
Update package.json
CyanChanges Dec 10, 2024
0d88693
order
CyanChanges Dec 10, 2024
2f7d0b3
Update package.json
CyanChanges Dec 10, 2024
1034231
Update package.json
CyanChanges Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@
"@kne",
"@kne-components",
"@koa",
"@koishijs",
"@latticexyz",
"@lerna",
"@lincy",
Expand Down Expand Up @@ -443,7 +444,10 @@
"@commander-js/extra-typings": {
"version": "*"
},
"cosmokit": {
"version": "*"
},
Comment on lines +447 to +449
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix duplicate entries and sorting order.

There are a few issues in the allowPackages object:

  1. Duplicate entry for 'scp2'
  2. Incorrect sorting order - 'schemastery' should be before 'scp2'

Apply this diff to fix the issues:

    "cosmokit": {
      "version": "*"
    },
-   "schemastery": {
-     "version": "*"
-   },
-   "scp2": {
-     "version": "*"
-   },
+   "schemastery": {
+     "version": "*"
+   },
+   "scp2": {
+     "version": "*"
+   },

Also applies to: 15126-15131

"@cspell/eslint-plugin": {

Check failure on line 450 in package.json

View workflow job for this annotation

GitHub Actions / Node.js / Test (ubuntu-latest, 20) 

Expected object keys to be in ascending order. '@cspell/eslint-plugin' should be before 'cosmokit'
"version": "*"
},
"@ctrl/tinycolor": {
Expand Down Expand Up @@ -8966,6 +8970,9 @@
"koa2-ratelimit": {
"version": "*"
},
"koishi": {
"version": "*"
},
Comment on lines +8973 to +8975
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix duplicate entries and sorting order.

There are a few issues in the package.json file:

  1. Duplicate entries found:

    • scorpio-menu appears twice
    • scp2 appears twice

  2. The keys are not in alphabetical order. The packages should be sorted as:

    "scorpio-menu"
"schemastery" 
"scp2"

Apply this diff to fix the issues:

    "scorpio-menu": {
      "version": "*"
    },
-   "schemastery": {
-     "version": "*"
-   },
-   "scp2": {
-     "version": "*"
-   },
+   "schemastery": {
+     "version": "*"
+   },
+   "scp2": {
+     "version": "*"
+   },

Also applies to: 15123-15131

"kolorist": {
"version": "*"
},
Expand Down Expand Up @@ -15116,6 +15123,12 @@
"scp2": {
"version": "*"
},
"schemastery": {

Check failure on line 15126 in package.json

View workflow job for this annotation

GitHub Actions / Node.js / Test (ubuntu-latest, 20) 

Expected object keys to be in ascending order. 'schemastery' should be before 'scp2'
"version": "*"
},
CyanChanges marked this conversation as resolved.
Show resolved Hide resolved
"scp2": {

Check failure on line 15129 in package.json

View workflow job for this annotation

GitHub Actions / Node.js / Test (ubuntu-latest, 20) 

Duplicate key 'scp2'
"version": "*"
},
"screenfull": {
"version": "*"
},
Expand Down
Loading