-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move GsfTrack dicts in to GsfTrackReco from EgammaCandidates #44884
Conversation
cms-bot internal usage |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44884/40145
|
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c26ac/39202/summary.html Comparison SummarySummary:
|
@cms-sw/reconstruction-l2 , can you please review this? this should fix the wrong dict definitions |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This should fix the
GsfTrack
dictionary definition (see #43871 (review) ) in wrong package issue (https://cmssdt.cern.ch/SDT/cgi-bin/showDupDict.py/el8_amd64_gcc12/www/wed/14.1-wed-23/CMSSW_14_1_X_2024-05-01-2300/testLogs/dupDict-lostDefs.log )