Tau Embedding update and integration #43871
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43871/38717
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
cmsbuild
added
code-checks-rejected
code-checks-pending
and removed
code-checks-pending
code-checks-rejected
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43871/38724
|
|
A new Pull Request was created by @winterchristian for master. It involves the following packages:
@mdhildreth, @cmsbuild, @mandrenguyen, @jfernan2, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X. |
|
please test |
|
-1 Failed Tests: UnitTests Unit TestsI found 4 errors in the following unit tests: ---> test testTauEmbeddingWorkflow2016preVFP had ERRORS ---> test testTauEmbeddingWorkflow2018 had ERRORS ---> test testTauEmbeddingWorkflow2016postVFP had ERRORS and more ... Comparison SummarySummary:
|
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3fe5f5/38982/summary.html Comparison SummarySummary:
|
|
type tau |
|
+reconstruction @civanch Simulation will have to re-sign. |
|
+1 |
cmsbuild
added
simulation-approved
fully-signed
and removed
simulation-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
| <class name="std::vector<edm::RefVector<std::vector<reco::GsfTrack>,reco::GsfTrack,edm::refhelper::FindUsingAdvance<std::vector<reco::GsfTrack>,reco::GsfTrack> > >"/> | ||
| <class name="edm::Wrapper<edm::RefVector<std::vector<reco::GsfTrack>,reco::GsfTrack,edm::refhelper::FindUsingAdvance<std::vector<reco::GsfTrack>,reco::GsfTrack> > >"/> | ||
| <class name="std::vector<edm::Ref<std::vector<reco::GsfTrack>,reco::GsfTrack,edm::refhelper::FindUsingAdvance<std::vector<reco::GsfTrack>,reco::GsfTrack> > >"/> | ||
|
|
There was a problem hiding this comment.
@winterchristian , normally GsfTrackReco type dictionaries should go in to DataFormats/GsfTrackReco. Any specific reason to add these dict in DataFormats/EgammaCandidates package?
There was a problem hiding this comment.
@cms-sw/reconstruction-l2 any objections on moving these to DataFormats/GsfTrackReco ?
There was a problem hiding this comment.
No objection. Sorry we missed it.
There was a problem hiding this comment.
same from us (answering for @winterchristian since he is on holiday)
|
Also a configuration problem, see #44896 for more details |
|
It is being fixed on #44928 |
PR description:
This PR updates the tau embedding method (
TauAnalysis/MCEmbeddingTools) so that it is possible to produce RUN 2 UL tau embedding samples with the newest CMSSW version. The last used working version was CMSSW_10_6_28.The changes also serve as preparation for the production of RUN 3 tau embedding samples.
The tau embedding method is used to estimate the genuine di-tau background from data. It is a common method used in analyses with tau leptons. More information about tau embedding can be found in the paper: https://doi.org/10.1088/1748-0221/14/06/P06032
In principle, one can split the method into 4 steps, but technically there are at least 6 steps that have to be executed.
In the past, the production of tau embedding samples was always done with a private fork and with institute computation resources. As a long term solution the production will be integrated in central CMS production.
The changes were already presented at tau CQM meetings:
https://indico.cern.ch/event/1366561/#34-integration-of-tau-embeddin
https://indico.cern.ch/event/1301309/#26-tau-embedding-integration-i
And will be presented at a RECO meeting:
https://indico.cern.ch/event/1377565/#15-integration-of-state-of-the
PR validation:
4 unit tests were added which make sure all steps run through for the 4 different data taking periods in RUN 2 UL. At the moment the event files used for this are stored in a private eos directory.