-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify micro arch selection; set default micro arch to x86-64-v2 #9166
Conversation
A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master. @aandvalenzuela, @cmsbuild, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks. |
cms-bot internal usage |
2293273
to
56d942a
Compare
Pull request #9166 was updated. |
test parameters:
|
please test for CMSSW_14_1_MULTIARCHS_X/el8_amd64_gcc12 |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa37cc/39135/summary.html External BuildI found compilation error when building: + CFLAGS='-fPIC -O3 -DUSE_MMAP -DUNALIGNED_OK -D_LARGEFILE64_SOURCE=1 -mx86-64-v2' + ./configure --prefix=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/84956533166d4eef7141f08703457f8b/opt/cmssw/el8_amd64_gcc12/external/zlib/1.2.11-84956533166d4eef7141f08703457f8b Checking for gcc... Compiler error reporting is too harsh for ./configure (perhaps remove -Werror). ** ./configure aborting. error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.wuboyp (%build) RPM build errors: line 36: It's not recommended to have unversioned Obsoletes: Obsoletes: external+zlib+1.2.11-84956533166d4eef7141f08703457f8b Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.wuboyp (%build) |
please test for CMSSW_14_1_MULTIARCHS_X/el8_amd64_gcc12 |
Pull request #9166 was updated. |
please test for CMSSW_14_1_MULTIARCHS_X/el8_amd64_gcc12 |
please test for CMSSW_14_1_MULTIARCHS_X/el8_amd64_gcc12 |
Pull request #9166 was updated. |
d649c04
to
d32a009
Compare
please test for CMSSW_14_1_MULTIARCHS_X/el8_amd64_gcc12 |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa37cc/39193/summary.html External BuildI found compilation error when building: + perl -p -i -e 's|\@([a-zA-Z0-9_-]*)\@|$ENV{$1}|g' /pool/condor/dir_2920405/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/190a2a634f77e746b58b37be4193442d/opt/cmssw/el8_amd64_gcc12/cms/coral-tool-conf/10.0-190a2a634f77e746b58b37be4193442d/tools/selected/x11.xml + echo ' Copied x11.xml' Copied x11.xml + '[' -d /etc/scram.d ']' /pool/condor/dir_2920405/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Rm5yHV: line 62: syntax error near unexpected token `<<<' error: Bad exit status from /pool/condor/dir_2920405/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Rm5yHV (%install) RPM build errors: line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: cms+coral-tool-conf+10.0-190a2a634f77e746b58b37be4193442d Bad exit status from /pool/condor/dir_2920405/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Rm5yHV (%install) |
please test for CMSSW_14_1_MULTIARCHS_X/el8_amd64_gcc12 |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa37cc/39197/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa37cc/39204/summary.html Comparison SummarySummary:
|
please test |
please test for slc7_amd64_gcc12 |
please test for el9_amd64_gcc12 |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found 1 errors in the following unit tests: ---> test testHGCalMapFileParser had ERRORS Comparison SummarySummary:
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found 1 errors in the following unit tests: ---> test testHGCalMapFileParser had ERRORS Comparison SummarySummary:
|
+externals looks good, tested via #9156 for el8/el9 and slc7 |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
This PR simplify the selection of default micro archtitecture which is now defined in
cmsdist/microarch_flags.file
file. Every package which needs to be enable micro-instraction should include it and pass%{selected_microarch}
to the its build system.This also updates the default micro arch to
x86-64-v2
( previously it wassse3
)