[GENERATORS] [DEVEL] Fix warnings on deprecated copy-constructors #43405

smuzaffar · 2023-11-27T17:15:49Z

Fixes deprecated warnings for DEVEL IBs

smuzaffar · 2023-11-27T17:17:57Z

please test for CMSSW_14_0_DEVEL_X

cmsbuild · 2023-11-27T17:23:45Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43405/37907

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File SimDataFormats/GeneratorProducts/src/classes_def.xml modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167, Adding HepMC3 products to EDMProduct #38033

cmsbuild · 2023-11-27T17:24:06Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

SimDataFormats/GeneratorProducts (generators)

@bbilin, @alberto-sanchez, @GurpreetSinghChahal, @mkirsano, @SiewYan, @menglu21 can you please review it and eventually sign? Thanks.
@fabiocos, @bsunanda, @apsallid, @youyingli, @missirol, @rovere this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2023-11-27T18:52:11Z

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57fc96/36094/summary.html
COMMIT: 924ab10
CMSSW: CMSSW_14_0_DEVEL_X_2023-11-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43405/36094/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

158.01

----- Begin Fatal Exception 27-Nov-2023 18:54:59 CET-----------------------
An exception of category 'FileReadError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'Flag_hcalLaserEventFilter'
   [2] Prefetching for module HcalLaserEventFilter/'hcalLaserEventFilter'
   [3] While reading from source HcalNoiseSummary hcalnoise '' RECO
   [4] Rethrowing an exception that happened on a different read request.
   [5] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [6] Running path 'validation_step'
   [7] Prefetching for module JetTester/'JetAnalyzerAk8PFPUPPIMiniAOD'
   [8] While reading from source GenEventInfoProduct generator '' SIM
   [9] Reading branch GenEventInfoProduct_generator__SIM.
   Additional Info:
      [a] Fatal Root Error: @SUB=TClass::BuildRealData
Inspection for auto_ptr<gen::PdfInfo> not supported!

----- End Fatal Exception -------------------------------------------------

AddOn Tests

pat1

----- Begin Fatal Exception 27-Nov-2023 18:47:47 CET-----------------------
An exception of category 'FileReadError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 0
   [1] Running path 'p'
   [2] Prefetching for module CandidateSummaryTable/'selectedPatCandidateSummary'
   [3] Prefetching for module PATJetSelector/'selectedPatJets'
   [4] Prefetching for module PATJetProducer/'patJets'
   [5] While reading from source edm::AssociationVector<edm::RefToBaseProd<reco::Jet>,std::vector<edm::RefVector<std::vector<reco::Track>,reco::Track,edm::refhelper::FindUsingAdvance<std::vector<reco::Track>,reco::Track> > >,edm::RefToBase<reco::Jet>,unsigned int,edm::helper::AssociationIdenticalKeyReference> ak4JetTracksAssociatorAtVertexPF '' RECO
   [6] Rethrowing an exception that happened on a different read request.
   [7] Processing  Event run: 1 lumi: 1 event: 2 stream: 0
   [8] Running path 'p'
   [9] Prefetching for module CandidateSummaryTable/'selectedPatCandidateSummary'
   [10] Prefetching for module PATJetSelector/'selectedPatJets'
   [11] Prefetching for module PATJetProducer/'patJets'
   [12] Prefetching for module JetFlavourClustering/'patJetFlavourAssociation'
   [13] Prefetching for module HadronAndPartonSelector/'patJetPartons'
   [14] While reading from source GenEventInfoProduct generator '' SIM
   [15] Reading branch GenEventInfoProduct_generator__SIM.
   Additional Info:
      [a] Fatal Root Error: @SUB=TClass::BuildRealData
Inspection for auto_ptr<gen::PdfInfo> not supported!

----- End Fatal Exception -------------------------------------------------

smuzaffar · 2023-11-28T09:59:17Z

@makortel @Dr15Jones , any idea how to fix this. If we keep <class name="std::auto_ptr<gen::PdfInfo>"/> then we get warnings like [a] ('std::auto_ptr' is deprecated) and replacing it with std::unique_ptr rootcling fails with error

Error: It is not necessary to explicitly select class unique_ptr<gen::PdfInfo,default_delete<gen::PdfInfo> >. I/O is supported for it transparently.

and removing it causese runtime errors like

Inspection for auto_ptr<gen::PdfInfo> not supported!

any idea ?

[a]

SimDataFormatsGeneratorProducts/a/SimDataFormatsGeneratorProducts_xr.cc: At global scope:
  SimDataFormatsGeneratorProducts/a/SimDataFormatsGeneratorProducts_xr.cc:234:62: warning: 'template<class> class std::auto_ptr' is deprecated: use 'std::unique_ptr' instead [-Wdeprecated-declarations]
   234 |    static TGenericClassInfo *GenerateInitInstanceLocal(const auto_ptr<gen::PdfInfo>*)
      |                                                              ^~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/memory:75,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/lcg/root/6.26.11-1ef575234f3b954353280f3578660947/include/ROOT/TypeTraits.hxx:15,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/lcg/root/6.26.11-1ef575234f3b954353280f3578660947/include/TString.h:30,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/lcg/root/6.26.11-1ef575234f3b954353280f3578660947/include/TNamed.h:26,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/lcg/root/6.26.11-1ef575234f3b954353280f3578660947/include/TDictionary.h:44,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/lcg/root/6.26.11-1ef575234f3b954353280f3578660947/include/TClass.h:23,
                 from SimDataFormatsGeneratorProducts/a/SimDataFormatsGeneratorProducts_xr.cc:14:
/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/unique_ptr.h:64:28: note: declared here
   64 |   template<typename> class auto_ptr;

Dr15Jones · 2023-11-28T14:28:09Z

The reason we have a dictionary generation for auto_ptr<gen::PdfInfo> is the class GenEventInfoProduct used to use an auto_ptr but 5 years ago we changed it to use a unique_ptr so the dictionary for auto_ptr is only needed for the IO rule that allows us to read old files. The change to unique_ptr was done in CMSSW_11_0_0.

makortel · 2023-11-28T15:16:24Z

@smuzaffar Discussing with @Dr15Jones about what to do here, we think dealing with the use of auto_ptr in the ROOT dictionaries needs a bit more discussion, so I'll open a separate issue to discuss what exactly to do with that. I'd suggest to undo the changes in classes_def.xml in this PR, and continue with the rest.

smuzaffar · 2023-11-28T15:20:30Z

please test

cmsbuild · 2023-11-28T15:25:15Z

Pull request #43405 was updated. @SiewYan, @mkirsano, @GurpreetSinghChahal, @bbilin, @alberto-sanchez, @menglu21 can you please check and sign again.

cmsbuild · 2023-11-28T18:10:41Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57fc96/36127/summary.html
COMMIT: 802b299
CMSSW: CMSSW_14_0_X_2023-11-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43405/36127/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 4 lines to the logs
Reco comparison results: 21 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3367918
DQMHistoTests: Total failures: 1112
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3366784
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

smuzaffar · 2023-12-04T07:38:36Z

please test

smuzaffar · 2023-12-04T07:39:11Z

@cms-sw/generators-l2 can you please review this change?

cmsbuild · 2023-12-04T10:33:33Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57fc96/36289/summary.html
COMMIT: 802b299
CMSSW: CMSSW_14_0_X_2023-12-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43405/36289/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 61 lines to the logs
Reco comparison results: 9 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3370032
DQMHistoTests: Total failures: 78
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3369932
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

smuzaffar · 2023-12-05T15:41:21Z

@bbilin, @alberto-sanchez, @GurpreetSinghChahal, @mkirsano, @SiewYan, @menglu21 can you please review this. This is just atechnical change to fix the deprecated copy constructor warnings

smuzaffar · 2023-12-06T07:21:51Z

please test for CMSSW_14_0_DEVEL_X

cmsbuild · 2023-12-06T10:00:23Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57fc96/36344/summary.html
COMMIT: 802b299
CMSSW: CMSSW_14_0_DEVEL_X_2023-12-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43405/36344/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 68 lines from the logs
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3430794
DQMHistoTests: Total failures: 89
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3430683
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

smuzaffar · 2023-12-08T14:43:27Z

@bbilin, @alberto-sanchez, @GurpreetSinghChahal, @mkirsano, @SiewYan, @menglu21 any generator L2 around to review this PR?

smuzaffar · 2023-12-18T12:18:11Z

@cms-sw/generators-l2 can you please review this. This is needed to fix the most of the build warnings for DEVEL IBs

smuzaffar · 2023-12-18T17:08:55Z

@cms-sw/orp-l2 , looks like non of @cms-sw/generators-l2 are around for last 2 weeks. This fixes the deprecated warnings issue by removing the unnecessary copy construction/operator. Can we merge this for 14.0.X

antoniovilela · 2023-12-18T23:43:55Z

@cms-sw/orp-l2 , looks like non of @cms-sw/generators-l2 are around for last 2 weeks. This fixes the deprecated warnings issue by removing the unnecessary copy construction/operator. Can we merge this for 14.0.X

Thanks. Yes.

antoniovilela · 2023-12-18T23:44:08Z

+1

antoniovilela · 2023-12-18T23:44:35Z

merge

smuzaffar added 2 commits November 27, 2023 18:13

[GENERATORS] [DEVEL] Fix warnings on deprecated copy-constructors

6dacd69

apply code format

924ab10

cmsbuild added this to the CMSSW_14_0_X milestone Nov 27, 2023

cmsbuild added generators-pending pending-signatures tests-pending orp-pending code-checks-pending labels Nov 27, 2023

cmsbuild added tests-started and removed tests-pending labels Nov 27, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 27, 2023

cmsbuild added tests-rejected and removed tests-started labels Nov 27, 2023

Revert auto_ptr change for root dict

802b299

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Nov 28, 2023

cmsbuild added tests-started and removed tests-pending labels Nov 28, 2023

makortel mentioned this pull request Nov 28, 2023

Reading old files containing std::auto_ptr<gen::PdfInfo> #43422

Open

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 28, 2023

cmsbuild added tests-approved and removed tests-started labels Nov 28, 2023

cmsbuild added tests-started and removed tests-approved labels Dec 4, 2023

cmsbuild added tests-approved and removed tests-started labels Dec 4, 2023

smuzaffar changed the title ~~[GENERATORS] [DEVEL] Fix warnings on deprecated copy-constructors @smuzaffar~~ [GENERATORS] [DEVEL] Fix warnings on deprecated copy-constructors Dec 6, 2023

cmsbuild added orp-approved and removed orp-pending labels Dec 18, 2023

cmsbuild merged commit 402de4a into cms-sw:master Dec 18, 2023
17 checks passed

This was referenced Dec 19, 2023

VecGeom: Update to version 1.2.7 cms-sw/cmsdist#8864

Merged

[ROOT6] Updated root to tip of branch master cms-sw/cmsdist#8895

Closed

[Geant4] Update to 11.2.0 for G4VecGeom IBs cms-sw/cmsdist#8878

Merged

Materialize terror symbols cms-sw/root#191

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GENERATORS] [DEVEL] Fix warnings on deprecated copy-constructors #43405

[GENERATORS] [DEVEL] Fix warnings on deprecated copy-constructors #43405

smuzaffar commented Nov 27, 2023

smuzaffar commented Nov 27, 2023

cmsbuild commented Nov 27, 2023

cmsbuild commented Nov 27, 2023 •

edited

Loading

cmsbuild commented Nov 27, 2023

smuzaffar commented Nov 28, 2023

Dr15Jones commented Nov 28, 2023

makortel commented Nov 28, 2023

smuzaffar commented Nov 28, 2023

cmsbuild commented Nov 28, 2023

cmsbuild commented Nov 28, 2023

smuzaffar commented Dec 4, 2023

smuzaffar commented Dec 4, 2023

cmsbuild commented Dec 4, 2023

smuzaffar commented Dec 5, 2023

smuzaffar commented Dec 6, 2023

cmsbuild commented Dec 6, 2023

smuzaffar commented Dec 8, 2023

smuzaffar commented Dec 18, 2023

smuzaffar commented Dec 18, 2023

antoniovilela commented Dec 18, 2023

antoniovilela commented Dec 18, 2023

antoniovilela commented Dec 18, 2023

[GENERATORS] [DEVEL] Fix warnings on deprecated copy-constructors #43405

[GENERATORS] [DEVEL] Fix warnings on deprecated copy-constructors #43405

Conversation

smuzaffar commented Nov 27, 2023

smuzaffar commented Nov 27, 2023

cmsbuild commented Nov 27, 2023

cmsbuild commented Nov 27, 2023 • edited Loading

cmsbuild commented Nov 27, 2023

RelVals

AddOn Tests

smuzaffar commented Nov 28, 2023

Dr15Jones commented Nov 28, 2023

makortel commented Nov 28, 2023

smuzaffar commented Nov 28, 2023

cmsbuild commented Nov 28, 2023

cmsbuild commented Nov 28, 2023

Comparison Summary

smuzaffar commented Dec 4, 2023

smuzaffar commented Dec 4, 2023

cmsbuild commented Dec 4, 2023

Comparison Summary

smuzaffar commented Dec 5, 2023

smuzaffar commented Dec 6, 2023

cmsbuild commented Dec 6, 2023

Comparison Summary

smuzaffar commented Dec 8, 2023

smuzaffar commented Dec 18, 2023

smuzaffar commented Dec 18, 2023

antoniovilela commented Dec 18, 2023

antoniovilela commented Dec 18, 2023

antoniovilela commented Dec 18, 2023

cmsbuild commented Nov 27, 2023 •

edited

Loading