Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROOT6] Updated root to tip of branch master #8895

Closed
wants to merge 1 commit into from
Closed

[ROOT6] Updated root to tip of branch master #8895

wants to merge 1 commit into from

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Dec 19, 2023 •
edited
Loading

This update fixes the ROOT opening too many files issue ( see cms-sw/cmssw#43077 for details)

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_14_0_X/rootmaster.

@iarspider, @aandvalenzuela, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 19, 2023 •
edited
Loading

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

test parameters:

  • skip_test = static,header

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmssw#43596 for CMSSW_14_0_ROOT6_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-468d0d/36567/summary.html
COMMIT: 31f7d6c
CMSSW: CMSSW_14_0_ROOT6_X_2023-12-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8895/36567/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-468d0d/36567/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-468d0d/36567/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test test-import-root-openat had ERRORS

Comparison Summary

Summary:

@smuzaffar smuzaffar closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures requires-external tests-rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smuzaffar @cmsbuild