-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding HepMC3 products to EDMProduct #38033
base: master
Are you sure you want to change the base?
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38033/30110
|
A new Pull Request was created by @SiewYan (Siewyan Hoh 何守仁) for master. It involves the following packages:
@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
FYI: @imranyusuff |
please test |
-1 Failed Tests: Build ClangBuild BuildI found compilation error when building: >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-21-1100/src/SimDataFormats/GeneratorProducts/src/LHEXMLStringProduct.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-21-1100/src/SimDataFormats/GeneratorProducts/src/hepmc_rootio.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-21-1100/src/SimDataFormats/GeneratorProducts/src/HepEvt.F Error: Class shared_ptr has been selected but currently the support for its I/O is not yet available. Note that shared_ptr, even if not selected, will be available for interpreted code. Error: Class shared_ptr has been selected but currently the support for its I/O is not yet available. Note that shared_ptr, even if not selected, will be available for interpreted code. gmake: *** [tmp/el8_amd64_gcc10/src/SimDataFormats/GeneratorProducts/src/SimDataFormatsGeneratorProducts/a/SimDataFormatsGeneratorProducts_xr.cc] Error 1 >> Compiling LCG dictionary: tmp/el8_amd64_gcc10/src/SimDataFormats/GeneratorProducts/src/SimDataFormatsGeneratorProducts/a/SimDataFormatsGeneratorProducts_xr.cc c++: error: SimDataFormatsGeneratorProducts/a/SimDataFormatsGeneratorProducts_xr.cc: No such file or directory c++: fatal error: no input files compilation terminated. gmake: *** [tmp/el8_amd64_gcc10/src/SimDataFormats/GeneratorProducts/src/SimDataFormatsGeneratorProducts/a/SimDataFormatsGeneratorProducts_xr.cc.o] Error 1 Clang BuildI found compilation error while trying to compile with clang. Command used:
>> Local Products Rules ..... started >> Local Products Rules ..... done >> Creating project symlinks >> Entering Package SimDataFormats/GeneratorProducts >> Compile sequence completed for CMSSW CMSSW_12_5_X_2022-05-21-1100 gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1 + eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --ignoreWarning=Wdeprecated-declarations --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-21-1100/tmp/el8_amd64_gcc10/cache/log/src '||' 'true)' ++ scram build outputlog >> Entering Package SimDataFormats/GeneratorProducts Entering library rule at SimDataFormats/GeneratorProducts >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-21-1100/src/SimDataFormats/GeneratorProducts/src/GenEventInfoProduct.cc |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38033/31271
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
-orp |
hold |
Pull request has been put on hold by @antoniovilela |
I looked again at this. Some combinations in classes_def.xml can compile, but the final check is to run pythia8hmc3ex2_cfg.py in Pythia8Interface/test. It exists in later CMSSW releases (together with the needed code in GeneratorInterface/Core). For example there are runtime errors like this: Fatal Root Error: @sub=TStreamerInfo::Build An edm expert is needed to solve this. If needed, I can try this in CMSSW_14 and describe the full test action. |
Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X. |
This is superseeded by #44603 and can be closed, thanks to @mseidel42 |
PR description:
This PR trying to address the EDM addition in #37187 , using advises from twiki [*].
The HepMC3 package adapted new strategy to manipulate event records of High Energy Physics Monte Carlo Event Generators (MCEGs) [**], notably:
[*] https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideCreatingNewProducts
[**] https://iopscience.iop.org/article/10.1088/1742-6596/1525/1/012017/pdf
The HepMC3 new data format poses challenges on defining the corresponding EDMProduct definition.
This PR depicts partial implementation, due to some technical error:
I am looking for advice(s) on how to solve the error. @smuzaffar, @mkirsano
Note: class version will be done accordingly after a successful compilation with the amended version classes_def.xml.
Related Issue/PR:
PR validation:
No validation yet, to be finalized as the PR evolve..
if this PR is a backport please specify the original PR and why you need to backport that PR:
NA