[WIP] Remove all `std::pair<X, Y>` dictionaries as unnecessary #45466

makortel · 2024-07-15T19:30:58Z

PR description:

According to #32444 (comment) the dictionaries for std::pair<X, Y> are not needed anymore, and some of them were giving trouble in #45423 (comment). This PR experiments what will happen if all of them would be removed.

While doing this I encountered several dictionaries on std-only types in various packages that should be in DataFormats/StdDictionaries or DataFormats/WrappedStdDictionaries, so I took the opportunity to move them in the right place.

PR validation:

None

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Potentially to be backported to 14_0_X in some form (for #45423)

…s package

cmsbuild · 2024-07-15T19:31:29Z

cms-bot internal usage

cmsbuild · 2024-07-15T19:35:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45466/40925

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/CSCRecHit/src/classes_def.xml modified in PR(s): [RFC] Replace RangeMap used in Muon hit storage #42917
- File DataFormats/DTRecHit/src/classes_def.xml modified in PR(s): [RFC] Replace RangeMap used in Muon hit storage #42917
- File DataFormats/ParticleFlowCandidate/src/classes_def.xml modified in PR(s): PFCandidate no longer inherits from CompositeCandidate #38999
- File DataFormats/PatCandidates/src/classes_def_objects.xml modified in PR(s): PFCandidate no longer inherits from CompositeCandidate #38999
- File DataFormats/RPCRecHit/src/classes_def.xml modified in PR(s): [RFC] Replace RangeMap used in Muon hit storage #42917
- File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): move dictionaries next to typedefs for TrackingParticle associations #37507
- File SimDataFormats/GeneratorProducts/src/classes_def.xml modified in PR(s): Adding HepMC3 products to EDMProduct #38033
- File SimDataFormats/TrackingAnalysis/src/classes_def.xml modified in PR(s): move dictionaries next to typedefs for TrackingParticle associations #37507

cmsbuild · 2024-07-15T19:36:01Z

A new Pull Request was created by @makortel for master.

It involves the following packages:

AnalysisDataFormats/TopObjects (analysis)
AnalysisDataFormats/TrackInfo (analysis)
CalibTracker/SiPixelQuality (alca)
CondFormats/CSCObjects (db, alca)
CondFormats/Calibration (db, alca)
CondFormats/Common (db, alca)
CondFormats/DTObjects (db, alca)
CondFormats/ESObjects (db, alca)
CondFormats/EcalObjects (db, alca)
CondFormats/HLTObjects (db, hlt, alca)
CondFormats/HcalObjects (db, alca)
CondFormats/L1TObjects (l1, db, alca)
CondFormats/PPSObjects (alca)
CondFormats/RPCObjects (db, alca)
CondFormats/SiPixelObjects (db, alca)
DataFormats/BTauReco (reconstruction)
DataFormats/CSCDigi (simulation)
DataFormats/CSCRecHit (reconstruction)
DataFormats/CTPPSReco (reconstruction)
DataFormats/CaloRecHit (reconstruction)
DataFormats/CaloTowers (reconstruction)
DataFormats/Candidate (reconstruction)
DataFormats/DTDigi (simulation)
DataFormats/DTRecHit (reconstruction)
DataFormats/DetId (simulation)
DataFormats/EgammaCandidates (reconstruction)
DataFormats/GEMDigi (simulation, upgrade)
DataFormats/HGCRecHit (reconstruction, upgrade)
DataFormats/JetMatching (simulation)
DataFormats/L1CSCTrackFinder (l1)
DataFormats/L1TrackTrigger (l1, upgrade)
DataFormats/L1Trigger (l1)
DataFormats/ParticleFlowCandidate (reconstruction)
DataFormats/ParticleFlowReco (reconstruction)
DataFormats/PatCandidates (xpog, reconstruction)
DataFormats/Provenance (core)
DataFormats/RPCDigi (simulation)
DataFormats/RPCRecHit (reconstruction)
DataFormats/SiPixelRawData (simulation)
DataFormats/StdDictionaries (core)
DataFormats/TauReco (reconstruction)
DataFormats/TestObjects (core)
DataFormats/TrackReco (reconstruction)
DataFormats/TrackingRecHit (reconstruction)
DataFormats/VertexReco (reconstruction)
DataFormats/WrappedStdDictionaries (core)
SimDataFormats/Associations (simulation)
SimDataFormats/CaloAnalysis (simulation)
SimDataFormats/GeneratorProducts (generators)
SimDataFormats/TrackingAnalysis (simulation)
SimDataFormats/ValidationFormats (simulation)
SimGeneral/TrackingAnalysis (simulation)
SimTracker/TrackTriggerAssociation (l1, simulation)
SimTracker/TrackerHitAssociation (simulation)

@Dr15Jones, @GurpreetSinghChahal, @Martin-Grunewald, @SiewYan, @alberto-sanchez, @aloeliger, @bbilin, @civanch, @cmsbuild, @consuegs, @epalencia, @francescobrivio, @ftorrresd, @hqucms, @jfernan2, @makortel, @mandrenguyen, @mdhildreth, @menglu21, @mkirsano, @mmusich, @perrotta, @saumyaphor4252, @smuzaffar, @srimanob, @subirsarkar, @tvami, @vlimant can you please review it and eventually sign? Thanks.
@AlexDeMoor, @CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @JanChyczynski, @JanFSchulte, @Ming-Yan, @PonIlya, @Prasant1993, @ReyerBand, @Sam-Harper, @Senphy, @VinInn, @VourMa, @a-kapoor, @abbiendi, @abdoulline, @afiqaize, @andrea21z, @andrzejnovak, @apsallid, @argiro, @azotz, @battibass, @bsunanda, @castaned, @cericeci, @cseez, @demuller, @dgulhan, @dinyar, @dkotlins, @eyigitba, @fabferro, @fabiocos, @felicepantaleo, @ferencek, @giovanni-mocellin, @gouskos, @gpetruc, @grzanka, @hatakeyamak, @jainshilpi, @jhgoh, @jshlee, @kreczko, @lgray, @martinamalberti, @mbluj, @missirol, @mmusich, @mroguljic, @mtosi, @pfs, @ptcox, @ram1123, @rchatter, @rovere, @rsreds, @sameasy, @seemasharmafnal, @sethzenz, @silviodonato, @slomeo, @sobhatta, @sviret, @thomreis, @threus, @tocheng, @trocino, @tsusa, @tvami, @vandreev11, @varuns23, @wang0jin, @watson-ij, @wddgit, @wmtford, @youyingli, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

makortel · 2024-07-15T19:43:15Z

@cmsbuild, please test

cmsbuild · 2024-07-15T21:11:24Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Size: This PR adds an extra 216KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fb0a4/40413/summary.html
COMMIT: 1488826
CMSSW: CMSSW_14_1_X_2024-07-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45466/40413/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 5 errors in the following unit tests:

---> test testCalibTrackerSiStripCommon had ERRORS
---> test test_MC_23_crosscheck had ERRORS
---> test test_MC_22_crosscheck had ERRORS
and more ...

RelVals

136.731

----- Begin Fatal Exception 15-Jul-2024 22:30:18 CEST-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCTFUnpacker label='unpackCsctf'
   [2] Calling ProductRegistryHelper::addToRegistry, checking dictionaries for produced types
Exception Message:
No data dictionary found for the following classes:

  std::pair<int,std::vector<L1CSCSPStatusDigi> >

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type declared by a producer module with the function 'produces'.
Instead it might be the type of a data member, base class,
wrapped type, or other object needed by a produced type. Below
is some additional information which lists the types declared
to be produced by a producer module that are associated with
the types whose dictionaries were not found:

  std::pair<int,std::vector<L1CSCSPStatusDigi> >

----- End Fatal Exception -------------------------------------------------

136.793

----- Begin Fatal Exception 15-Jul-2024 22:30:18 CEST-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCTFUnpacker label='unpackCsctf'
   [2] Calling ProductRegistryHelper::addToRegistry, checking dictionaries for produced types
Exception Message:
No data dictionary found for the following classes:

  std::pair<int,std::vector<L1CSCSPStatusDigi> >

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type declared by a producer module with the function 'produces'.
Instead it might be the type of a data member, base class,
wrapped type, or other object needed by a produced type. Below
is some additional information which lists the types declared
to be produced by a producer module that are associated with
the types whose dictionaries were not found:

  std::pair<int,std::vector<L1CSCSPStatusDigi> >

----- End Fatal Exception -------------------------------------------------

139.001

----- Begin Fatal Exception 15-Jul-2024 22:30:18 CEST-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCTFUnpacker label='unpackCsctf'
   [2] Calling ProductRegistryHelper::addToRegistry, checking dictionaries for produced types
Exception Message:
No data dictionary found for the following classes:

  std::pair<int,std::vector<L1CSCSPStatusDigi> >

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type declared by a producer module with the function 'produces'.
Instead it might be the type of a data member, base class,
wrapped type, or other object needed by a produced type. Below
is some additional information which lists the types declared
to be produced by a producer module that are associated with
the types whose dictionaries were not found:

  std::pair<int,std::vector<L1CSCSPStatusDigi> >

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
134.807134.807_RunDoubleEGPrpt2015C/step2_RunDoubleEGPrpt2015C.log
136.721136.721_RunHLTPhy2016B/step2_RunHLTPhy2016B.log

Expand to see more relval errors ...

AddOn Tests

fastsim

----- Begin Fatal Exception 15-Jul-2024 22:30:24 CEST-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  std::pair<OmniClusterRef,edm::Ref<std::vector<TrackingParticle>,TrackingParticle,edm::refhelper::FindUsingAdvance<std::vector<TrackingParticle>,TrackingParticle> > >
  std::pair<csc::L1Track,MuonDigiCollection<CSCDetId,CSCCorrelatedLCTDigi> >
  std::pair<edm::Ref<std::vector<TrackingParticle>,TrackingParticle,edm::refhelper::FindUsingAdvance<std::vector<TrackingParticle>,TrackingParticle> >,edm::Ref<std::vector<PSimHit>,PSimHit,edm::refhelper::FindUsingAdvance<std::vector<PSimHit>,PSimHit> > >
  std::pair<edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,edm::Ref<std::vector<reco::PFTauTransverseImpactParameter>,reco::PFTauTransverseImpactParameter,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTauTransverseImpactParameter>,reco::PFTauTransverseImpactParameter> > >
  std::pair<edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,edm::Ref<std::vector<reco::Vertex>,reco::Vertex,edm::refhelper::FindUsingAdvance<std::vector<reco::Vertex>,reco::Vertex> > >
  std::pair<edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,float>
  std::pair<edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,std::vector<edm::Ref<std::vector<reco::Vertex>,reco::Vertex,edm::refhelper::FindUsingAdvance<std::vector<reco::Vertex>,reco::Vertex> > > >
  std::pair<edm::RefToBase<reco::Jet>,reco::JetFlavour>
  std::pair<edm::RefToBase<reco::Jet>,reco::JetFlavourInfo>
  std::pair<edm::RefToBase<reco::Jet>,reco::MatchedPartons>
  std::pair<edm::RefToBase<reco::Jet>,std::vector<reco::PFRecoTauChargedHadron> >
  std::pair<edm::RefToBase<reco::Jet>,std::vector<reco::RecoTauPiZero> >
  std::pair<unsigned long,edm::Ptr<reco::PFCluster> >

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  ClusterTPAssociation (produced in current process)
  edm::AssociationVector<edm::RefProd<std::vector<reco::PFTau> >,std::vector<edm::Ref<std::vector<reco::PFTauTransverseImpactParameter>,reco::PFTauTransverseImpactParameter,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTauTransverseImpactParameter>,reco::PFTauTransverseImpactParameter> > >,edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,unsigned int,edm::helper::AssociationIdenticalKeyReference> (produced in current process)
  edm::AssociationVector<edm::RefProd<std::vector<reco::PFTau> >,std::vector<edm::Ref<std::vector<reco::Vertex>,reco::Vertex,edm::refhelper::FindUsingAdvance<std::vector<reco::Vertex>,reco::Vertex> > >,edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,unsigned int,edm::helper::AssociationIdenticalKeyReference> (produced in current process)
  edm::AssociationVector<edm::RefProd<std::vector<reco::PFTau> >,std::vector<std::vector<edm::Ref<std::vector<reco::Vertex>,reco::Vertex,edm::refhelper::FindUsingAdvance<std::vector<reco::Vertex>,reco::Vertex> > > >,edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,unsigned int,edm::helper::AssociationIdenticalKeyReference> (produced in current process)
  reco::JetFlavourInfoMatchingCollection (produced in current process)
  reco::JetFlavourMatchingCollection (produced in current process)
  reco::JetMatchedPartonsCollection (produced in current process)
  reco::JetPiZeroAssociation (produced in current process)
  reco::PFJetChargedHadronAssociation (produced in current process)
  reco::PFTauDiscriminator (produced in current process)
  std::vector<std::pair<csc::L1Track,MuonDigiCollection<CSCDetId,CSCCorrelatedLCTDigi> > > (produced in current process)
  std::vector<std::pair<edm::Ref<std::vector<TrackingParticle>,TrackingParticle,edm::refhelper::FindUsingAdvance<std::vector<TrackingParticle>,TrackingParticle> >,edm::Ref<std::vector<PSimHit>,PSimHit,edm::refhelper::FindUsingAdvance<std::vector<PSimHit>,PSimHit> > > > (produced in current process)
  std::vector<std::pair<unsigned long,edm::Ptr<reco::PFCluster> > > (produced in current process)

Missing dictionaries are associated with these branch names:

  ClusterTPAssociation_tpClusterProducerPreSplitting__RECO.
  ClusterTPAssociation_tpClusterProducer__RECO.
  TrackingParticlesTrackingParticleTrackingParticlesTrackingParticleedmrefhelperFindUsingAdvanceedmRefPSimHitsPSimHitPSimHitsPSimHitedmrefhelperFindUsingAdvanceedmRefstdpairs_simHitTPAssocProducer__RECO.
  cscL1TrackCSCDetIdCSCCorrelatedLCTDigiMuonDigiCollectionstdpairs_simCsctfTrackDigis__RECO.
  recoJetFlavourInfoMatchingCollection_myak4JetFlavourInfos__RECO.
  recoJetFlavourInfoMatchingCollection_patJetFlavourAssociation__RECO.
  recoJetFlavourMatchingCollection_patJetFlavourAssociationLegacy__RECO.
  recoJetMatchedPartonsCollection_patJetPartonAssociationLegacy__RECO.
  recoJetPiZeroAssociation_ak4PFJetsLegacyHPSPiZeros__RECO.
  recoPFJetChargedHadronAssociation_ak4PFJetsRecoTauChargedHadrons__RECO.
  recoPFTauDiscriminator_hpsPFTauDiscriminationByDeadECALElectronRejection__RECO.
  recoPFTauDiscriminator_hpsPFTauDiscriminationByDecayModeFindingNewDMs__RECO.
  recoPFTauDiscriminator_hpsPFTauDiscriminationByDecayModeFindingOldDMs__RECO.
  recoPFTauDiscriminator_hpsPFTauDiscriminationByDecayModeFinding__RECO.
  recoPFTauDiscriminator_hpsSelectionDiscriminator__RECO.
  recoPFTausedmRefProdrecoPFTauTransverseImpactParametersrecoPFTauTransverseImpactParameterrecoPFTauTransverseImpactParametersTorecoPFTauTransverseImpactParameteredmrefhelperFindUsingAdvanceedmRefsAssociationVector_hpsPFTauTransverseImpactParameters__RECO.
  recoPFTausedmRefProdrecoVertexsrecoVertexrecoVertexsTorecoVertexedmrefhelperFindUsingAdvanceedmRefsAssociationVector_hpsPFTauPrimaryVertexProducer__RECO.
  recoPFTausedmRefProdrecoVertexsrecoVertexrecoVertexsTorecoVertexedmrefhelperFindUsingAdvanceedmRefssAssociationVector_hpsPFTauSecondaryVertexProducer__RECO.
  ulongrecoPFClusteredmPtrstdpairs_particleFlowClusterECAL__RECO.
  ulongrecoPFClusteredmPtrstdpairs_particleFlowClusterOOTECAL__RECO.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------

fastsim1

----- Begin Fatal Exception 15-Jul-2024 22:30:24 CEST-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  std::pair<OmniClusterRef,edm::Ref<std::vector<TrackingParticle>,TrackingParticle,edm::refhelper::FindUsingAdvance<std::vector<TrackingParticle>,TrackingParticle> > >
  std::pair<csc::L1Track,MuonDigiCollection<CSCDetId,CSCCorrelatedLCTDigi> >
  std::pair<edm::Ref<std::vector<TrackingParticle>,TrackingParticle,edm::refhelper::FindUsingAdvance<std::vector<TrackingParticle>,TrackingParticle> >,edm::Ref<std::vector<PSimHit>,PSimHit,edm::refhelper::FindUsingAdvance<std::vector<PSimHit>,PSimHit> > >
  std::pair<edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,edm::Ref<std::vector<reco::PFTauTransverseImpactParameter>,reco::PFTauTransverseImpactParameter,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTauTransverseImpactParameter>,reco::PFTauTransverseImpactParameter> > >
  std::pair<edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,edm::Ref<std::vector<reco::Vertex>,reco::Vertex,edm::refhelper::FindUsingAdvance<std::vector<reco::Vertex>,reco::Vertex> > >
  std::pair<edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,float>
  std::pair<edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,std::vector<edm::Ref<std::vector<reco::Vertex>,reco::Vertex,edm::refhelper::FindUsingAdvance<std::vector<reco::Vertex>,reco::Vertex> > > >
  std::pair<edm::RefToBase<reco::Jet>,reco::JetFlavour>
  std::pair<edm::RefToBase<reco::Jet>,reco::JetFlavourInfo>
  std::pair<edm::RefToBase<reco::Jet>,reco::MatchedPartons>
  std::pair<edm::RefToBase<reco::Jet>,std::vector<reco::PFRecoTauChargedHadron> >
  std::pair<edm::RefToBase<reco::Jet>,std::vector<reco::RecoTauPiZero> >
  std::pair<unsigned long,edm::Ptr<reco::PFCluster> >

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  ClusterTPAssociation (produced in current process)
  edm::AssociationVector<edm::RefProd<std::vector<reco::PFTau> >,std::vector<edm::Ref<std::vector<reco::PFTauTransverseImpactParameter>,reco::PFTauTransverseImpactParameter,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTauTransverseImpactParameter>,reco::PFTauTransverseImpactParameter> > >,edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,unsigned int,edm::helper::AssociationIdenticalKeyReference> (produced in current process)
  edm::AssociationVector<edm::RefProd<std::vector<reco::PFTau> >,std::vector<edm::Ref<std::vector<reco::Vertex>,reco::Vertex,edm::refhelper::FindUsingAdvance<std::vector<reco::Vertex>,reco::Vertex> > >,edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,unsigned int,edm::helper::AssociationIdenticalKeyReference> (produced in current process)
  edm::AssociationVector<edm::RefProd<std::vector<reco::PFTau> >,std::vector<std::vector<edm::Ref<std::vector<reco::Vertex>,reco::Vertex,edm::refhelper::FindUsingAdvance<std::vector<reco::Vertex>,reco::Vertex> > > >,edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,unsigned int,edm::helper::AssociationIdenticalKeyReference> (produced in current process)
  reco::JetFlavourInfoMatchingCollection (produced in current process)
  reco::JetFlavourMatchingCollection (produced in current process)
  reco::JetMatchedPartonsCollection (produced in current process)
  reco::JetPiZeroAssociation (produced in current process)
  reco::PFJetChargedHadronAssociation (produced in current process)
  reco::PFTauDiscriminator (produced in current process)
  std::vector<std::pair<csc::L1Track,MuonDigiCollection<CSCDetId,CSCCorrelatedLCTDigi> > > (produced in current process)
  std::vector<std::pair<edm::Ref<std::vector<TrackingParticle>,TrackingParticle,edm::refhelper::FindUsingAdvance<std::vector<TrackingParticle>,TrackingParticle> >,edm::Ref<std::vector<PSimHit>,PSimHit,edm::refhelper::FindUsingAdvance<std::vector<PSimHit>,PSimHit> > > > (produced in current process)
  std::vector<std::pair<unsigned long,edm::Ptr<reco::PFCluster> > > (produced in current process)

Missing dictionaries are associated with these branch names:

  ClusterTPAssociation_tpClusterProducerPreSplitting__RECO.
  ClusterTPAssociation_tpClusterProducer__RECO.
  TrackingParticlesTrackingParticleTrackingParticlesTrackingParticleedmrefhelperFindUsingAdvanceedmRefPSimHitsPSimHitPSimHitsPSimHitedmrefhelperFindUsingAdvanceedmRefstdpairs_simHitTPAssocProducer__RECO.
  cscL1TrackCSCDetIdCSCCorrelatedLCTDigiMuonDigiCollectionstdpairs_simCsctfTrackDigis__RECO.
  recoJetFlavourInfoMatchingCollection_myak4JetFlavourInfos__RECO.
  recoJetFlavourInfoMatchingCollection_patJetFlavourAssociation__RECO.
  recoJetFlavourMatchingCollection_patJetFlavourAssociationLegacy__RECO.
  recoJetMatchedPartonsCollection_patJetPartonAssociationLegacy__RECO.
  recoJetPiZeroAssociation_ak4PFJetsLegacyHPSPiZeros__RECO.
  recoPFJetChargedHadronAssociation_ak4PFJetsRecoTauChargedHadrons__RECO.
  recoPFTauDiscriminator_hpsPFTauDiscriminationByDeadECALElectronRejection__RECO.
  recoPFTauDiscriminator_hpsPFTauDiscriminationByDecayModeFindingNewDMs__RECO.
  recoPFTauDiscriminator_hpsPFTauDiscriminationByDecayModeFindingOldDMs__RECO.
  recoPFTauDiscriminator_hpsPFTauDiscriminationByDecayModeFinding__RECO.
  recoPFTauDiscriminator_hpsSelectionDiscriminator__RECO.
  recoPFTausedmRefProdrecoPFTauTransverseImpactParametersrecoPFTauTransverseImpactParameterrecoPFTauTransverseImpactParametersTorecoPFTauTransverseImpactParameteredmrefhelperFindUsingAdvanceedmRefsAssociationVector_hpsPFTauTransverseImpactParameters__RECO.
  recoPFTausedmRefProdrecoVertexsrecoVertexrecoVertexsTorecoVertexedmrefhelperFindUsingAdvanceedmRefsAssociationVector_hpsPFTauPrimaryVertexProducer__RECO.
  recoPFTausedmRefProdrecoVertexsrecoVertexrecoVertexsTorecoVertexedmrefhelperFindUsingAdvanceedmRefssAssociationVector_hpsPFTauSecondaryVertexProducer__RECO.
  ulongrecoPFClusteredmPtrstdpairs_particleFlowClusterECAL__RECO.
  ulongrecoPFClusteredmPtrstdpairs_particleFlowClusterOOTECAL__RECO.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------

fastsim2

----- Begin Fatal Exception 15-Jul-2024 22:30:25 CEST-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  std::pair<OmniClusterRef,edm::Ref<std::vector<TrackingParticle>,TrackingParticle,edm::refhelper::FindUsingAdvance<std::vector<TrackingParticle>,TrackingParticle> > >
  std::pair<edm::Ref<std::vector<TrackingParticle>,TrackingParticle,edm::refhelper::FindUsingAdvance<std::vector<TrackingParticle>,TrackingParticle> >,edm::Ref<std::vector<PSimHit>,PSimHit,edm::refhelper::FindUsingAdvance<std::vector<PSimHit>,PSimHit> > >
  std::pair<edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,edm::Ref<std::vector<reco::PFTauTransverseImpactParameter>,reco::PFTauTransverseImpactParameter,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTauTransverseImpactParameter>,reco::PFTauTransverseImpactParameter> > >
  std::pair<edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,edm::Ref<std::vector<reco::Vertex>,reco::Vertex,edm::refhelper::FindUsingAdvance<std::vector<reco::Vertex>,reco::Vertex> > >
  std::pair<edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,float>
  std::pair<edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,std::vector<edm::Ref<std::vector<reco::Vertex>,reco::Vertex,edm::refhelper::FindUsingAdvance<std::vector<reco::Vertex>,reco::Vertex> > > >
  std::pair<edm::RefToBase<reco::Jet>,reco::JetFlavour>
  std::pair<edm::RefToBase<reco::Jet>,reco::JetFlavourInfo>
  std::pair<edm::RefToBase<reco::Jet>,reco::MatchedPartons>
  std::pair<edm::RefToBase<reco::Jet>,std::vector<reco::PFRecoTauChargedHadron> >
  std::pair<edm::RefToBase<reco::Jet>,std::vector<reco::RecoTauPiZero> >
  std::pair<unsigned long,edm::Ptr<reco::PFCluster> >

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  ClusterTPAssociation (produced in current process)
  edm::AssociationVector<edm::RefProd<std::vector<reco::PFTau> >,std::vector<edm::Ref<std::vector<reco::PFTauTransverseImpactParameter>,reco::PFTauTransverseImpactParameter,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTauTransverseImpactParameter>,reco::PFTauTransverseImpactParameter> > >,edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,unsigned int,edm::helper::AssociationIdenticalKeyReference> (produced in current process)
  edm::AssociationVector<edm::RefProd<std::vector<reco::PFTau> >,std::vector<edm::Ref<std::vector<reco::Vertex>,reco::Vertex,edm::refhelper::FindUsingAdvance<std::vector<reco::Vertex>,reco::Vertex> > >,edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,unsigned int,edm::helper::AssociationIdenticalKeyReference> (produced in current process)
  edm::AssociationVector<edm::RefProd<std::vector<reco::PFTau> >,std::vector<std::vector<edm::Ref<std::vector<reco::Vertex>,reco::Vertex,edm::refhelper::FindUsingAdvance<std::vector<reco::Vertex>,reco::Vertex> > > >,edm::Ref<std::vector<reco::PFTau>,reco::PFTau,edm::refhelper::FindUsingAdvance<std::vector<reco::PFTau>,reco::PFTau> >,unsigned int,edm::helper::AssociationIdenticalKeyReference> (produced in current process)
  reco::JetFlavourInfoMatchingCollection (produced in current process)
  reco::JetFlavourMatchingCollection (produced in current process)
  reco::JetMatchedPartonsCollection (produced in current process)
  reco::JetPiZeroAssociation (produced in current process)
  reco::PFJetChargedHadronAssociation (produced in current process)
  reco::PFTauDiscriminator (produced in current process)
  std::vector<std::pair<edm::Ref<std::vector<TrackingParticle>,TrackingParticle,edm::refhelper::FindUsingAdvance<std::vector<TrackingParticle>,TrackingParticle> >,edm::Ref<std::vector<PSimHit>,PSimHit,edm::refhelper::FindUsingAdvance<std::vector<PSimHit>,PSimHit> > > > (produced in current process)
  std::vector<std::pair<unsigned long,edm::Ptr<reco::PFCluster> > > (produced in current process)

Missing dictionaries are associated with these branch names:

  ClusterTPAssociation_tpClusterProducerPreSplitting__RECO.
  ClusterTPAssociation_tpClusterProducer__RECO.
  TrackingParticlesTrackingParticleTrackingParticlesTrackingParticleedmrefhelperFindUsingAdvanceedmRefPSimHitsPSimHitPSimHitsPSimHitedmrefhelperFindUsingAdvanceedmRefstdpairs_simHitTPAssocProducer__RECO.
  recoJetFlavourInfoMatchingCollection_myak4JetFlavourInfos__RECO.
  recoJetFlavourInfoMatchingCollection_patJetFlavourAssociation__RECO.
  recoJetFlavourMatchingCollection_patJetFlavourAssociationLegacy__RECO.
  recoJetMatchedPartonsCollection_patJetPartonAssociationLegacy__RECO.
  recoJetPiZeroAssociation_ak4PFJetsLegacyHPSPiZeros__RECO.
  recoPFJetChargedHadronAssociation_ak4PFJetsRecoTauChargedHadrons__RECO.
  recoPFTauDiscriminator_hpsPFTauDiscriminationByDeadECALElectronRejection__RECO.
  recoPFTauDiscriminator_hpsPFTauDiscriminationByDecayModeFindingNewDMs__RECO.
  recoPFTauDiscriminator_hpsPFTauDiscriminationByDecayModeFindingOldDMs__RECO.
  recoPFTauDiscriminator_hpsPFTauDiscriminationByDecayModeFinding__RECO.
  recoPFTauDiscriminator_hpsSelectionDiscriminator__RECO.
  recoPFTausedmRefProdrecoPFTauTransverseImpactParametersrecoPFTauTransverseImpactParameterrecoPFTauTransverseImpactParametersTorecoPFTauTransverseImpactParameteredmrefhelperFindUsingAdvanceedmRefsAssociationVector_hpsPFTauTransverseImpactParameters__RECO.
  recoPFTausedmRefProdrecoVertexsrecoVertexrecoVertexsTorecoVertexedmrefhelperFindUsingAdvanceedmRefsAssociationVector_hpsPFTauPrimaryVertexProducer__RECO.
  recoPFTausedmRefProdrecoVertexsrecoVertexrecoVertexsTorecoVertexedmrefhelperFindUsingAdvanceedmRefssAssociationVector_hpsPFTauSecondaryVertexProducer__RECO.
  ulongrecoPFClusteredmPtrstdpairs_particleFlowClusterECAL__RECO.
  ulongrecoPFClusteredmPtrstdpairs_particleFlowClusterOOTECAL__RECO.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

makortel · 2024-07-15T21:35:35Z

Ok, this will need a deeper understanding on how to evolve the framework's dictionary existence checking.

makortel added 2 commits July 15, 2024 14:01

Remove all std::pair<X, Y> dictionaries as unnecessary

1578712

Move some std-only dictionary declarations to (Wrapped)StdDictionarie…

1488826

…s package

cmsbuild added this to the CMSSW_14_1_X milestone Jul 15, 2024

cmsbuild added reconstruction-pending simulation-pending l1-pending hlt-pending core-pending analysis-pending alca-pending db-pending generators-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending xpog-pending tracking trk changes-dataformats labels Jul 15, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 15, 2024

makortel mentioned this pull request Jul 15, 2024

Add edmDumpClassVersion and checkDictionaryUpdate.py scripts to check class version and checksum updates #45423

Merged

cmsbuild added tests-started and removed tests-pending labels Jul 15, 2024

cmsbuild added tests-rejected and removed tests-started labels Jul 15, 2024

makortel closed this Jul 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Remove all `std::pair<X, Y>` dictionaries as unnecessary #45466

[WIP] Remove all `std::pair<X, Y>` dictionaries as unnecessary #45466

makortel commented Jul 15, 2024 •

edited

Loading

cmsbuild commented Jul 15, 2024 •

edited

Loading

cmsbuild commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

makortel commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

makortel commented Jul 15, 2024

[WIP] Remove all std::pair<X, Y> dictionaries as unnecessary #45466

[WIP] Remove all std::pair<X, Y> dictionaries as unnecessary #45466

Conversation

makortel commented Jul 15, 2024 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Jul 15, 2024 • edited Loading

cmsbuild commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

makortel commented Jul 15, 2024

cmsbuild commented Jul 15, 2024

Unit Tests

RelVals

RelVals-INPUT

AddOn Tests

makortel commented Jul 15, 2024

[WIP] Remove all `std::pair<X, Y>` dictionaries as unnecessary #45466

[WIP] Remove all `std::pair<X, Y>` dictionaries as unnecessary #45466

makortel commented Jul 15, 2024 •

edited

Loading

cmsbuild commented Jul 15, 2024 •

edited

Loading