-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase 2 GTT MET cosLUT overflow fix #42553
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42553/36568
|
A new Pull Request was created by @NJManganelli (Nick) for master. It involves the following packages:
@epalencia, @AdrianoDee, @srimanob, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-408020/34250/summary.html Comparison SummarySummary:
|
Folks may be on holiday, but if there are any extant concerns before sign-off, please let me know. |
@NJManganelli Sorry, I'm on holiday. Would you object if I read and signed off tomorrow? Currently on west coast US time. |
Ehh, check that this is pretty simple. |
+l1 |
Thanks Andrew, enjoy your holiday, cheers! |
Are any upgrade folks back from vacation to review/comment? Cheers, |
@cms-sw/upgrade-l2 Any review for @NJManganelli on this? The PR changes are relatively small. |
type bug-fix |
@cmsbuild please test Retrigger the test after 2 weeks. When success, I will sign. Sorry for very delay. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-408020/34674/summary.html Comparison SummarySummary:
|
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR addresses a very rare bug, in which a lookuptable (vector) is addressed with out-of-bounds values. The solution is to extend the lookup table by 1 (it's generated in a loop based on the size of the updated constant). Firmware HLS does not currently match this, but HLS behavior with out-of-bounds access is not the same as C++
Parasitically, a review comment is addressed, cleaning up the code somewhat (unnecessary explicit setting of values to 0, which were already initialized as such). See #42347
PR validation:
This PR passes
scram b
scram b code-checks
scram b code-format
Additionally it's used to generate test vectors for L1T workflows, and all outputs are identical in cases not affected by the bug, and results are as expected in the region that is.
This will need to be backported to cms-l1t-offline Phase 2 integration branch