Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase 2 GTT MET cosLUT overflow fix #42553

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

NJManganelli
Copy link
Contributor

PR description:

This PR addresses a very rare bug, in which a lookuptable (vector) is addressed with out-of-bounds values. The solution is to extend the lookup table by 1 (it's generated in a loop based on the size of the updated constant). Firmware HLS does not currently match this, but HLS behavior with out-of-bounds access is not the same as C++

Parasitically, a review comment is addressed, cleaning up the code somewhat (unnecessary explicit setting of values to 0, which were already initialized as such). See #42347

PR validation:

This PR passes
scram b
scram b code-checks
scram b code-format

Additionally it's used to generate test vectors for L1T workflows, and all outputs are identical in cases not affected by the bug, and results are as expected in the region that is.

This will need to be backported to cms-l1t-offline Phase 2 integration branch

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42553/36568

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @NJManganelli (Nick) for master.

It involves the following packages:

  • L1Trigger/L1TTrackMatch (upgrade, l1)

@epalencia, @AdrianoDee, @srimanob, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-408020/34250/summary.html
COMMIT: 9f6c347
CMSSW: CMSSW_13_3_X_2023-08-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42553/34250/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3152843
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3152815
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@NJManganelli
Copy link
Contributor Author

Folks may be on holiday, but if there are any extant concerns before sign-off, please let me know.

@aloeliger
Copy link
Contributor

@NJManganelli Sorry, I'm on holiday. Would you object if I read and signed off tomorrow? Currently on west coast US time.

@aloeliger
Copy link
Contributor

Ehh, check that this is pretty simple.

@aloeliger
Copy link
Contributor

+l1

@NJManganelli
Copy link
Contributor Author

Ehh, check that this is pretty simple.

Thanks Andrew, enjoy your holiday, cheers!

@NJManganelli
Copy link
Contributor Author

Are any upgrade folks back from vacation to review/comment?

Cheers,
Nick

@aloeliger
Copy link
Contributor

@cms-sw/upgrade-l2 Any review for @NJManganelli on this? The PR changes are relatively small.

@srimanob
Copy link
Contributor

type bug-fix

@srimanob
Copy link
Contributor

@cmsbuild please test

Retrigger the test after 2 weeks. When success, I will sign. Sorry for very delay.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-408020/34674/summary.html
COMMIT: 9f6c347
CMSSW: CMSSW_13_3_X_2023-09-10-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42553/34674/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3153414
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3153389
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants