-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HGCAL trigger] Module splitting and updated seeding normalization #42246
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42246/36264
|
A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master. It involves the following packages:
@civanch, @epalencia, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @aloeliger can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
please abort |
please test with cms-data/L1Trigger-L1THGCal#24 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c3a88/33673/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
int subdet; | ||
int layer; | ||
int moduleU; | ||
int moduleV; | ||
int numTowers; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should likely be initialized to some null value if possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, indeed. Thanks @aloeliger
Done
int iEta_raw; | ||
int iPhi_raw; | ||
int towerShare; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should also be initialized to some null value if possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@cmsbuild please test Retrigger the test after two weeks. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c3a88/34700/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+Upgrade Change is expected (I assume) in the Phase-2 workflow, on L1T DQM. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
Please sign the cms-dist PR as well here |
+1 |
This PR depends on external cms-data/L1Trigger-L1THGCal#24
PR description:
Associated internal PRs and reviews:
PR validation:
Tested D86, D92, D94 workflows