[HGCAL trigger] Module splitting and updated seeding normalization #42246

jbsauvan · 2023-07-12T13:52:02Z

This PR depends on external cms-data/L1Trigger-L1THGCal#24

PR description:

Add possibility to split/share module energies between towers
- Study presented in HGCAL TPG meeting here
Improve normalization used in seeding
- Study with jets presented here
- Study with e/g presented here
Fixes in Module and Backend DetIds

Associated internal PRs and reviews:

PR validation:

Tested D86, D92, D94 workflows

runTheMatrix.py -w upgrade -l 20034.0 --maxSteps=2 & # D86
runTheMatrix.py -w upgrade -l 22434.0 --maxSteps=2 & # D92
runTheMatrix.py -w upgrade -l 23234.0 --maxSteps=2 & # D94

cmsbuild · 2023-07-12T14:00:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42246/36264

This PR adds an extra 44KB to repository

cmsbuild · 2023-07-12T14:01:02Z

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

DataFormats/ForwardDetId (upgrade, simulation)
DataFormats/L1THGCal (upgrade, l1)
L1Trigger/L1THGCal (upgrade, l1)
L1Trigger/L1THGCalUtilities (upgrade, l1)

@civanch, @epalencia, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @aloeliger can you please review it and eventually sign? Thanks.
@youyingli, @apsallid, @rovere, @lgray, @Martin-Grunewald, @missirol, @bsunanda, @amarini, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

civanch · 2023-07-13T09:30:07Z

please test

aloeliger · 2023-07-13T09:35:32Z

please abort

aloeliger · 2023-07-13T09:35:45Z

please test with cms-data/L1Trigger-L1THGCal#24

cmsbuild · 2023-07-13T15:01:12Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c3a88/33673/summary.html
COMMIT: 5bcce8c
CMSSW: CMSSW_13_2_X_2023-07-12-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42246/33673/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c3a88/33673/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c3a88/33673/git-merge-result

Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3193892
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3193865
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

aloeliger · 2023-07-18T11:43:41Z

L1Trigger/L1THGCal/src/HGCalTriggerTowerGeometryHelper.cc

+      int subdet;
+      int layer;
+      int moduleU;
+      int moduleV;
+      int numTowers;


These should likely be initialized to some null value if possible

Yes, indeed. Thanks @aloeliger
Done

aloeliger · 2023-07-18T11:44:20Z

L1Trigger/L1THGCal/src/HGCalTriggerTowerGeometryHelper.cc

+        int iEta_raw;
+        int iPhi_raw;
+        int towerShare;


These should also be initialized to some null value if possible

srimanob · 2023-09-11T15:08:20Z

@cmsbuild please test

Retrigger the test after two weeks.

cmsbuild · 2023-09-11T18:19:56Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c3a88/34700/summary.html
COMMIT: 5bd5c96
CMSSW: CMSSW_13_3_X_2023-09-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42246/34700/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c3a88/34700/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c3a88/34700/git-merge-result

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3003539
DQMHistoTests: Total failures: 58
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3003459
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 200 log files, 150 edm output root files, 46 DQM output files
TriggerResults: no differences found

srimanob · 2023-09-12T03:37:59Z

+Upgrade

Change is expected (I assume) in the Phase-2 workflow, on L1T DQM.

cmsbuild · 2023-09-12T03:38:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-09-12T14:58:00Z

Please sign the cms-dist PR as well here

rappoccio · 2023-09-14T13:03:32Z

+1

cmsbuild added this to the CMSSW_13_2_X milestone Jul 12, 2023

cmsbuild added simulation-pending l1-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Jul 12, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 12, 2023

aloeliger mentioned this pull request Jul 12, 2023

Add module to tower splitting map cms-data/L1Trigger-L1THGCal#24

Merged

jbsauvan mentioned this pull request Jul 13, 2023

Integration of updated seeding normalization and module splitting hgc-tpg/cmssw#64

Closed

cmsbuild added tests-started and removed tests-pending labels Jul 13, 2023

cmsbuild added the requires-external label Jul 13, 2023

cmsbuild added tests-approved and removed tests-started labels Jul 13, 2023

smuzaffar modified the milestones: CMSSW_13_2_X, CMSSW_13_3_X Jul 18, 2023

aloeliger reviewed Jul 18, 2023

View reviewed changes

jbsauvan added a commit to hgc-tpg/cmssw that referenced this pull request Jul 19, 2023

initialize variables to 0 (comments cms-sw#42246)

3ef388c

cmsbuild removed tests-approved requires-external code-checks-approved labels Jul 19, 2023

cmsbuild added simulation-approved and removed simulation-pending labels Sep 8, 2023

cmsbuild added tests-started and removed tests-approved labels Sep 11, 2023

cmsbuild added tests-approved and removed tests-started labels Sep 11, 2023

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Sep 12, 2023

cmsbuild added orp-approved and removed orp-pending labels Sep 14, 2023

cmsbuild merged commit 33c466c into cms-sw:master Sep 14, 2023

This was referenced Sep 14, 2023

Update tag for L1Trigger-L1THGCal to V01-08-00 cms-sw/cmsdist#8701

Merged

Update tag for Configuration-Generator to V01-07-00 cms-sw/cmsdist#8699

Merged

cmsbuild mentioned this pull request Sep 15, 2023

Phase2 MuonHLTSeed MVA Classifier CMSSW_13_3_X #42745

Merged

pallabidas mentioned this pull request Dec 15, 2023

[Phase2] calibrated GCT calo jets and taus cms-l1t-offline/cmssw#1189

Merged

jbsauvan added a commit to jbsauvan/cmssw that referenced this pull request Dec 22, 2023

initialize variables to 0 (comments cms-sw#42246)

d68cb1d

jbsauvan added a commit to jbsauvan/cmssw that referenced this pull request Dec 22, 2023

Comments cms-sw#42246, iteration 2

1efbcd4

jbsauvan added a commit to hgc-tpg/cmssw that referenced this pull request Dec 22, 2023

initialize variables to 0 (comments cms-sw#42246)

71a5e75

jbsauvan added a commit to hgc-tpg/cmssw that referenced this pull request Dec 22, 2023

Comments cms-sw#42246, iteration 2

1a69482

pallabidas mentioned this pull request Jan 18, 2024

[Phase-2 L1T] calibrated GCT calo jets and taus #43746

Merged

zhenbinwu pushed a commit to zhenbinwu/cmssw that referenced this pull request Feb 14, 2024

initialize variables to 0 (comments cms-sw#42246)

973c799

zhenbinwu pushed a commit to zhenbinwu/cmssw that referenced this pull request Feb 14, 2024

Comments cms-sw#42246, iteration 2

6050b38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HGCAL trigger] Module splitting and updated seeding normalization #42246

[HGCAL trigger] Module splitting and updated seeding normalization #42246

jbsauvan commented Jul 12, 2023

cmsbuild commented Jul 12, 2023

cmsbuild commented Jul 12, 2023

civanch commented Jul 13, 2023

aloeliger commented Jul 13, 2023

aloeliger commented Jul 13, 2023

cmsbuild commented Jul 13, 2023

aloeliger Jul 18, 2023

jbsauvan Jul 19, 2023

aloeliger Jul 18, 2023

jbsauvan Jul 19, 2023

srimanob commented Sep 11, 2023

cmsbuild commented Sep 11, 2023

srimanob commented Sep 12, 2023

cmsbuild commented Sep 12, 2023

rappoccio commented Sep 12, 2023

rappoccio commented Sep 14, 2023

[HGCAL trigger] Module splitting and updated seeding normalization #42246

[HGCAL trigger] Module splitting and updated seeding normalization #42246

Conversation

jbsauvan commented Jul 12, 2023

PR description:

PR validation:

cmsbuild commented Jul 12, 2023

cmsbuild commented Jul 12, 2023

civanch commented Jul 13, 2023

aloeliger commented Jul 13, 2023

aloeliger commented Jul 13, 2023

cmsbuild commented Jul 13, 2023

Comparison Summary

aloeliger Jul 18, 2023

Choose a reason for hiding this comment

jbsauvan Jul 19, 2023

Choose a reason for hiding this comment

aloeliger Jul 18, 2023

Choose a reason for hiding this comment

jbsauvan Jul 19, 2023

Choose a reason for hiding this comment

srimanob commented Sep 11, 2023

cmsbuild commented Sep 11, 2023

Comparison Summary

srimanob commented Sep 12, 2023

cmsbuild commented Sep 12, 2023

rappoccio commented Sep 12, 2023

rappoccio commented Sep 14, 2023