Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2023 WFs in runTheMatrix for tests #42588

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Conversation

sunilUIET
Copy link
Contributor

This PR adds more 2023 WFs in the runTheMatrix to be consistent with WFs with 2022 conditions as discussed in #41410

@sunilUIET
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42588/36616

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sunilUIET (sunil bansal) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @miquork, @sunilUIET, @srimanob, @AdrianoDee can you please review it and eventually sign? Thanks.
@makortel, @missirol, @slomeo, @fabiocos, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-682c67/34323/summary.html
COMMIT: 76c6d9d
CMSSW: CMSSW_13_3_X_2023-08-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42588/34323/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 12 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3152915
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3152890
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@sunilUIET
Copy link
Contributor Author

+pdmv

@srimanob
Copy link
Contributor

srimanob commented Aug 29, 2023

Hi @sunilUIET
To me, we have too many MC of Run-3 (11 workflows of MC 2021+2023) and we don't have any 2023 data workflow in the short matrix. I don't think it is in the good shape of testing new software.

@sunilUIET
Copy link
Contributor Author

@srimanob good point. We can add say JetMET for 2022 C,D 2023C,D. If you think any other addition will be good, please let me know.

@srimanob
Copy link
Contributor

Hi @sunilUIET
May I propose to reduce 2021 MC workflows, for example, removing PU samples. Then add a workflow of 2023 Data. Either C,D is good from my point.

adding data WF, reducing 2021 MC WFs
@sunilUIET
Copy link
Contributor Author

please test

@sunilUIET
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42588/36811

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2023

Pull request #42588 was updated. @bbilin, @miquork, @sunilUIET, @srimanob, @AdrianoDee can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-682c67/34611/summary.html
COMMIT: 29ce77f
CMSSW: CMSSW_13_3_X_2023-09-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42588/34611/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 12 lines from the logs
  • Reco comparison results: 21 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3003539
  • DQMHistoTests: Total failures: 2345
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3001172
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 200 log files, 150 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@sunilUIET
Copy link
Contributor Author

+pdmv

@srimanob
Copy link
Contributor

srimanob commented Sep 9, 2023

+Upgrade

Note to @cms-sw/reconstruction-l2 to update the comparison matrix later. Thx.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants