-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase 2 GTT MET cos LUT update #42347
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42347/36369
|
A new Pull Request was created by @NJManganelli (Nick) for master. It involves the following packages:
@epalencia, @AdrianoDee, @srimanob, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
…e LUTBins constant, ad the LUTShift.
…ction for the MET cos LUT, match the strict dependence on kCosLUTBins constant as in firmware.
…T with truncation of phi value, as in firmware.
1f06fa2
to
ce6d160
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42347/36397
|
Pull request #42347 was updated. @epalencia, @AdrianoDee, @srimanob, @cmsbuild, @aloeliger can you please check and sign again. |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
Are these relval timeouts becoming more frequent? When it makes sense, please retest |
@cmsbuild please test |
Thanks, Phat! |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57e87d/33920/summary.html Comparison SummarySummary:
|
+l1 |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
<< " Emu Sin(Phi): -" << cosLUT_[globalPhi - phiQuadrants_[3]] << "\n"; | ||
<< " Emu Phi: " << globalPhi | ||
<< " Emu Cos(Phi): " << cosLUT_[(phiQuadrants_[4] - 1 - globalPhi) >> l1tmetemu::kCosLUTShift] | ||
<< " Emu Sin(Phi): -" << cosLUT_[(globalPhi - phiQuadrants_[3]) >> l1tmetemu::kCosLUTShift] << "\n"; | ||
} | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This else
is not needed (as it overwrites the default value on the default itself), and it could be removed in order to simplify the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, that's a block of code from the department of redundancy department....
If I pass over this code again soon I'll add that bit to the chopping block, otherwise a separate code-clean PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in #42553
+1 |
PR description:
This PR brings the emulation into agreement with the firmware, where a harder cap on the LUT for cos (sin) function lookups (of tracks' phi value entering the L1T MET algorithm) is imposed to meet timing. This reduction in granularity is not expected to produce notable changes in the MET, as the changes merely depopulate the LUT of duplicate values (see https://gitlab.cern.ch/GTT/LibHLS/-/commit/4152f378fc26b06abe6541396c95717ee643ef7c).
This PR corresponds to the gtt/LibHLS PR for the branch here:
https://gitlab.cern.ch/GTT/LibHLS/-/tree/met_cosLUT_update
PR validation:
compiles
scram b code-checks; scram b code-format pass
runs GTT test vector generation successfully, indicating no breaking changes introduced
test vectors generated with this PR match corresponding firmware simulation in the above branch of the HLS repository
This PR will need to be backported to the cms-l1t-offline Phase 2 integration branch