Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase 2 GTT MET cos LUT update (backport) #1154

Conversation

NJManganelli
Copy link

PR description:

This PR brings the emulation into agreement with the firmware, where a harder cap on the LUT for cos (sin) function lookups (of tracks' phi value entering the L1T MET algorithm) is imposed to meet timing. This reduction in granularity is not expected to produce notable changes in the MET, as the changes merely depopulate the LUT of duplicate values (see https://gitlab.cern.ch/GTT/LibHLS/-/commit/4152f378fc26b06abe6541396c95717ee643ef7c).

This PR corresponds to the gtt/LibHLS PR for the branch here:
https://gitlab.cern.ch/GTT/LibHLS/-/tree/met_cosLUT_update

and to the PR in master
cms-sw#42347

PR validation:

compiles
scram b code-checks; scram b code-format pass
runs GTT test vector generation successfully, indicating no breaking changes introduced
test vectors generated with this PR match corresponding firmware simulation in the above branch of the HLS repository

This PR is the backport to the cms-l1t-offline Phase 2 integration branch

Nick Manganelli added 3 commits July 25, 2023 18:33
…ction for the MET cos LUT, match the strict dependence on kCosLUTBins constant as in firmware.
…T with truncation of phi value, as in firmware.
@epalencia epalencia merged commit 06e0bb3 into cms-l1t-offline:phase2-l1t-integration-1252patch1 Jul 28, 2023
@epalencia
Copy link

Tagged as l1t-phase2-v75.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants