Add missing include in FWCore/Utilities/src/path_configuration.cc

[perrotta]

PR description:

This should fix the issue reported in #40425 (comment) for gcc12
(Thank you @missirol for having checked and suggested)

PR validation:

It builds

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40452/33608

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

• FWCore/Utilities (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @wddgit, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test for el8_amd64_gcc12

[smuzaffar]

please test
lets start the default arch tests too. For gcc12 tests, it shouldbe enough it FWCore/Utilities compiles

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bbb07c/29835/summary.html
COMMIT: 84eb72a
CMSSW: CMSSW_13_0_X_2023-01-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40452/29835/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @mmusich update SiStripMonitorApproximateCluster ME ranges #40372
• @mmusich TrackingMonitor: extend lumi monitoring for Run-3 to 2.5E34 and remove SCAL in labels #40344
• @bsunanda Phase2-hgx333C Take care of invalid SiHits for V16 geometry of HGCal #40381
• @finnlabe B2G HLT DQM update #40359
• @bsunanda Phase2-hgx334B Extend some of the calling sequences of Geometry to include zside which is needed to treat correctly cassette shifts #40404
• @francescobrivio Restore DQM live clients process names #40421
• @missirol remove access to bare ROOT objects in HLTFiltersDQMonitor #40426
• @guitargeek Avoid including RooNLLVar.h in CMSSW #40440
• @makortel Migrate TestLegacy* DQM modules to edm::one::EDAnalyzer #40409
• @missirol make datafnPosition parameter configurable in online-DQM clients #40418
• @missirol guard TriggerRatesMonitor against unavailable trigger paths #40439

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bbb07c/29835/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bbb07c/29835/git-merge-result

Build

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02766/el8_amd64_gcc12/external/gcc/12.2.0-f8ec77b592790702d83afb7106a458e3/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lFWCoreParameterSet
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02766/el8_amd64_gcc12/external/gcc/12.2.0-f8ec77b592790702d83afb7106a458e3/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lFWCoreMessageLogger
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02766/el8_amd64_gcc12/external/gcc/12.2.0-f8ec77b592790702d83afb7106a458e3/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lDataFormatsProvenance
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02766/el8_amd64_gcc12/external/gcc/12.2.0-f8ec77b592790702d83afb7106a458e3/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lFWCorePluginManager
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02766/el8_amd64_gcc12/external/gcc/12.2.0-f8ec77b592790702d83afb7106a458e3/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lFWCoreReflection
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc12/src/DQM/SiStripMonitorApproximateCluster/plugins/DQMSiStripMonitorApproximateClusterAuto/libDQMSiStripMonitorApproximateClusterAuto.so] Error 1
Leaving library rule at src/DQM/SiStripMonitorApproximateCluster/plugins
>> Entering Package DQM/TrackingMonitor
>> Leaving Package DQM/TrackingMonitor
>> Package DQM/TrackingMonitor built


[perrotta]

The remaining build errors with gcc12 are not related any more with FWCore/Utilities/src/path_configuration.cc , and as such we should be happy: correct @smuzaffar ?

[smuzaffar]

The remaining build errors with gcc12 are not related any more with FWCore/Utilities/src/path_configuration.cc , and as such we should be happy: correct @smuzaffar ?

yes that is correct. FWCore/Utilities compiled so it should be good to fix the GCC12 build/link errors.

[makortel]

+1

Thanks @perrotta!

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bbb07c/29836/summary.html
COMMIT: 84eb72a
CMSSW: CMSSW_13_0_X_2023-01-09-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40452/29836/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 32 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555538
• DQMHistoTests: Total failures: 1194
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3554322
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[makortel]

Comparison differences are in 11634.7 (#39803 )

[perrotta]

+1