-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing include in FWCore/Utilities/src/path_configuration.cc #40452
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40452/33608
|
A new Pull Request was created by @perrotta (Andrea Perrotta) for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test for el8_amd64_gcc12 |
please test |
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02766/el8_amd64_gcc12/external/gcc/12.2.0-f8ec77b592790702d83afb7106a458e3/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lFWCoreParameterSet /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02766/el8_amd64_gcc12/external/gcc/12.2.0-f8ec77b592790702d83afb7106a458e3/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lFWCoreMessageLogger /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02766/el8_amd64_gcc12/external/gcc/12.2.0-f8ec77b592790702d83afb7106a458e3/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lDataFormatsProvenance /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02766/el8_amd64_gcc12/external/gcc/12.2.0-f8ec77b592790702d83afb7106a458e3/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lFWCorePluginManager /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02766/el8_amd64_gcc12/external/gcc/12.2.0-f8ec77b592790702d83afb7106a458e3/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lFWCoreReflection collect2: error: ld returned 1 exit status gmake: *** [tmp/el8_amd64_gcc12/src/DQM/SiStripMonitorApproximateCluster/plugins/DQMSiStripMonitorApproximateClusterAuto/libDQMSiStripMonitorApproximateClusterAuto.so] Error 1 Leaving library rule at src/DQM/SiStripMonitorApproximateCluster/plugins >> Entering Package DQM/TrackingMonitor >> Leaving Package DQM/TrackingMonitor >> Package DQM/TrackingMonitor built |
The remaining build errors with gcc12 are not related any more with FWCore/Utilities/src/path_configuration.cc , and as such we should be happy: correct @smuzaffar ? |
yes that is correct. |
+1 Thanks @perrotta! |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bbb07c/29836/summary.html Comparison SummarySummary:
|
Comparison differences are in 11634.7 (#39803 ) |
+1 |
PR description:
This should fix the issue reported in #40425 (comment) for gcc12
(Thank you @missirol for having checked and suggested)
PR validation:
It builds