-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate TestLegacy* DQM modules to edm::one::EDAnalyzer #40409
Conversation
I considered first removing them, but then realized there are still edm::one::EDAnalyzers using the DQMStore in the legacy way (i.e. via edm::Service<DQMStore>) that it is probably better to keep that functionality tested.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40409/33536
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c235e3/29772/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR migrates the
TestLegacy*
DQM modules toedm::one::EDAnalyzer<...>
as part of #36404. I considered first removing them, but then realized there are stilledm::one::EDAnalyzer
s using theDQMStore
in the legacy way (i.e. viaedm::Service<DQMStore>
), so it is probably better to keep that functionality tested.PR validation:
Unit tests run.