Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate TestLegacy* DQM modules to edm::one::EDAnalyzer #40409

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

makortel
Copy link
Contributor

PR description:

This PR migrates the TestLegacy* DQM modules to edm::one::EDAnalyzer<...> as part of #36404. I considered first removing them, but then realized there are still edm::one::EDAnalyzers using the DQMStore in the legacy way (i.e. via edm::Service<DQMStore>), so it is probably better to keep that functionality tested.

PR validation:

Unit tests run.

I considered first removing them, but then realized there are still
edm::one::EDAnalyzers using the DQMStore in the legacy way (i.e. via
edm::Service<DQMStore>) that it is probably better to keep that
functionality tested.
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40409/33536

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • DQMServices/Core (dqm)
  • DQMServices/Demo (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c235e3/29772/summary.html
COMMIT: 0aedc22
CMSSW: CMSSW_13_0_X_2022-12-27-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40409/29772/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555748
  • DQMHistoTests: Total failures: 151
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555575
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

  • spurious differences in DQM comparisons

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jan 7, 2023

+1

@makortel makortel deleted the migrateLegacyDemoDQM branch January 9, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants