Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase2-hgx334B Extend some of the calling sequences of Geometry to include zside which is needed to treat correctly cassette shifts #40404

Merged
merged 4 commits into from
Jan 7, 2023
Merged

Phase2-hgx334B Extend some of the calling sequences of Geometry to include zside which is needed to treat correctly cassette shifts #40404

merged 4 commits into from
Jan 7, 2023

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Dec 23, 2022 •
edited
Loading

PR description:

Extend some of the calling sequences of Geometry to include zside which is needed to treat correctly cassette shifts. There were several internal calls which were wrong in earlier versions. This may cause differences in predictions. Now all internal calls are checked and corrected.

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

Extend some of the calling sequences of Geometry to include zside whi…
3823bbd 
…ch is needed to treat correctly cassette shifts
@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Dec 23, 2022
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40404/33529

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40404/33530

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Geometry/HGCalCommonData (geometry, upgrade)
  • Geometry/HGCalGeometry (geometry, upgrade)
  • SimCalorimetry/HGCalSimAlgos (upgrade, simulation)
  • SimG4CMS/Calo (simulation)
  • Validation/HGCalValidation (dqm)

@civanch, @Dr15Jones, @bsunanda, @makortel, @emanueleusai, @ianna, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @mdhildreth, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@youyingli, @vandreev11, @fabiocos, @lecriste, @sethzenz, @missirol, @felicepantaleo, @rovere, @lgray, @cseez, @apsallid, @pfs, @thomreis, @hatakeyamak, @trtomei, @ebrondol, @sameasy, @beaucero, @slomeo, @simonepigazzini this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70bff5/29764/summary.html
COMMIT: 43225f6
CMSSW: CMSSW_13_0_X_2022-12-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40404/29764/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 20834.7620834.76_TTbar_14TeV+2026D88_HLTwDIGI75e33/step2_TTbar_14TeV+2026D88_HLTwDIGI75e33.log
  • 23234.0
----- Begin Fatal Exception 23-Dec-2022 14:42:54 CET-----------------------
An exception of category 'OutOfBound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module L1TEGMultiMerger/'l1tLayer1EG'
   [4] Prefetching for module L1TCorrelatorLayer1Producer/'l1tLayer1HGCal'
   [5] Prefetching for module PFClusterProducerFromHGC3DClusters/'l1tPFClustersFromHGC3DClusters'
   [6] Calling method for module HGCalBackendLayer2Producer/'l1tHGCalBackEndLayer2Producer'
Exception Message:
TC X1 = 2.40758 out of the seeding histogram bounds 0.076 - 0.58
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 23-Dec-2022 14:46:00 CET-----------------------
An exception of category 'OutOfBound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module L1TEGMultiMerger/'l1tLayer1EG'
   [4] Prefetching for module L1TCorrelatorLayer1Producer/'l1tLayer1HGCal'
   [5] Prefetching for module PFClusterProducerFromHGC3DClusters/'l1tPFClustersFromHGC3DClusters'
   [6] Calling method for module HGCalBackendLayer2Producer/'l1tHGCalBackEndLayer2Producer'
Exception Message:
TC X1 = 2.9504 out of the seeding histogram bounds 0.076 - 0.58
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

  • 20834.10320834.103_TTbar_14TeV+2026D88Aging3000/step2_TTbar_14TeV+2026D88Aging3000.log
  • 21034.11421034.114_TTbar_14TeV+2026D88PU_OTInefficiency10PC/step2_TTbar_14TeV+2026D88PU_OTInefficiency10PC.log

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70bff5/29765/summary.html
COMMIT: 8858165
CMSSW: CMSSW_13_0_X_2022-12-23-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40404/29765/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555748
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555723
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor Author

+geometry

@civanch
Copy link
Contributor

civanch commented Dec 25, 2022

+1

@bsunanda
Copy link
Contributor Author

@clacaputo, @mandrenguyen, @emanueleusai, @ahmad3213, @AdrianoDee, @srimanob Please approve this PR. Without this PR we cannot complete the full functionality of the V17 geometry of HGCal

@mandrenguyen
Copy link
Contributor

+reconstruction
No diffs in comparisons.
Changes to reco modules consist basically of a new flag for zside

@srimanob
Copy link
Contributor

srimanob commented Jan 3, 2023

+Upgrade

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jan 7, 2023

+1

@cmsbuild cmsbuild merged commit fedc937 into cms-sw:master Jan 7, 2023
@cmsbuild cmsbuild mentioned this pull request Jan 9, 2023
Merged
@srimanob srimanob mentioned this pull request Apr 19, 2023
Closed
@makortel makortel mentioned this pull request Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved dqm-approved fully-signed geometry-approved orp-approved reconstruction-approved simulation-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_13_0_X
Development

Successfully merging this pull request may close these issues.
7 participants
@bsunanda @cmsbuild @civanch @mandrenguyen @srimanob @emanueleusai @perrotta