-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx334B Extend some of the calling sequences of Geometry to include zside which is needed to treat correctly cassette shifts #40404
Conversation
…ch is needed to treat correctly cassette shifts
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40404/33529
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40404/33530
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @Dr15Jones, @bsunanda, @makortel, @emanueleusai, @ianna, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @mdhildreth, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
-1 Failed Tests: RelVals RelVals-INPUT RelVals
RelVals-INPUT |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70bff5/29765/summary.html Comparison SummarySummary:
|
+geometry |
+1 |
@clacaputo, @mandrenguyen, @emanueleusai, @ahmad3213, @AdrianoDee, @srimanob Please approve this PR. Without this PR we cannot complete the full functionality of the V17 geometry of HGCal |
+reconstruction |
+Upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Extend some of the calling sequences of Geometry to include zside which is needed to treat correctly cassette shifts. There were several internal calls which were wrong in earlier versions. This may cause differences in predictions. Now all internal calls are checked and corrected.
PR validation:
Use the runTheMatrix test workflows
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special