Revert "[L1-O2O] make WriterProxyT to use ESGetToken"

[perrotta]

Reverts #37681
The "complete" PR which includes also the unit tests (#37624) is now running succesfully those unit tests.
Therefore we decide to go for the "complete" solution, and the "partial" PR #37681 (without unit tests) should be reverted to avoid the complication of conflicts when merging.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37692/29514

• This PR adds an extra 8KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondTools/L1Trigger/interface/WriterProxy.h modified in PR(s): [L1-O2O] ESGetToken migration L1CondDBPayloadWriter and O2O unit tests #37602, [RFC] Migrate L1CondDBPayloadWriterExt to esConsumes #37628
  • File CondTools/L1TriggerExt/interface/DataWriterExt.h modified in PR(s): [L1-O2O] ESGetToken migration L1CondDBPayloadWriter and O2O unit tests #37602, [RFC] Migrate L1CondDBPayloadWriterExt to esConsumes #37628
  • File CondTools/L1TriggerExt/plugins/L1CondDBPayloadWriterExt.cc modified in PR(s): [L1-O2O] ESGetToken migration L1CondDBPayloadWriter and O2O unit tests #37602, [RFC] Migrate L1CondDBPayloadWriterExt to esConsumes #37628
  • File CondTools/L1TriggerExt/python/L1CondDBPayloadWriterExt_cfi.py modified in PR(s): [L1-O2O] ESGetToken migration L1CondDBPayloadWriter and O2O unit tests #37602
  • File CondTools/L1TriggerExt/src/DataWriterExt.cc modified in PR(s): [L1-O2O] ESGetToken migration L1CondDBPayloadWriter and O2O unit tests #37602, [RFC] Migrate L1CondDBPayloadWriterExt to esConsumes #37628
  • File CondTools/L1TriggerExt/test/L1ConfigWritePayloadOnlineExt_cfg.py modified in PR(s): [L1-O2O] ESGetToken migration L1CondDBPayloadWriter and O2O unit tests #37602
  • File L1TriggerConfig/L1TConfigProducers/src/L1TGlobalPrescalesVetosOnlineProd.cc modified in PR(s): [L1-O2O] ESGetToken migration L1CondDBPayloadWriter and O2O unit tests #37602
  • File L1TriggerConfig/L1TConfigProducers/src/L1TMuonBarrelParamsOnlineProd.cc modified in PR(s): [L1-O2O] ESGetToken migration L1CondDBPayloadWriter and O2O unit tests #37602

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

• CondTools/L1Trigger (db, l1)
• CondTools/L1TriggerExt (db)
• L1TriggerConfig/L1TConfigProducers (l1)

@malbouis, @epalencia, @cmsbuild, @rekovic, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

+db

• agreed

[epalencia]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

merge
(trusting in #37602)

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f2416/24241/summary.html
COMMIT: 51e15d4
CMSSW: CMSSW_12_4_X_2022-04-26-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37692/24241/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @panoskatsoulis [L1-O2O] make WriterProxyT to use ESGetToken #37681
• @mmusich get rid of more UB in TrackListMerger #37384
• @bsunanda Run2-gex131 Try to factorize a ddalgorithm used for forward pixel which can help in adopting legacy scenario to dd4hep #37645
• @SohamBhattacharya Cleaned GED electron isolation products #37644
• @fwyzard Update the year in the copyright notice #37682
• @cecilecaillol L1T: address issue 36647 with int overrun #37487
• @Sam-Harper FRDStreamSource Dangling Reference Fix : 12_4_X #37677

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f2416/24241/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f2416/24241/git-merge-result

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7f2416/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695434
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695404
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found